107494 - IME's committed string is entered twice due to new nsHTMLEditRules

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Masaki Katakai]

bug 25452 is now reproducible again with new Editor codes.
The first composed character can not be deleted on both Windows and
Linux. Also committed string is entered twice on Linux.

nsHTMLEditRules::WillInsertText() has been changed and now
uses

    res = wsObj.InsertText(*inString,...);

but the method just returns when inString = null but it should
handle the case for IME to delete composed text. See detail
bug 25452.

I have made a patch for nsWSRunObject.cpp. Please review.
It's serious for IME users.

Comment 1

[Masaki Katakai]

Attachment: proposed patch. Please review.

Comment 2

[kinmoz]

--> jfrancis

Joe, can you look over katakai's patch?

Comment 3

[Joe Francis]

I believe I want to put the test up in nsHTMLEditRules::WillInsertText() rather
than down in the whitespace handling code.  Thanks to Masaki for investigating this!

Comment 4

[Masaki Katakai]

Due to this problem, mail composer can not be used at all in japanese
environment on recent nightly. I heard many complaints of japanese users.

Comment 5

[Joe Francis]

Attachment: patch to nsHTMLEditRules.cpp

New version of patch that puts empty string test up in WillInsertText() rather
than down in the whitespacehandling code.

Comment 6

[Simon Fraser [no longer active]]

Comment on attachment 57648 [details] [diff] [review]
patch to nsHTMLEditRules.cpp

r=sfraser

Comment 7

[kinmoz]

Comment on attachment 57648 [details] [diff] [review]
patch to nsHTMLEditRules.cpp

sr=[e-mail]

With the comment we talked about explaining why we need to sidestep the wsObj
code.

Comment 8

[Christopher Blizzard (:blizzard)]

Comment on attachment 57648 [details] [diff] [review]
patch to nsHTMLEditRules.cpp

a=blizzard on behalf of drivers for 0.9.6

Comment 9

[Joe Francis]

This fix has landed on the 096 branch and trunk.

I need some verification help here.  I was able to test the fix for the deletion
portion of the bug description, but I was unable to test the linux issue, nor am
I confident this patch fixes the linux problem.  Can someone with a Linux IME
setup please verify this fix?

Comment 10

[Masaki Katakai]

I have already verified your patch on Solaris environment on my local build.
It works fine.
OK, I'll try nightly build tomorrow on linux.

Comment 11

[sujay]

Masaki,

please let us know after you verified this on Linux.

Then if you can mark this bug VERIFIED-FIXED...thanks..

Comment 12

[Masaki Katakai]

I've verified today's linux nightly it works fine.

However, Windows (111403) IME doesn't work at all. I can not see
any composed text. I'm not sure this change cause this problem
but 1113 nightly works fine.

How about your environment?

Comment 13

[Masaki Katakai]

filed as bug 110170.

Comment 14

[sujay]

marking verified per comments. new bug is addressed.