If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Leave the job details panel open after saving a classification

VERIFIED FIXED

Status

Tree Management
Treeherder
P1
normal
VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: emorley, Assigned: jfrench)

Tracking

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Currently after pressing "save" to submit a failure classification, the job details panel disappears.

This means a few things:
1) The job becomes unselected, so it's harder to find it again (especially if using "only show unclassified" mode), eg if you need to open a log to double check, or you wish to press retrigger.
2) Even if you don't want to interact with that particular job again, it causes a jarring UX when doing "press 'k' for next job, classify it, move onto next one" - since the job details panel pops up and hides repeatedly after each new cycle of that workflow.
(Assignee)

Comment 1

3 years ago
I'll have a look at this one. If I can get the correct behavior I'll assign myself.
Yeah, this should be pretty easy.  Possibly as simple as removing this line: https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/plugins/pinboard.js#L55-55
I guess the follow-up question would be: should it continue to clear the pinned jobs and the bugs/classification.  I presume that's still best.
(Reporter)

Comment 4

3 years ago
(In reply to Cameron Dawson [:camd] from comment #3)
> I guess the follow-up question would be: should it continue to clear the
> pinned jobs and the bugs/classification.  I presume that's still best.

Yeah I believe so
(Assignee)

Comment 5

3 years ago
(In reply to Cameron Dawson [:camd] from comment #2)
> Yeah, this should be pretty easy.  Possibly as simple as removing this line:
> https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/plugins/
> pinboard.js#L55-55

Agreed. This is also used in controllers/main to close the job panel during Esc.

I'm trying to set up a local back end service so I can test my change, since I need to log in to save a classification.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
(Assignee)

Comment 6

3 years ago
It appears that vagrant is not supported on x86 architecture on windows. I see exactly the same error. Note the vagrant customer reply from shackbarth at the bottom of the link.
http://www.xtuple.org/forums/xtuple-erp/initial-setup/vagrant-error-windows-xp-x86

I'll just make the UI change and camd or whoever merges can try my branch, or I can test it on dev with the UI change, since the service is running and I can successfully log in there.
(Assignee)

Comment 7

3 years ago
I actually realized I can just bypass the $scope.user.loggedin locally in the save, to test the fix. I will put up a PR shortly.
(Assignee)

Comment 8

3 years ago
Created attachment 8506367 [details] [review]
treeherder-ui-PR#235

Please see the above PR for review and status.
Attachment #8506367 - Flags: review?(cdawson)

Comment 9

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/0c9e2226bae5d5b304d3cef72e2dab49c0d9e217
Bug 1074972 - Keep the job panel open on a classification save

https://github.com/mozilla/treeherder-ui/commit/ab897f7f7d732a66764862647ade4b9c611dd818
Merge pull request #235 from tojonmz/save-classification-panelopen

Bug 1074972 - Keep the job panel open on a classification save

Updated

3 years ago
Attachment #8506367 - Flags: review?(cdawson) → review+
(Assignee)

Comment 10

3 years ago
Verified fixed and working correctly on dev/stage.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Status: RESOLVED → VERIFIED

Comment 11

2 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/667fb8e0df73f4a1e70335a81862a47c2c0950ac
Bug 1074972 - Keep the job panel open on a classification save

https://github.com/mozilla/treeherder/commit/c1d4aee4c3256f4f34d48fd8b376df3e2dfe34f2
Merge pull request #235 from tojonmz/save-classification-panelopen

Bug 1074972 - Keep the job panel open on a classification save
You need to log in before you can comment on or make changes to this bug.