1074972 - Leave the job details panel open after saving a classification

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Ed Morley [:emorley]]

Currently after pressing "save" to submit a failure classification, the job details panel disappears.

This means a few things:
1) The job becomes unselected, so it's harder to find it again (especially if using "only show unclassified" mode), eg if you need to open a log to double check, or you wish to press retrigger.
2) Even if you don't want to interact with that particular job again, it causes a jarring UX when doing "press 'k' for next job, classify it, move onto next one" - since the job details panel pops up and hides repeatedly after each new cycle of that workflow.

Comment 1

[Jonathan French (:jfrench)]

I'll have a look at this one. If I can get the correct behavior I'll assign myself.

Comment 2

[Cameron Dawson [:camd]]

Yeah, this should be pretty easy.  Possibly as simple as removing this line: https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/plugins/pinboard.js#L55-55

Comment 3

[Cameron Dawson [:camd]]

I guess the follow-up question would be: should it continue to clear the pinned jobs and the bugs/classification.  I presume that's still best.

Comment 4

[Ed Morley [:emorley]]

(In reply to Cameron Dawson [:camd] from comment #3)
> I guess the follow-up question would be: should it continue to clear the
> pinned jobs and the bugs/classification.  I presume that's still best.

Yeah I believe so

Comment 5

[Jonathan French (:jfrench)]

(In reply to Cameron Dawson [:camd] from comment #2)
> Yeah, this should be pretty easy.  Possibly as simple as removing this line:
> https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/plugins/
> pinboard.js#L55-55

Agreed. This is also used in controllers/main to close the job panel during Esc.

I'm trying to set up a local back end service so I can test my change, since I need to log in to save a classification.

Comment 6

[Jonathan French (:jfrench)]

It appears that vagrant is not supported on x86 architecture on windows. I see exactly the same error. Note the vagrant customer reply from shackbarth at the bottom of the link.
http://www.xtuple.org/forums/xtuple-erp/initial-setup/vagrant-error-windows-xp-x86

I'll just make the UI change and camd or whoever merges can try my branch, or I can test it on dev with the UI change, since the service is running and I can successfully log in there.

Comment 7

[Jonathan French (:jfrench)]

I actually realized I can just bypass the $scope.user.loggedin locally in the save, to test the fix. I will put up a PR shortly.

Comment 8

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#235

Please see the above PR for review and status.

Comment 9

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/0c9e2226bae5d5b304d3cef72e2dab49c0d9e217
Bug 1074972 - Keep the job panel open on a classification save

https://github.com/mozilla/treeherder-ui/commit/ab897f7f7d732a66764862647ade4b9c611dd818
Merge pull request #235 from tojonmz/save-classification-panelopen

Bug 1074972 - Keep the job panel open on a classification save

Comment 10

[Jonathan French (:jfrench)]

Verified fixed and working correctly on dev/stage.

Comment 11

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/667fb8e0df73f4a1e70335a81862a47c2c0950ac
Bug 1074972 - Keep the job panel open on a classification save

https://github.com/mozilla/treeherder/commit/c1d4aee4c3256f4f34d48fd8b376df3e2dfe34f2
Merge pull request #235 from tojonmz/save-classification-panelopen

Bug 1074972 - Keep the job panel open on a classification save