During Build, lightning is installed in wrong directory

RESOLVED FIXED in 3.8

Status

Calendar
Build Config
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Taraman, Assigned: Fallen)

Tracking

Trunk
x86_64
Linux
Dependency tree / graph

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
When building TB with "enable-calendar" on linux (I can't test other platforms at the moment), the extension is installed in "objdir/dist/bin/distribution/extension" ISO "objdir/dist/bin/extension"

Thus the addon is not enabled.

Comment 1

3 years ago
From my build on Windows 7 yesterday: Lightning is copied to obj-i686-pc-mingw32\dist\bin\distribution\extensions\{e2fda1a4-762b-4020-b5ad-a41df1933103}

When I start Thunderbird by calling |mach run| Lightning is installed and available. Probably because it was automatically deployed into the new profile at obj-i686-pc-mingw32\tmp\scratch_user\extensions\{e2fda1a4-762b-4020-b5ad-a41df1933103}

Reading e.g. http://mike.kaply.com/2012/02/09/integrating-add-ons-into-firefox/ this seems the correct way to deploy extensions automatically for users.

Maybe you are using an existing profile and therefore need to install Lightning manually?
(Assignee)

Comment 2

3 years ago
I bet this is something about the mac os signing changes. Previously just running it would be enough, at least for development mode I think we shouldn't require any more extra steps. Its probably worth asking folks in #build about this or CC'ing someone.
(Reporter)

Comment 3

3 years ago
Stefan, you are right. I use an existing profile.
But until recently, the extension was installed into ../dist/bin/extension and showed up correctly. If I copy it there manually, this still works.
(Assignee)

Updated

3 years ago
Depends on: 1047924
(Assignee)

Comment 4

3 years ago
Created attachment 8509609 [details] [diff] [review]
Fix - v1

This should take care. It reverts the behavior so that the extension is installed back into dist/bin, and makes sure that the rsync for mac drops it in Contents/Resources.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8509609 - Flags: review?(bugspam.Callek)
Comment on attachment 8509609 [details] [diff] [review]
Fix - v1

Review of attachment 8509609 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not great on the lightning makefile stuff, but looks correct
Attachment #8509609 - Flags: review?(bugspam.Callek) → review+

Comment 6

3 years ago
Great, with this patch I managed to successfully run calendar xpcshell tests for local Windows build again.

Comment 7

3 years ago
Is this patch ready for checked in?
Flags: needinfo?(philipp)
(Assignee)

Comment 8

3 years ago
Created attachment 8518121 [details] [diff] [review]
Fix - v1

I was just missing the checkin comment, sorry for the delay.
Attachment #8509609 - Attachment is obsolete: true
Flags: needinfo?(philipp)
Attachment #8518121 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
(Assignee)

Comment 9

3 years ago
https://hg.mozilla.org/comm-central/rev/3f10cc0c8d63
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 3.8
(Reporter)

Updated

3 years ago
Blocks: 1070881
You need to log in before you can comment on or make changes to this bug.