Closed
Bug 1047924
Opened 10 years ago
Closed 10 years ago
When building with ac_add_options --enable-extensions extensions are put expanded into the wrong location in dist/bin
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla34
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Keywords: dogfood, regression)
Attachments
(1 file)
1.22 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
In the old build system extensions would be expanded under dist/bin/distribution/extensions but they currently being put under dist/bin/extensions
This means that when a new user starts the application they do not have the extensions and they do not show up under Extensions in the Add-ons Manager.
The code that does the expansion starts at:
http://mxr.mozilla.org/comm-central/source/mozilla/config/rules.mk#1361
Severity: normal → critical
Keywords: dogfood,
regression
I did look at potentially using DIST_SUBDIR but that also changes FINAL_TARGET in config.mk and I think it is not the intended use of DIST_SUBDIR.
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #8466763 -
Flags: review?(mh+mozilla)
Comment 2•10 years ago
|
||
Comment on attachment 8466763 [details] [diff] [review]
Proposed fix [Checked into m-i: Comment 3]
Review of attachment 8466763 [details] [diff] [review]:
-----------------------------------------------------------------
meh
Attachment #8466763 -
Flags: review?(mh+mozilla) → review+
Comment on attachment 8466763 [details] [diff] [review]
Proposed fix [Checked into m-i: Comment 3]
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae747b1cc524
Attachment #8466763 -
Attachment description: Proposed fix → Proposed fix [Checked into m-i: Comment 3]
Attachment #8466763 -
Flags: checkin+
Comment 4•10 years ago
|
||
What used to happen was that extensions were built into dist/bin/extensions and then in omnijar builds suite/app/Makefile.in would zip them up into XPIs into dist/bin/extensions or dist/bin/distribution/extensions as appropriate, but if you used --enable-chrome-format=flat then the extensions would remain flat in dist/bin/extensions so that you could easily develop them. Is there any way we can maintain this developer option?
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Updated•10 years ago
|
Flags: qe-verify+
Comment 6•10 years ago
|
||
This is probably not worth spending the time to verify since it does not affect standard builds.
Flags: qe-verify+ → qe-verify-
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•