Closed Bug 1075232 Opened 5 years ago Closed 5 years ago

Record which suggestion of the search screen was tapped in telemetry

Categories

(Firefox for Android :: Awesomescreen, defect)

x86
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 35
Tracking Status
firefox33 --- wontfix
firefox34 --- fixed
firefox35 --- fixed

People

(Reporter: antlam, Assigned: Margaret)

Details

Attachments

(2 files)

Similar to bug 1068739

But, since the UI is quite different in Firefox, it'd be nice to know this too. Also note, only the default gets placed above frecency results in this case. There might be some interesting numbers here that we could use to improve this UX too.
Flags: needinfo?(mark.finkle)
Just so we have some defined terms, I'm attaching an image with the search suggestions labelled:
A = Just what the user typed. Not really a suggestion. UI Telemetry: "user"
B = Engine provide suggestion that is also a valid URL. UI Telemetry: "url"
C = Engine provide suggestion. UI Telemetry: "engine"

What additional data would you like saved?
Flags: needinfo?(mark.finkle)
Perfect, can we also get Engine 0's A, Engine 1's A, Engine 2's A, Engine 3's A, etc?
Flags: needinfo?(mark.finkle)
Assignee: nobody → margaret.leibovic
This just replaces "engine" with "engine.1", "engine.2", etc. depending on which engine suggestion was tapped.
Attachment #8499585 - Flags: review?(mark.finkle)
Attachment #8499585 - Flags: review?(mark.finkle) → review+
Flags: needinfo?(mark.finkle)
(In reply to :Margaret Leibovic from comment #3)
> Created attachment 8499585 [details] [diff] [review]
> Record position of search suggestion that was tapped in telemetry
> 
> This just replaces "engine" with "engine.1", "engine.2", etc. depending on
> which engine suggestion was tapped.

Awesome!
https://hg.mozilla.org/mozilla-central/rev/d1094a154b41
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Comment on attachment 8499585 [details] [diff] [review]
Record position of search suggestion that was tapped in telemetry

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: Useful telemetry
[Describe test coverage new/current, TBPL]:
[Risks and why]: low risk, small patch
[String/UUID change made/needed]: none
Attachment #8499585 - Flags: approval-mozilla-beta?
Comment on attachment 8499585 [details] [diff] [review]
Record position of search suggestion that was tapped in telemetry

Beta+
Attachment #8499585 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.