1075531 - Robocop failures in larch due to changes in toolbar

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

See https://tbpl.mozilla.org/?tree=Larch&rev=feb54976e5b9

All of them are related to the fact that we now always show URL instead of title in the URL entry. mcomella, could you have a look?

Maybe the right thing to do here is to adapt the tests to account for the title/url pref?

Comment 1

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

https://tbpl.mozilla.org/?tree=Try&rev=0f6fc265e7bb

Comment 2

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

https://tbpl.mozilla.org/?tree=Try&rev=1a80dc6a2475

Comment 3

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

https://tbpl.mozilla.org/?tree=Try&rev=b8306aadd467

Comment 4

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Attachment: Part 1: Return String from ToolbarComponent.getTitle

This was causing some failures in UI test where we compare String to CharSequence.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

https://tbpl.mozilla.org/?tree=Try&rev=a2c0fd82089e

Comment 6

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Attachment: Part 2: Check for url in place of page titles on new tablet

Confident about this one - try run in comment 5.

I take both a title and url when verifying page titles - NewTablet will use the
latter, phone and old tablet will use the former. Note that we have to adjust
the url in the toolbar: about:home appears as "" and http:// urls drop that
prefix.

I also included a change to return from testTitleBar immediately if we are on
new tablet because there's no preference change to test. This should be a
separate part, but I don't want to have yet-another-try-push.

Comment 7

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Attachment: Part 2: Check for url in place of page titles on new tablet

Try is closed so here is the (rebased) patch in the meantime. It seems I forgot to get the absolute URL when calling into checkDevice in testClearPrivateData.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

https://tbpl.mozilla.org/?tree=Try&rev=ac576f53f4d4

Comment 9

[Lucas Rocha (:lucasr)]

Comment on attachment 8502807 [details] [diff] [review]
Part 2: Check for url in place of page titles on new tablet

Review of attachment 8502807 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me.

::: mobile/android/base/tests/testClearPrivateData.java
@@ +1,3 @@
>  package org.mozilla.gecko.tests;
>  import org.mozilla.gecko.Actions;
> +import org.mozilla.gecko.NewTabletUI;

Unused?

Comment 10

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Attachment: Part 2: Check for url in place of page titles on new tablet

Removed unused import, as per comment 9.

Comment 11

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/132f861349a2
https://hg.mozilla.org/integration/fx-team/rev/59c761f6c0eb

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Backed out for mass robocop/talos bustage.
https://hg.mozilla.org/integration/fx-team/rev/683b81f8a9d3

https://treeherder.mozilla.org/ui/#/jobs?repo=fx-team&revision=59c761f6c0eb

Comment 13

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/2b027c3e1736
https://hg.mozilla.org/integration/fx-team/rev/cac24f45f415

Comment 14

[Carsten Book [:Tomcat]]

sorry had to back this out for S4 Test failures like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=907896&repo=fx-team

Comment 15

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Attachment: Part 3: Match page titles by regex in testAboutPage

I messed up the regex here. This would re-land on top of parts 1 and 2.

Comment 16

[Lucas Rocha (:lucasr)]

Comment on attachment 8505871 [details] [diff] [review]
Part 3: Match page titles by regex in testAboutPage

Review of attachment 8505871 [details] [diff] [review]:
-----------------------------------------------------------------

Yep.

Comment 17

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/8882bf98a437
https://hg.mozilla.org/integration/fx-team/rev/9eb089d7c2b9
https://hg.mozilla.org/integration/fx-team/rev/ae71da76c733

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8882bf98a437
https://hg.mozilla.org/mozilla-central/rev/9eb089d7c2b9
https://hg.mozilla.org/mozilla-central/rev/ae71da76c733