Robocop failures in larch due to changes in toolbar

RESOLVED FIXED in Firefox 36

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: lucasr, Assigned: mcomella)

Tracking

unspecified
Firefox 36
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

See https://tbpl.mozilla.org/?tree=Larch&rev=feb54976e5b9

All of them are related to the fact that we now always show URL instead of title in the URL entry. mcomella, could you have a look?

Maybe the right thing to do here is to adapt the tests to account for the title/url pref?
This was causing some failures in UI test where we compare String to CharSequence.
Attachment #8502142 - Flags: review?(lucasr.at.mozilla)
Confident about this one - try run in comment 5.

I take both a title and url when verifying page titles - NewTablet will use the
latter, phone and old tablet will use the former. Note that we have to adjust
the url in the toolbar: about:home appears as "" and http:// urls drop that
prefix.

I also included a change to return from testTitleBar immediately if we are on
new tablet because there's no preference change to test. This should be a
separate part, but I don't want to have yet-another-try-push.
Attachment #8502147 - Flags: review?(lucasr.at.mozilla)
Status: NEW → ASSIGNED
Attachment #8502142 - Flags: review?(lucasr.at.mozilla) → review+
Try is closed so here is the (rebased) patch in the meantime. It seems I forgot to get the absolute URL when calling into checkDevice in testClearPrivateData.
Attachment #8502807 - Flags: review?(lucasr.at.mozilla)
Attachment #8502147 - Attachment is obsolete: true
Attachment #8502147 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 8502807 [details] [diff] [review]
Part 2: Check for url in place of page titles on new tablet

Review of attachment 8502807 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me.

::: mobile/android/base/tests/testClearPrivateData.java
@@ +1,3 @@
>  package org.mozilla.gecko.tests;
>  import org.mozilla.gecko.Actions;
> +import org.mozilla.gecko.NewTabletUI;

Unused?
Attachment #8502807 - Flags: review?(lucasr.at.mozilla) → review+
Attachment #8502807 - Attachment is obsolete: true
I messed up the regex here. This would re-land on top of parts 1 and 2.
Attachment #8505871 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 8505871 [details] [diff] [review]
Part 3: Match page titles by regex in testAboutPage

Review of attachment 8505871 [details] [diff] [review]:
-----------------------------------------------------------------

Yep.
Attachment #8505871 - Flags: review?(lucasr.at.mozilla) → review+
You need to log in before you can comment on or make changes to this bug.