Closed
Bug 1075531
Opened 10 years ago
Closed 10 years ago
Robocop failures in larch due to changes in toolbar
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 36
People
(Reporter: lucasr, Assigned: mcomella)
References
Details
Attachments
(3 files, 2 obsolete files)
1.94 KB,
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
46.27 KB,
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
2.63 KB,
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
See https://tbpl.mozilla.org/?tree=Larch&rev=feb54976e5b9
All of them are related to the fact that we now always show URL instead of title in the URL entry. mcomella, could you have a look?
Maybe the right thing to do here is to adapt the tests to account for the title/url pref?
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Comment 4•10 years ago
|
||
This was causing some failures in UI test where we compare String to CharSequence.
Attachment #8502142 -
Flags: review?(lucasr.at.mozilla)
Assignee | ||
Comment 5•10 years ago
|
||
Assignee | ||
Comment 6•10 years ago
|
||
Confident about this one - try run in comment 5.
I take both a title and url when verifying page titles - NewTablet will use the
latter, phone and old tablet will use the former. Note that we have to adjust
the url in the toolbar: about:home appears as "" and http:// urls drop that
prefix.
I also included a change to return from testTitleBar immediately if we are on
new tablet because there's no preference change to test. This should be a
separate part, but I don't want to have yet-another-try-push.
Attachment #8502147 -
Flags: review?(lucasr.at.mozilla)
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Updated•10 years ago
|
Attachment #8502142 -
Flags: review?(lucasr.at.mozilla) → review+
Assignee | ||
Comment 7•10 years ago
|
||
Try is closed so here is the (rebased) patch in the meantime. It seems I forgot to get the absolute URL when calling into checkDevice in testClearPrivateData.
Attachment #8502807 -
Flags: review?(lucasr.at.mozilla)
Assignee | ||
Updated•10 years ago
|
Attachment #8502147 -
Attachment is obsolete: true
Attachment #8502147 -
Flags: review?(lucasr.at.mozilla)
Assignee | ||
Comment 8•10 years ago
|
||
Reporter | ||
Comment 9•10 years ago
|
||
Comment on attachment 8502807 [details] [diff] [review]
Part 2: Check for url in place of page titles on new tablet
Review of attachment 8502807 [details] [diff] [review]:
-----------------------------------------------------------------
Works for me.
::: mobile/android/base/tests/testClearPrivateData.java
@@ +1,3 @@
> package org.mozilla.gecko.tests;
> import org.mozilla.gecko.Actions;
> +import org.mozilla.gecko.NewTabletUI;
Unused?
Attachment #8502807 -
Flags: review?(lucasr.at.mozilla) → review+
Assignee | ||
Comment 10•10 years ago
|
||
Removed unused import, as per comment 9.
Assignee | ||
Updated•10 years ago
|
Attachment #8502807 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Attachment #8503334 -
Flags: review+
Assignee | ||
Comment 11•10 years ago
|
||
Comment 12•10 years ago
|
||
Backed out for mass robocop/talos bustage.
https://hg.mozilla.org/integration/fx-team/rev/683b81f8a9d3
https://treeherder.mozilla.org/ui/#/jobs?repo=fx-team&revision=59c761f6c0eb
Assignee | ||
Comment 13•10 years ago
|
||
Comment 14•10 years ago
|
||
sorry had to back this out for S4 Test failures like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=907896&repo=fx-team
Assignee | ||
Comment 15•10 years ago
|
||
I messed up the regex here. This would re-land on top of parts 1 and 2.
Attachment #8505871 -
Flags: review?(lucasr.at.mozilla)
Reporter | ||
Comment 16•10 years ago
|
||
Comment on attachment 8505871 [details] [diff] [review]
Part 3: Match page titles by regex in testAboutPage
Review of attachment 8505871 [details] [diff] [review]:
-----------------------------------------------------------------
Yep.
Attachment #8505871 -
Flags: review?(lucasr.at.mozilla) → review+
Assignee | ||
Comment 17•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8882bf98a437
https://hg.mozilla.org/mozilla-central/rev/9eb089d7c2b9
https://hg.mozilla.org/mozilla-central/rev/ae71da76c733
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•