Closed
Bug 1075549
Opened 10 years ago
Closed 10 years ago
Firefox needs a restart in order to update the default search engine from the "<term> - Search with <engine>" string
Categories
(Toolkit :: Places, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox35 | --- | verified |
People
(Reporter: avaida, Assigned: Unfocused)
References
Details
Attachments
(1 file)
2.25 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
Note: this is a follow-up bug for Bug 1067888. Reproducible on: * Nightly 35.0a1 (2014-10-01) using Windows 7 64-bit, Ubuntu 14.04 LTS 32-bit and Mac OS X 10.9.5. STR: 1. Launch Firefox with a clean profile. 2. Set a default search engine, e.g. Google. 3. Search for something using the awesomebar, e.g. 'example' (w/o apostrophe). 4. Change the default search engine by clicking on the Google favicon displayed in the Search Bar, e.g. change it to Bing. 5. Type in a different search term in the awesomebar without pressing the <enter> key. ER: 3. The suggestions pane displays the following entry: "example - Search with Google". 5. The suggestions pane displays the following entry: "example - Search with Bing". AR: 5. The suggestions pane is still displaying the following entry: "example - Search with Google", instead of "... with Bing". Additional notes: - This issue is *not a regression*, given that it's reproducible starting with the build in which Bug 1067888 first landed. - If you restart the browser after switching to another search engine, the string is updated. - This issue is reproducible across all platforms. - Screenshot depicting the issue: http://i.imgur.com/qOL2mnc.png.
Flags: qe-verify+
Assignee | ||
Comment 1•10 years ago
|
||
Turns out this was what we causing my tests to fail elsewhere!
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Points: --- → 3
Flags: needinfo?(mmucci)
Flags: firefox-backlog+
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8499260 -
Flags: review?(mak77)
Updated•10 years ago
|
Blocks: UnifiedComplete
Comment 5•10 years ago
|
||
Comment on attachment 8499260 [details] [diff] [review] Patch v1 Review of attachment 8499260 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/places/tests/unifiedcomplete/test_searchEngine_current.js @@ +34,5 @@ > + do_log_info("search engine, after current engine has changed"); > + Services.search.addEngineWithDetails("MozSearch2", "", "", "", "GET", > + "http://s.example.com/search2"); > + engine = Services.search.getEngineByName("MozSearch2"); > + Services.search.currentEngine = engine; could you please add a sanity test checking that currentEngine is not engine, before you set it?
Attachment #8499260 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/49c1e23101a2
https://hg.mozilla.org/mozilla-central/rev/49c1e23101a2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Reporter | ||
Comment 8•10 years ago
|
||
Verified fixed on Nightly 35.0a1 (2014-10-08) using Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 LTS 32-bit.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•