Change the TabsLayoutAdapter API to use TabsLayoutItemView instead of the generic View

RESOLVED FIXED in Firefox 35

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mhaigh, Assigned: mhaigh)

Tracking

unspecified
Firefox 35
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8498213 [details] [diff] [review]
Change the TabsLayoutAdapter API to use TabsLayoutItemView instead of the generic View
Attachment #8498213 - Flags: feedback?(lucasr.at.mozilla)
Comment on attachment 8498213 [details] [diff] [review]
Change the TabsLayoutAdapter API to use TabsLayoutItemView instead of the generic View

Review of attachment 8498213 [details] [diff] [review]:
-----------------------------------------------------------------

Yep.

::: mobile/android/base/tabs/TabsGridLayout.java
@@ +100,2 @@
>              super.bindView(view, tab);
> +            view.close.setVisibility(View.VISIBLE);

Why do you need to set the close button's visibility here? Is it because the shared layout file has visibility GONE by default?
Attachment #8498213 - Flags: feedback?(lucasr.at.mozilla) → feedback+
(Assignee)

Comment 3

4 years ago
Good spot - it doesn't seem to be there for a reason and things look good without it there.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=289ccaff48d8
Comment on attachment 8498213 [details] [diff] [review]
Change the TabsLayoutAdapter API to use TabsLayoutItemView instead of the generic View

Review of attachment 8498213 [details] [diff] [review]:
-----------------------------------------------------------------

Go.
Attachment #8498213 - Flags: feedback+ → review+

Comment 6

4 years ago
https://hg.mozilla.org/mozilla-central/rev/02e5436e40ed
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
You need to log in before you can comment on or make changes to this bug.