Closed
Bug 1075576
Opened 10 years ago
Closed 10 years ago
Change the TabsLayoutAdapter API to use TabsLayoutItemView instead of the generic View
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: mhaigh, Assigned: mhaigh)
References
Details
Attachments
(1 file)
4.18 KB,
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8498213 -
Flags: feedback?(lucasr.at.mozilla)
Comment 2•10 years ago
|
||
Comment on attachment 8498213 [details] [diff] [review] Change the TabsLayoutAdapter API to use TabsLayoutItemView instead of the generic View Review of attachment 8498213 [details] [diff] [review]: ----------------------------------------------------------------- Yep. ::: mobile/android/base/tabs/TabsGridLayout.java @@ +100,2 @@ > super.bindView(view, tab); > + view.close.setVisibility(View.VISIBLE); Why do you need to set the close button's visibility here? Is it because the shared layout file has visibility GONE by default?
Attachment #8498213 -
Flags: feedback?(lucasr.at.mozilla) → feedback+
Assignee | ||
Comment 3•10 years ago
|
||
Good spot - it doesn't seem to be there for a reason and things look good without it there. https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=289ccaff48d8
Comment 4•10 years ago
|
||
Comment on attachment 8498213 [details] [diff] [review] Change the TabsLayoutAdapter API to use TabsLayoutItemView instead of the generic View Review of attachment 8498213 [details] [diff] [review]: ----------------------------------------------------------------- Go.
Attachment #8498213 -
Flags: feedback+ → review+
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/02e5436e40ed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/02e5436e40ed
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•