1075616 - SurfacePattern::mSamplingRect does not work correctly for very large surfaces with Direct2D

Status: RESOLVED FIXED

Description

[Bas Schouten (:bas.schouten)]

This is unlikely to cause real problems since cases where we use mSamplingRect shouldn't normally deal with very large images.

But CreatePartialBitmapForSurface doesn't play nicely with SurfacePattern::mSamplingRect. This means for border-image where the image is larger than 8192 pixels in some direction we might have a bug. I don't think this is high priority but I wanted to have this on file in case someone does run into this.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Created attachment 8498539 [details] [diff] [review]
Do partial uploads when we have a sampling rect

Is this what you had in mind?

Comment 2

[Matt Woodrow (:mattwoodrow)]

Created attachment 8498543 [details] [diff] [review]
Do partial uploads when we have a sampling rect

Comment 5

[Matt Woodrow (:mattwoodrow)]

Looks like this may be high priority, found two duplicates of it already.

Comment 6

[Loic]

[Tracking Requested - why for this release]:

Comment 7

[Bas Schouten (:bas.schouten)]

Comment on attachment 8498543 [details] [diff] [review]
Do partial uploads when we have a sampling rect

Review of attachment 8498543 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, this should do it, we'll need something similar for D2D 1.1. Again, no hurry, but eventually it's probably better if we sort it out. It's probably going to be a little annoying to test.

::: gfx/2d/DrawTargetD2D.cpp
@@ +2378,5 @@
>          MOZ_ASSERT("Invalid sampling rect size!");
>          return nullptr;
>        }
>  
> +      dt->CopySurface(source, samplingRect, IntPoint())

nit: You'll need to re-add that ; you removed :P

@@ +2418,5 @@
> +        if (sourceRect.IsEmpty()) {
> +          sourceRect = IntRect(0, 0, source->GetSize().width, source->GetSize().height);
> +        }
> +
> +        bitmap = CreatePartialBitmapForSurface(dataSurf, mTransform, mSize, pat->mExtendMode, mat, mRT, &sourceRect); 

nit: might as well fix the whitespace while you're in this line :)

Comment 8

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b49657fad19

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1b49657fad19