1075998 - Reviews deleted by moderators should be soft-deleted and restorable by admins

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Kris Maglione [:kmag]]

Reviews are often accidentally or otherwise incorrectly deleted. Deleted reviews should always be restorable by administrators.

Comment 1

[Andrew Williamson [:eviljeff]]

commit url please

Comment 2

[Kris Maglione [:kmag]]

https://github.com/mozilla/olympia/pull/374/

Comment 3

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/2d0b8ba01a9b4ae65b74168a289f1ad4e8fd430a

Comment 4

[Valentina Virlics [:vvalentina], Ecosystem QA]

I have some questions regarding to deleting a review:
- if I delete a review it doesn't appear in Moderated Review Log, like I suppose it should...or maybe the action (deletion) is not made instantly? 
- i can also see some deleted reviews (old ones) in the Moderated Review Log, but if I click "More details" link there is no possibility to undelete the review...is that intended or it's an issue, or it's possible I don't have enough rights? (I recall this feature - Moderated Review Log - was "translated" in Marketplace also, and there is a "undelete" button)
 
Thank you!

Comment 5

[Kris Maglione [:kmag]]

Reviews can only be undeleted by senior reviewers, or the editor who deleted them.

Deleted reviews only appear in the moderation log if they're deleted via the moderation queue.

Reviews deleted via the 'Delete review' link on review pages are still soft deleted, but don't show up in review logs, and are much more difficult to restore. This is bug 1076005, though, and needs to be fixed separately.

Comment 6

[Valentina Virlics [:vvalentina], Ecosystem QA]

Thank you for the info! 

According to comment #5, I verified as fixed on AMO-dev FF36(Win 7) the issue from comment #0.
Postfix screencast: http://screencast.com/t/QBrp9OLmJGpa
Closing.