[10.10] disabled default buttons on Yosemite get white button text (e.g. download dialog "save file" button before it's enabled)

VERIFIED FIXED in Firefox 34

Status

()

Toolkit
Themes
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

(Blocks: 1 bug)

Trunk
mozilla35
x86
Mac OS X
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +
in-testsuite -
qe-verify +

Firefox Tracking Flags

(firefox34 verified, firefox35 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
The selector for this case needs tweaking to have :not([disabled=true]).
(Assignee)

Updated

4 years ago
Flags: qe-verify+
Flags: in-testsuite-
Flags: firefox-backlog+
(Assignee)

Comment 1

4 years ago
Taking this so we can uplift 1044595 for 34.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 35.3
Flags: needinfo?(mmucci)
(Assignee)

Comment 2

4 years ago
Created attachment 8499186 [details] [diff] [review]
[10.10] disabled default button shouldn't get white text on yosemite,
Attachment #8499186 - Flags: review?(jaws)
Attachment #8499186 - Flags: review?(jaws) → review+
Added to IT 35.3
Flags: needinfo?(mmucci)
(Assignee)

Comment 4

4 years ago
Created attachment 8499255 [details] [diff] [review]
[10.10] disabled default button shouldn't get white text on yosemite,

And then I realized the same goes for disabled normal buttons on :hover:active :-(
Attachment #8499255 - Flags: review?(jaws)
(Assignee)

Updated

4 years ago
Attachment #8499186 - Attachment is obsolete: true
(Assignee)

Comment 5

4 years ago
Comment on attachment 8499255 [details] [diff] [review]
[10.10] disabled default button shouldn't get white text on yosemite,

Jared reviewed this over IRC.

remote:   https://hg.mozilla.org/integration/fx-team/rev/928113e10414
Attachment #8499255 - Flags: review?(jaws) → review+
https://hg.mozilla.org/mozilla-central/rev/928113e10414
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
QA Contact: catalin.varga
The fix for this was included in the roll-up patch landed in bug 1044595.
status-firefox34: --- → fixed
status-firefox35: --- → fixed
Verified as fixed using:

FF34
Build Id: 20141009004002

FF 35
Build Id: 20141009030201

OS: Mac Os X 10.10
Status: RESOLVED → VERIFIED
status-firefox34: fixed → verified
status-firefox35: fixed → verified
You need to log in before you can comment on or make changes to this bug.