Closed
Bug 1076252
Opened 10 years ago
Closed 10 years ago
[10.10] disabled default buttons on Yosemite get white button text (e.g. download dialog "save file" button before it's enabled)
Categories
(Toolkit :: Themes, defect)
Tracking
()
People
(Reporter: Gijs, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
1.40 KB,
patch
|
Gijs
:
review+
jaws
:
review+
|
Details | Diff | Splinter Review |
The selector for this case needs tweaking to have :not([disabled=true]).
Assignee | ||
Updated•10 years ago
|
Flags: qe-verify+
Flags: in-testsuite-
Flags: firefox-backlog+
Assignee | ||
Comment 1•10 years ago
|
||
Taking this so we can uplift 1044595 for 34.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 35.3
Flags: needinfo?(mmucci)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8499186 -
Flags: review?(jaws)
Updated•10 years ago
|
Attachment #8499186 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 4•10 years ago
|
||
And then I realized the same goes for disabled normal buttons on :hover:active :-(
Attachment #8499255 -
Flags: review?(jaws)
Assignee | ||
Updated•10 years ago
|
Attachment #8499186 -
Attachment is obsolete: true
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8499255 [details] [diff] [review] [10.10] disabled default button shouldn't get white text on yosemite, Jared reviewed this over IRC. remote: https://hg.mozilla.org/integration/fx-team/rev/928113e10414
Attachment #8499255 -
Flags: review?(jaws) → review+
Updated•10 years ago
|
Attachment #8499255 -
Flags: review+
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/928113e10414
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•10 years ago
|
QA Contact: catalin.varga
Comment 7•10 years ago
|
||
The fix for this was included in the roll-up patch landed in bug 1044595.
status-firefox34:
--- → fixed
status-firefox35:
--- → fixed
Comment 8•10 years ago
|
||
Verified as fixed using: FF34 Build Id: 20141009004002 FF 35 Build Id: 20141009030201 OS: Mac Os X 10.10
You need to log in
before you can comment on or make changes to this bug.
Description
•