Closed Bug 1076351 Opened 5 years ago Closed 5 years ago

Initialize the search activity default engine pref with the user's default search engine

Categories

(Firefox for Android Graveyard :: Search Activity, defect, P1)

35 Branch
All
Android
defect

Tracking

(firefox35 verified, fennec35+)

VERIFIED FIXED
Firefox 35
Tracking Status
firefox35 --- verified
fennec 35+ ---

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file)

I'm splitting this off of bug 1065891, since the patch I wrote there to try to address this caused an autophone regression.

The main thing we want to do here is make sure when the user's browser is updated from a version that doesn't have the search activity to one that does (34 -> 35), the search activity default engine shared pref is set to the value of the user's default engine in Fennec (which they may have changed before the search activity logic was around to notice the change).
tracking-fennec: ? → 35+
This is a simpler patch that doesn't try to add various migration logic. I added a check to make sure we only do this migration when the app is upgraded, so this won't affect new profiles.

I also contemplated adding an observer to do this after the search service is initialized, but we're not guaranteed to start the search service while the app is running unless the user does something that requires it, and I would like to make sure this pref migration happens the first time Fennec is launched after updating.
Attachment #8499606 - Flags: review?(bnicholson)
Attachment #8499606 - Flags: review?(bnicholson) → review+
https://hg.mozilla.org/mozilla-central/rev/597b7da7f843
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Flagging this for QE verification. Does this have any test coverage?
Flags: qe-verify+
Flags: in-testsuite?
Verified as fixed on Firefox for Android 35 Beta 1 with Nexus 4 (Android 4.4.4).
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.