1076553 - [woodduck] Update Device properties to refresh device in Bluetooth Settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Update device properties to refresh device in Bluetooth Settings
Some of the devices alway shown Unkown device on DUT.
When device_found_cb callback doesn't get name，FXOS doesn't handle remote_device_properties_cb callback to update device name again.

Comment 1

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

This is not a trivial fix, and I think will fix for v2.0M first before 10/7.

Comment 2

[Josh Cheng [:josh]]

Hi Shawn,
Thanks for helping fixing this bug.
Should I mark status-b2g-v2.0, status-b2g-v2.1, status-b2g-v2.2 all to 'affected'?
BTW. Do you like to update the ETA date?

Comment 3

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Device property name was updated after inquiry results.

10-06 18:19:21.965 I/bt_gap_hdl.c( 1325): +++[GAP] btmtk_handle_gap_message msg:[MSG_ID_BT_BM_DISCOVERY_UPDATE_IND]+++!
10-06 18:19:21.965 I/bt_gap_api.c( 1325): [GAP] btmtk_inquired_dev_cache_find: addr=0x860ECE:0x3C:0x21
10-06 18:19:21.965 I/bt_gap_api.c( 1325): [GAP] btmtk_inquired_dev_cache_find found
10-06 18:19:21.965 I/bt_gap_hdl.c( 1325): [GAP] MSG_ID_BT_BM_DISCOVERY_UPDATE_IND addr: [0x860ECE:0x3C:0x21]
10-06 18:19:21.965 I/bt_gap_hdl.c( 1325): [GAP] btmtk_util_update_device_property_name: name = BIG JAMBOX by Jawbone
10-06 18:19:21.965 I/bt_gap_api.c( 1325): [GAP] btmtk_inquired_dev_cache_find: addr=0x860ECE:0x3C:0x21

Comment 5

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Currently Gaia does not have any chance to update device list after fetching ondevicefound callback. If we don't want to touch any part of API. The only way is to pass via system-message or pass again ondevicefound.

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Shawn Huang [:shawnjohnjr] from comment #3)
> Device property name was updated after inquiry results.
> 
> 10-06 18:19:21.965 I/bt_gap_hdl.c( 1325): +++[GAP] btmtk_handle_gap_message
> msg:[MSG_ID_BT_BM_DISCOVERY_UPDATE_IND]+++!
> 10-06 18:19:21.965 I/bt_gap_api.c( 1325): [GAP]
> btmtk_inquired_dev_cache_find: addr=0x860ECE:0x3C:0x21
> 10-06 18:19:21.965 I/bt_gap_api.c( 1325): [GAP]
> btmtk_inquired_dev_cache_find found
> 10-06 18:19:21.965 I/bt_gap_hdl.c( 1325): [GAP]
> MSG_ID_BT_BM_DISCOVERY_UPDATE_IND addr: [0x860ECE:0x3C:0x21]
> 10-06 18:19:21.965 I/bt_gap_hdl.c( 1325): [GAP]
> btmtk_util_update_device_property_name: name = BIG JAMBOX by Jawbone
> 10-06 18:19:21.965 I/bt_gap_api.c( 1325): [GAP]
> btmtk_inquired_dev_cache_find: addr=0x860ECE:0x3C:0x21

I guess this is something related to EIR information updated later, so we have to handle device update after ondevicefound.

I tested with my Big Jambox, I found bluetooth friendly name always get update later. But on bluedroid, I don't see this behavior, the name comes with ondevicefound. So I think this is different stack behavior on woodduck.

Comment 7

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Add blueangel tag for trakcing this different stack behavior.

Comment 8

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Currently the design of Bluetooth Setting, it won't refresh and update Bluetooth device list (after devicefound), however, on woodduck the stack behaves different, the device name will be updated later. Do you have any recommend preferable ways let gecko notify gaia to update name again?

Comment 9

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: bug1076553.patch

Comment 10

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: bug1076553.patch

Comment 11

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1076553 - Update Device properties to refresh device list for Settings

Comment 12

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I would like to switch to bluetooth2 new API for v2.2 (m-c). So I will open a new bug for m-c to handle this name update.

Comment 13

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

See also:
Bug 1081885 - [woodduck][bluetooth2] Update Device properties to refresh device in Bluetooth Settings

Comment 14

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8504002 [details] [diff] [review]
Bug 1076553 - Update Device properties to refresh device list for Settings

Review of attachment 8504002 [details] [diff] [review]:
-----------------------------------------------------------------

This is obviously a workaround for 2.0M only. Please do more tests to make sure that DeviceFound events won't be fired even when it's not discovering.

::: dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp
@@ +448,5 @@
>      MOZ_ASSERT(NS_IsMainThread());
>  
>      if (sRequestedDeviceCountArray.IsEmpty()) {
>        // This is possible because the callback would be called after turning
> +      // Bluetooth on, or simply remote device properties get updated.

nit: please also mention that this will be fixed on mainline after bug 1076553 getting fixed.

Comment 15

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

Attachment: Bug 1076553 - Update Device properties to refresh device list for Settings, r=echou

Comment 16

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I tested on woodduck for the following scenarios:
1. Turn on/off bluetooth
2. Check GetPairedDevices
3. Unpair devices

Except for discovery case, i don't see additional DeviceFound events were sent.

Comment 17

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

This only phased into v2.0m. Thanks.

Comment 18

[Kai-Zhen Li [:seinlin][:kli]]

http://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/1cb8603f401e