1076702 - [Stingray][Home] Implement card scrolling

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

This bug aims for auto scrolling when the card outside screen is the next navigating target.

We should enable the following:
- When navigating left/right to next card which is off the screen, shift the whole card list in opposite direction by 1 icon.
- If there are still next item in the list, the item should appear by half against the screen edge, indicating next item is available.

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

WIP:
https://github.com/rexboy7/gaia/commit/1b9a87300317de3d1e2c15660826a893995532ee

this patch depends on 1076700.

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

WIP 2:
https://github.com/rexboy7/gaia/tree/smartHome-addRemove

* add/remove items by program.
* navigable folder.
* each scrollable area memorizes its last selected item.

Not sure if we need to commit these together. (I prefer committing together since they are highly related features. But let's judge it based on patch complexity.)

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

Since bug 1076700 has already been r+'ed after Gaia tree is closed; 
I tried to rebase the patch onto bug 1076700. The commit of 1076700 would be ignored after it's merged into master and we only need to review the commit of 1076702.


Evelyn and Tzu-lin, may you help review this patch?

Comment 4

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8509313 [details] [review]
patch

Looks good to me overall. However I left some nit comment. I'll be glad if you addressed them.

Thanks!

Comment 5

[Evelyn Hung]

Comment on attachment 8509313 [details] [review]
patch

looks good to me.

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

master
https://github.com/mozilla-b2g/gaia/commit/99aa5f7e919fb1bf475306bd9da094e497deb936