Closed Bug 1076702 Opened 7 years ago Closed 7 years ago

[Stingray][Home] Implement card scrolling

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rexboy, Assigned: rexboy)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
dwi2
: review+
jj.evelyn
: review+
Details | Review
This bug aims for auto scrolling when the card outside screen is the next navigating target.

We should enable the following:
- When navigating left/right to next card which is off the screen, shift the whole card list in opposite direction by 1 icon.
- If there are still next item in the list, the item should appear by half against the screen edge, indicating next item is available.
Assignee: nobody → rexboy
Depends on: 1076700
WIP 2:
https://github.com/rexboy7/gaia/tree/smartHome-addRemove

* add/remove items by program.
* navigable folder.
* each scrollable area memorizes its last selected item.

Not sure if we need to commit these together. (I prefer committing together since they are highly related features. But let's judge it based on patch complexity.)
Attached file patch
Since bug 1076700 has already been r+'ed after Gaia tree is closed; 
I tried to rebase the patch onto bug 1076700. The commit of 1076700 would be ignored after it's merged into master and we only need to review the commit of 1076702.


Evelyn and Tzu-lin, may you help review this patch?
Attachment #8509313 - Flags: review?(tzhuang)
Attachment #8509313 - Flags: review?(ehung)
Comment on attachment 8509313 [details] [review]
patch

Looks good to me overall. However I left some nit comment. I'll be glad if you addressed them.

Thanks!
Attachment #8509313 - Flags: review?(tzhuang) → review+
Comment on attachment 8509313 [details] [review]
patch

looks good to me.
Attachment #8509313 - Flags: review?(ehung) → review+
Whiteboard: [ft:conndevices]
master
https://github.com/mozilla-b2g/gaia/commit/99aa5f7e919fb1bf475306bd9da094e497deb936
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.