1076706 - [Smart Screen][Home] Implement card listing and launching function

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

This bug implements the following:
- Initialize a card list come from picked decks and apps.
- Build backend storage for cards, orders, and considering if it's structure is suitable for folders that would be implemented later.
- Display these card onto UI.

Comment 1

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Considering using datastore as backend storage.

Comment 2

[Tzu-Lin Huang [:dwi2][:tzhuang]]

WIP is here https://github.com/dwi2/gaia/tree/bug1076706

It is based on https://github.com/rexboy7/gaia/tree/1076702-smartHome-scrollable-navigation

Comment 3

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Proposal process of loading card list when smart-home app launch:

1 - launch smart-home app 
2 - check if we have card entry list stored in datastore

2.1 - if not, smart-home app is first-time launch -> 3.1
2.2 - if yes, smart-home app is not first-time launch -> 3.2

3.1 - read init.json to get default card entry list -> 4
3.2 - read card entry list from datastore

4 - store card entry into datastore

Comment 4

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: pull request

Hi Rex, Evelyn,

Please help to review the patch.

This patch does only the storage of card list and are able to launch app. But user still cannot launch app from UI because there need more effort on integration of UI and app launching functionality. I'll file another bug to do that.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8510852 [details] [review]
pull request

It's almost OK for me but small changes needed.
See my comments on Github.

Comment 6

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8510852 [details] [review]
pull request

Hi Rex,

I've addressed your comments. Also I add unit tests for the case you mentioned in  https://github.com/dwi2/gaia/commit/308ce2c66e429e1d9b4beb89700b9a28a79cd8fe#commitcomment-8311209
to make sure they are all right.

Please help to review it again, thanks

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8510852 [details] [review]
pull request

Looks good to me.

Thanks for your work!

Comment 8

[Evelyn Hung]

Comment on attachment 8510852 [details] [review]
pull request

r+ with nits addressed. Thanks!

Comment 9

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Thanks,

All comments are addressed.
Waiting for Gaia-Try result
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=204b3a5c56cb

Comment 10

[Tzu-Lin Huang [:dwi2][:tzhuang]]

gaia try result should be this one https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=1eb0639018fd

Comment 11

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Gaia try seems ok. 
Landed on master: https://github.com/mozilla-b2g/gaia/commit/83b2877f6a61505646cb33871d42b8dc4643f573