Closed
Bug 1077193
Opened 11 years ago
Closed 11 years ago
taskcluster: Split linters into their own jobs
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlal, Assigned: jlal)
References
Details
Attachments
(1 file)
On taskcluster the linter takes around 5-10 min we can optimize this better by splitting up the tasks into csslint/hint/gjslint (or just css/js) which will speed up end-to-end times.. I suspect that the linters could be only utlizing a single core right now as well so there might be room for other optimizations
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → jlal
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8500178 -
Flags: review?(kgrandon)
|
|
Assignee | |
Comment 2•11 years ago
|
||
This also fixes 1077206 by the way of grouping linters together. See https://treeherder.allizom.org/ui/#/jobs?repo=gaia&revision=a31c97b48866beb9a28e9307a0dfc72b246f814b for how it looks.
Blocks: 1077206
|
|
Assignee | |
Comment 3•11 years ago
|
||
Note- this has a modest performance benefit (1-2~ min) bringing the linters down to the fastest jobs.
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8500178 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/24795
Looks sane to me!
Attachment #8500178 -
Flags: review?(kgrandon) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Comment 6•11 years ago
|
||
(In reply to James Lal [:lightsofapollo] from comment #0)
> I suspect that the linters could be only
> utlizing a single core right now as well so there might be room for other
> optimizations
Gjslint has a multiprocess option. We couldn't enable it for every platform but I don't remember why.
You need to log in
before you can comment on or make changes to this bug.
Description
•