1077206 - Weird display of GB and Li

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[Kevin Grandon :kgrandon]

It looks like: unknown(GB Li) 

Ideally these should just be GB and Li, but maybe GB(GB) Li(Li) could work if that's all we can do.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Screenshot of problem

Comment 2

[Jonas Finnemann Jensen (:jonasfj)]

This is how we report data to treeherder:
https://github.com/taskcluster/taskcluster-treeherder/blob/master/treeherder/handlers.js#L193-L448

@jeads,
Can you say a few words about the following properties, we're pretty much guessing at this point.
 - group_name
 - group_symbol
 - product_name
Must we provide all of these properties? (I don't think we mind, we just don't know what treeherder expects).

Also while I'm asking can you explain what the valid properties for "option_collection" is?
Can we set any property we want dynamically? Can values only be `true`?

Comment 3

[Ed Morley [:emorley]]

Examples of groups & symbols for buildbot jobs:
https://github.com/mozilla/treeherder-service/blob/master/tests/etl/test_buildbot.py#L332

Currently jobs that don't belong to a group are defined as:
'group_name': 'unknown',
'group_symbol': '?'

However I think this would be better as the empty string (I'd like to move buildbot jobs away from unknown/"?")

Comment 4

[Ed Morley [:emorley]]

(In reply to Ed Morley [:edmorley] from comment #3)
> However I think this would be better as the empty string (I'd like to move
> buildbot jobs away from unknown/"?")

Bug 1065137 is filed for this. For that bug (and also this one) we may need to fix handling in both the service and the UI, since iirc "?" etc is hardcoded (yey)

Comment 5

[James Lal [:lightsofapollo]]

Ed provided the information joans was looking for the "looking weird" part for GB is going to be fixed here https://bugzilla.mozilla.org/show_bug.cgi?id=1078019 and I will take this on to hack something so linters look okay

Comment 6

[James Lal [:lightsofapollo]]

fixed via https://github.com/mozilla-b2g/gaia/commit/e146b3bd8d63ce1c42104ce39bcba7abdfea95f0

Comment 7

[Ed Morley [:emorley]]

The symbols used are normally only a couple of characters long, and typically sentence case rather than all capitals.

If these are going to appear alongside the sheriffed jobs at some point, we may wish to coordinate with the group names used by the buildbot jobs, but for now doesn't matter :-)

Comment 8

[Pete Moore [:pmoore][:pete]]

Resetting Version and Target Milestone that accidentally got changed...