1077264 - Fragmented MP4 generated by mp4fragment utility do not play

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

This is related to bug 1076719, but the cause is different.

The mp4fragment utility from the Bento4/AP4 project http://bento4.sourceforge.net/docs/html/index.html generates fragment where each moof only contains a single streamID rather than muxed audio/video ones.

stagefright treats this as End Of Stream as now samples were found in the fragment

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Keep searching until one correct fragment is found

Keep looking for next fragments until samples are found.

Comment 2

[Jean-Yves Avenard [:jya]]

here is a sample to reproduce the problem:
http://people.mozilla.org/~jyavenard/mediatest/fragmented/bruce1s-fragmented-mp4frament.mp4

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Keep searching until one correct fragment is found

Simplify logic. Remove equivalent code.

Comment 4

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8499328 [details] [diff] [review]
Keep searching until one correct fragment is found

Review of attachment 8499328 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp
@@ +3575,5 @@
> +            do {
> +                mCurrentMoofOffset = nextMoof;
> +                status_t ret = parseChunk(&nextMoof);
> +                if (ret != OK) {
> +                    return ret;

Note that 'sidx' always returns UNKNOWN_ERROR and 'moov' sometimes does. We won't see a 'moov' here but this code will fail when it sees a 'sidx'.

Comment 5

[Jean-Yves Avenard [:jya]]

(In reply to Anthony Jones (:kentuckyfriedtakahe, :k17e) from comment #4)
> Comment on attachment 8499328 [details] [diff] [review]
> Keep searching until one correct fragment is found
> 
> Review of attachment 8499328 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> :::
> media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp
> @@ +3575,5 @@
> > +            do {
> > +                mCurrentMoofOffset = nextMoof;
> > +                status_t ret = parseChunk(&nextMoof);
> > +                if (ret != OK) {
> > +                    return ret;
> 
> Note that 'sidx' always returns UNKNOWN_ERROR and 'moov' sometimes does. We
> won't see a 'moov' here but this code will fail when it sees a 'sidx'.

Ok. Will handle sidx separately, back to the original patch

if moov is encountered here it should be an error anyway...

Comment 6

[Jean-Yves Avenard [:jya]]

Attachment: Keep searching until one correct fragment is found

treat sidx and styp separately (styp would be handled automatically, but doing that way here slightly reduce the overhead)

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70af7ba3c010

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/70af7ba3c010