1076719 - Fragmented MP4 playback stops too early

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

Here is a small example exhibiting the problem:
http://people.mozilla.org/~jyavenard/tests/mse_mp4/bruce.mp4

it is made of various fragmented mp4 concatenated together.

The MP4Reader will stop at the first fragment and set EOF.

In this video, the first fragment is 10s long while the complete video is 2 minutes long.

Video playback stops after 10s.

Video was created using the following command:
mp4box -dash 10000 -rap -segment-name bruce -subsegs-per-sidx 5 bruce_vs_ironman.mp4

Comment 1

[Jean-Yves Avenard [:jya]]

This one makes it easier to debug. It's made of 1s fragment rather than 10s.

Issue is the same as above, except that only 1s of video is played
http://people.mozilla.org/~jyavenard/mediatest/bruce1s-fragmented.mp4

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Skip styp box at beginning of new fragment

a new media segment may start with an optional segment type box (styp). If so, skip it

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Skip styp box at beginning of new fragment

Simplify comment

Comment 4

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Comment on attachment 8498790 [details] [diff] [review]
Skip styp box at beginning of new fragment

Review of attachment 8498790 [details] [diff] [review]:
-----------------------------------------------------------------

Fantastic!

Comment 5

[Jean-Yves Avenard [:jya]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=c6e0c0ef5e95

Comment 6

[Ryan VanderMeulen [:RyanVM]]

(In reply to Jean-Yves Avenard [:jya] from comment #5)
> https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=c6e0c0ef5e95

Windows bustage?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Also, please take a look at the link below for some useful recommendations for using Try. Might save you some mass-canceling and wasted infra resources :)
https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices

Comment 8

[Jean-Yves Avenard [:jya]]

The windows hostage was due to another stray commit which has nothing to do with this one. And unfortunately, I couldn't push to try most of yesterday. Kept getting locking error.

Comment 9

[Jean-Yves Avenard [:jya]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=a3e49136e0b1

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/314fd7709123

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/314fd7709123