1077299 - Incorrect way to use CreateMemoryFile() in ImageCapture

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[Alfredo Yang (:alfredo)]

Attachment: use_moz_alloc_to_create_blob

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8499402 [details] [diff] [review]
use_moz_alloc_to_create_blob

Review of attachment 8499402 [details] [diff] [review]:
-----------------------------------------------------------------

Please add a comment to File.h that CreateMemoryFile takes ownership of the buffer.

Comment 3

[Alfredo Yang (:alfredo)]

Attachment: b2g_imagecapture_test

Rebase.

https://tbpl.mozilla.org/?tree=Try&rev=5be38715812c

Comment 4

[Alfredo Yang (:alfredo)]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #2)
> Comment on attachment 8499402 [details] [diff] [review]
> use_moz_alloc_to_create_blob
> 
> Review of attachment 8499402 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please add a comment to File.h that CreateMemoryFile takes ownership of the
> buffer.

Bug 1082449.

Comment 5

[Carsten Book [:Tomcat]]

Hi Alfredo, the patch failed to apply:

patching file content/media/test/test_imagecapture.html
Hunk #1 FAILED at 32
Hunk #2 FAILED at 105
Hunk #3 FAILED at 131
3 out of 3 hunks FAILED -- saving rejects to file content/media/test/test_imagecapture.html.rej

could you take a look thanks!

Comment 6

[Alfredo Yang (:alfredo)]

Attachment: use_moz_alloc_to_create_blob

Sorry, wrong patch.

Comment 7

[Carsten Book [:Tomcat]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/7e2eeae6367b

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7e2eeae6367b