Closed
Bug 1077299
Opened 10 years ago
Closed 10 years ago
Incorrect way to use CreateMemoryFile() in ImageCapture
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: ayang, Assigned: ayang)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 2 obsolete files)
2.12 KB,
patch
|
ayang
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8499402 -
Flags: review?(roc)
Comment on attachment 8499402 [details] [diff] [review] use_moz_alloc_to_create_blob Review of attachment 8499402 [details] [diff] [review]: ----------------------------------------------------------------- Please add a comment to File.h that CreateMemoryFile takes ownership of the buffer.
Attachment #8499402 -
Flags: review?(roc) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Rebase. https://tbpl.mozilla.org/?tree=Try&rev=5be38715812c
Attachment #8499402 -
Attachment is obsolete: true
Attachment #8504542 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #2) > Comment on attachment 8499402 [details] [diff] [review] > use_moz_alloc_to_create_blob > > Review of attachment 8499402 [details] [diff] [review]: > ----------------------------------------------------------------- > > Please add a comment to File.h that CreateMemoryFile takes ownership of the > buffer. Bug 1082449.
Comment 5•10 years ago
|
||
Hi Alfredo, the patch failed to apply: patching file content/media/test/test_imagecapture.html Hunk #1 FAILED at 32 Hunk #2 FAILED at 105 Hunk #3 FAILED at 131 3 out of 3 hunks FAILED -- saving rejects to file content/media/test/test_imagecapture.html.rej could you take a look thanks!
Assignee | ||
Comment 6•10 years ago
|
||
Sorry, wrong patch.
Attachment #8504542 -
Attachment is obsolete: true
Attachment #8504550 -
Flags: review+
Comment 7•10 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/7e2eeae6367b
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7e2eeae6367b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•