Closed
Bug 1069222
Opened 10 years ago
Closed 10 years ago
[B2G] Add testcase for ImageCapture on gonk
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: ayang, Assigned: ayang)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 3 obsolete files)
2.51 KB,
patch
|
ayang
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8491370 -
Flags: review?(roc)
Comment on attachment 8491370 [details] [diff] [review] b2g_imagecapture_test Review of attachment 8491370 [details] [diff] [review]: ----------------------------------------------------------------- Can we extend this test to test taking multiple photos at the same time? ::: content/media/test/test_b2g_imagecapture.html @@ +28,5 @@ > + }; > + > + // Gonk camera hal emualtor has timing issue so it waits 5s before taking > + // picture. > + setTimeout(function() { imageCapture.takePhoto(); }, 5000); This isn't good. Can we fix this in Gecko instead by delaying the ImageCapture until the HAL is ready?
Attachment #8491370 -
Flags: review?(roc) → review-
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8491370 [details] [diff] [review] b2g_imagecapture_test Review of attachment 8491370 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/media/test/test_b2g_imagecapture.html @@ +28,5 @@ > + }; > + > + // Gonk camera hal emualtor has timing issue so it waits 5s before taking > + // picture. > + setTimeout(function() { imageCapture.takePhoto(); }, 5000); That should be bug 1021429. The ICS camera emulator HAL is defective. And it blocks other gonk camera test once the preview starts. I'm thinking it could be worth to write an CameraControl mimic in gecko for testing purpose.
Assignee | ||
Comment 4•10 years ago
|
||
Try result. https://tbpl.mozilla.org/?tree=Try&rev=5be38715812c
Attachment #8491370 -
Attachment is obsolete: true
Attachment #8499404 -
Flags: review?(roc)
Comment on attachment 8499404 [details] [diff] [review] b2g_imagecapture_test Review of attachment 8499404 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/media/test/test_imagecapture.html @@ +113,5 @@ > function init() { > return new Promise(function(resolve, reject) { > + var constraints; > + if (SpecialPowers.Services.appinfo.name == "B2G") { > + info("B2G ImagteCapture test"); ImageCapture
Attachment #8499404 -
Flags: review?(roc) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Update comment.
Attachment #8499404 -
Attachment is obsolete: true
Attachment #8504541 -
Flags: review+
Assignee | ||
Comment 7•10 years ago
|
||
Hi sheriff, please check-in with Bug 1077299. Thanks. https://tbpl.mozilla.org/?tree=Try&rev=5be38715812c
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Updated•10 years ago
|
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3193763d0a3b
Keywords: checkin-needed
Comment 9•10 years ago
|
||
backed out for test failures like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2982718&repo=mozilla-inbound
Assignee | ||
Comment 10•10 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b3768cff8f90
Attachment #8504541 -
Attachment is obsolete: true
Attachment #8505276 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 11•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec4e1f0988cd
Keywords: checkin-needed
Comment 12•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ec4e1f0988cd
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•