1069222 - [B2G] Add testcase for ImageCapture on gonk

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[Alfredo Yang (:alfredo)]

Attachment: b2g_imagecapture_test

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8491370 [details] [diff] [review]
b2g_imagecapture_test

Review of attachment 8491370 [details] [diff] [review]:
-----------------------------------------------------------------

Can we extend this test to test taking multiple photos at the same time?

::: content/media/test/test_b2g_imagecapture.html
@@ +28,5 @@
> +    };
> +
> +    // Gonk camera hal emualtor has timing issue so it waits 5s before taking
> +    // picture.
> +    setTimeout(function() { imageCapture.takePhoto(); }, 5000);

This isn't good. Can we fix this in Gecko instead by delaying the ImageCapture until the HAL is ready?

Comment 3

[Alfredo Yang (:alfredo)]

Comment on attachment 8491370 [details] [diff] [review]
b2g_imagecapture_test

Review of attachment 8491370 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/test/test_b2g_imagecapture.html
@@ +28,5 @@
> +    };
> +
> +    // Gonk camera hal emualtor has timing issue so it waits 5s before taking
> +    // picture.
> +    setTimeout(function() { imageCapture.takePhoto(); }, 5000);

That should be bug 1021429. The ICS camera emulator HAL is defective.
And it blocks other gonk camera test once the preview starts.

I'm thinking it could be worth to write an CameraControl mimic in gecko for testing purpose.

Comment 4

[Alfredo Yang (:alfredo)]

Attachment: b2g_imagecapture_test

Try result.
https://tbpl.mozilla.org/?tree=Try&rev=5be38715812c

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8499404 [details] [diff] [review]
b2g_imagecapture_test

Review of attachment 8499404 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/test/test_imagecapture.html
@@ +113,5 @@
>  function init() {
>    return new Promise(function(resolve, reject) {
> +    var constraints;
> +    if (SpecialPowers.Services.appinfo.name == "B2G") {
> +      info("B2G ImagteCapture test");

ImageCapture

Comment 6

[Alfredo Yang (:alfredo)]

Attachment: b2g_imagecapture_test

Update comment.

Comment 7

[Alfredo Yang (:alfredo)]

Hi sheriff, please check-in with Bug 1077299. Thanks.


https://tbpl.mozilla.org/?tree=Try&rev=5be38715812c

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3193763d0a3b

Comment 9

[Carsten Book [:Tomcat]]

backed out for test failures like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2982718&repo=mozilla-inbound

Comment 10

[Alfredo Yang (:alfredo)]

Attachment: b2g_imagecapture_test

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b3768cff8f90

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec4e1f0988cd

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ec4e1f0988cd