Closed
Bug 1077369
Opened 10 years ago
Closed 10 years ago
Unified Autocomplete: Strange border between globe icon and search term
Categories
(Firefox :: Address Bar, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox35 | --- | verified |
People
(Reporter: mehmet.sahin, Assigned: ttaubert)
References
Details
Attachments
(4 files, 1 obsolete file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:35.0) Gecko/20100101 Firefox/35.0 Build ID: 20141002093155 Steps to reproduce: 1. Use latest Nightly 35.0a1 (2014-10-02) 2. type something into Location Bar 3. Arrow down to the search engine suggestion Actual results: There is a strange separator between the globe icon and search term. Expected results: To see no separator. The (search-)text in the Location Bar should be aligned with the text in the result list pop up. If you want to highlight the search term, maybe you can replace in the case of a search term the globe icon with a magnifying glass.
Updated•10 years ago
|
Status: UNCONFIRMED → NEW
Component: Untriaged → Location Bar
Ever confirmed: true
Flags: firefox-backlog+
Comment 4•10 years ago
|
||
Yes, I saw it too. I think we are hiding some box with css and that border is a leftover.
Blocks: UnifiedComplete
Comment 5•10 years ago
|
||
I think this border is visible when the action is the fallback (search through current search engine) and you select the only entry in the popup.
Updated•10 years ago
|
Flags: qe-verify?
Updated•10 years ago
|
Points: --- → 2
Flags: qe-verify? → qe-verify+
Assignee | ||
Comment 6•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Iteration: --- → 35.3
Comment 7•10 years ago
|
||
Comment on attachment 8501430 [details] [diff] [review] 0001-Bug-1077369-Remove-border-between-search-term-and-gl.patch > #urlbar:not([actiontype]) > #urlbar-display-box, >+#urlbar[actiontype="searchengine"] > #urlbar-display-box, > #urlbar:not([actiontype="switchtab"]) > #urlbar-display-box > .urlbar-display-switchtab { > display: none; > } I believe at this point this should just be: #urlbar:not([actiontype="switchtab"]) > #urlbar-display-box { display: none; }
Attachment #8501430 -
Flags: review?(mak77) → review-
Updated•10 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Comment 8•10 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #7) > #urlbar:not([actiontype="switchtab"]) > #urlbar-display-box { > display: none; > } makes sense, switchtab is the only action showing anything in the display-box so far. When we'll introduce more labels, then we can fix this code to take them into account.
Assignee | ||
Comment 9•10 years ago
|
||
Attachment #8501430 -
Attachment is obsolete: true
Attachment #8501663 -
Flags: review?(mak77)
Attachment #8501663 -
Flags: review?(dao)
Updated•10 years ago
|
Attachment #8501663 -
Flags: review?(dao) → review+
Assignee | ||
Comment 10•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/4d0bb69c5a49
Comment 11•10 years ago
|
||
Comment on attachment 8501663 [details] [diff] [review] 0001-Bug-1077369-Remove-border-between-search-term-and-gl.patch, v2 no need for further reviews
Attachment #8501663 -
Flags: review?(mak77)
https://hg.mozilla.org/mozilla-central/rev/4d0bb69c5a49
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Updated•10 years ago
|
QA Contact: andrei.vaida
Comment 13•10 years ago
|
||
Verified fixed on Nightly 35.0a1 (2014-10-09) using Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 LTS 32-bit.
Status: RESOLVED → VERIFIED
status-firefox35:
--- → verified
You need to log in
before you can comment on or make changes to this bug.
Description
•