Unified Autocomplete: Strange border between globe icon and search term

VERIFIED FIXED in Firefox 35

Status

()

Firefox
Location Bar
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Mehmet, Assigned: ttaubert)

Tracking

35 Branch
Firefox 35
Points:
2
Bug Flags:
firefox-backlog +
qe-verify +

Firefox Tracking Flags

(firefox35 verified)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20141002093155

Steps to reproduce:

1. Use latest Nightly 35.0a1 (2014-10-02)
2. type something into Location Bar
3. Arrow down to the search engine suggestion



Actual results:

There is a strange separator between the globe icon and search term.


Expected results:

To see no separator. The (search-)text in the Location Bar should be aligned with the text in the result list pop up.

If you want to highlight the search term, maybe you can replace in the case of a search term the globe icon with a magnifying glass.
(Reporter)

Comment 1

3 years ago
Created attachment 8499501 [details]
separator_1.png
(Reporter)

Comment 2

3 years ago
Created attachment 8499502 [details]
separator_2.png
(Reporter)

Comment 3

3 years ago
Created attachment 8499504 [details]
suggestion.png

Updated

3 years ago
Status: UNCONFIRMED → NEW
Component: Untriaged → Location Bar
Ever confirmed: true
Flags: firefox-backlog+
Yes, I saw it too. I think we are hiding some box with css and that border is a leftover.
Blocks: 995091
I think this border is visible when the action is the fallback (search through current search engine) and you select the only entry in the popup.

Updated

3 years ago
Flags: qe-verify?
Points: --- → 2
Flags: qe-verify? → qe-verify+
Created attachment 8501430 [details] [diff] [review]
0001-Bug-1077369-Remove-border-between-search-term-and-gl.patch
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #8501430 - Flags: review?(mak77)
Iteration: --- → 35.3
Comment on attachment 8501430 [details] [diff] [review]
0001-Bug-1077369-Remove-border-between-search-term-and-gl.patch

> #urlbar:not([actiontype]) > #urlbar-display-box,
>+#urlbar[actiontype="searchengine"] > #urlbar-display-box,
> #urlbar:not([actiontype="switchtab"]) > #urlbar-display-box > .urlbar-display-switchtab {
>   display: none;
> }

I believe at this point this should just be:

#urlbar:not([actiontype="switchtab"]) > #urlbar-display-box {
  display: none;
}
Attachment #8501430 - Flags: review?(mak77) → review-

Updated

3 years ago
OS: Mac OS X → All
Hardware: x86 → All
(In reply to Dão Gottwald [:dao] from comment #7)
> #urlbar:not([actiontype="switchtab"]) > #urlbar-display-box {
>   display: none;
> }

makes sense, switchtab is the only action showing anything in the display-box so far. When we'll introduce more labels, then we can fix this code to take them into account.
Created attachment 8501663 [details] [diff] [review]
0001-Bug-1077369-Remove-border-between-search-term-and-gl.patch, v2
Attachment #8501430 - Attachment is obsolete: true
Attachment #8501663 - Flags: review?(mak77)
Attachment #8501663 - Flags: review?(dao)

Updated

3 years ago
Attachment #8501663 - Flags: review?(dao) → review+
https://hg.mozilla.org/integration/fx-team/rev/4d0bb69c5a49
Comment on attachment 8501663 [details] [diff] [review]
0001-Bug-1077369-Remove-border-between-search-term-and-gl.patch, v2

no need for further reviews
Attachment #8501663 - Flags: review?(mak77)
https://hg.mozilla.org/mozilla-central/rev/4d0bb69c5a49
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
QA Contact: andrei.vaida
Verified fixed on Nightly 35.0a1 (2014-10-09) using Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 14.04 LTS 32-bit.
Status: RESOLVED → VERIFIED
status-firefox35: --- → verified
You need to log in before you can comment on or make changes to this bug.