Closed
Bug 1077376
Opened 10 years ago
Closed 10 years ago
Stylus files show up blank in the style editor
Categories
(DevTools :: Style Editor, defect)
DevTools
Style Editor
Tracking
(firefox32 wontfix, firefox33 wontfix, firefox34 fixed, firefox35 fixed, firefox-esr31 wontfix)
RESOLVED
FIXED
Firefox 35
People
(Reporter: harth, Assigned: harth)
References
Details
Attachments
(1 file, 1 obsolete file)
10.66 KB,
patch
|
pbro
:
review+
lmandel
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
STR:
1) Enable "Show original sources" in the Style Editor
2) Open a page using a Stylus source
3) Open Style Editor
The stylus source in the editor is blank, where it should contain the text of the file.
Assignee | ||
Comment 1•10 years ago
|
||
We're trying to prettify Stylus sources which don't use CSS-like syntax. This patch fixes that and also adds a test and fixes another one.
Assignee: nobody → fayearthur
Attachment #8499509 -
Flags: review?(pbrosset)
Assignee | ||
Comment 2•10 years ago
|
||
Whoops, had to remove a couple commented-out lines.
Attachment #8499509 -
Attachment is obsolete: true
Attachment #8499509 -
Flags: review?(pbrosset)
Attachment #8499514 -
Flags: review?(pbrosset)
Comment 3•10 years ago
|
||
Comment on attachment 8499514 [details] [diff] [review]
Don't prettify original sources in the style editor
Review of attachment 8499514 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8499514 -
Flags: review?(pbrosset) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 6•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Assignee | ||
Comment 7•10 years ago
|
||
Comment on attachment 8499514 [details] [diff] [review]
Don't prettify original sources in the style editor
Approval Request Comment
[Feature/regressing bug #]:
bug 926014
[User impact if declined]:
Users of the Stylus CSS pre-processing language will see blank files in the Style Editor, rendering the tool useless for editing their sources.
[Describe test coverage new/current, TBPL]:
Has test, in mozilla-central for a couple days.
[Risks and why]:
None known
[String/UUID change made/needed]:
None
Attachment #8499514 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
status-firefox32:
--- → wontfix
status-firefox33:
--- → wontfix
status-firefox34:
--- → affected
status-firefox35:
--- → fixed
status-firefox-esr31:
--- → wontfix
Comment 8•10 years ago
|
||
Comment on attachment 8499514 [details] [diff] [review]
Don't prettify original sources in the style editor
This is pretty old dating back to Firefox 29. How come we didn't hear about this sooner?
Aurora+
Attachment #8499514 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 9•10 years ago
|
||
(In reply to Lawrence Mandel [:lmandel] from comment #8)
> This is pretty old dating back to Firefox 29. How come we didn't hear about
> this sooner?
>
> Aurora+
Thanks! The reason is that Stylus didn't generate source maps until a month ago. I was contacted on twitter shortly afterwards.
Comment 10•10 years ago
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•