Closed
Bug 1077412
Opened 10 years ago
Closed 10 years ago
Add a confirmation dialog when deleting contacts in the Desktop client
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox34 verified, firefox35 verified)
People
(Reporter: Paolo, Assigned: Paolo)
References
Details
(Whiteboard: [contacts, first release needed][loop-uplift])
Attachments
(1 file, 1 obsolete file)
4.56 KB,
patch
|
jesup
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Follow-up from bug 1038257 comment 22.
Flags: qe-verify+
Flags: firefox-backlog+
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8501048 -
Flags: review?(mdeboer)
Comment 2•10 years ago
|
||
Paolo -- can we uplift this to Fx 34 or does it a string change? I thought we couldn't uplift it because we didn't have the string landed prior to the Fx34 string freeze.
Flags: needinfo?(paolo.mozmail)
Comment 3•10 years ago
|
||
Comment on attachment 8501048 [details] [diff] [review] The patch Review of attachment 8501048 [details] [diff] [review]: ----------------------------------------------------------------- r=me with comment addressed. Thanks! ::: browser/components/loop/MozLoopAPI.jsm @@ +298,5 @@ > + null, null, {}); > + > + callback(null, chosenButton == 0); > + } catch (ex) { > + callback(ex); this won't work, you need to do `cloneErrorObject(ex, targetWindow)`
Attachment #8501048 -
Flags: review?(mdeboer) → review+
Comment 4•10 years ago
|
||
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #2) > Paolo -- can we uplift this to Fx 34 or does it a string change? I thought > we couldn't uplift it because we didn't have the string landed prior to the > Fx34 string freeze. The strings were already uplifted for this change. The patch doesn't contain new strings.
Flags: needinfo?(paolo.mozmail)
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8501048 -
Attachment is obsolete: true
Assignee | ||
Comment 6•10 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=adc3f0ad0cdb
Keywords: checkin-needed
Assignee | ||
Updated•10 years ago
|
Whiteboard: [contacts, first release needed][loop-uplift] → [contacts, first release needed][loop-uplift][checkin-needed to fx-team]
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/fda842d4d372
Keywords: checkin-needed
Whiteboard: [contacts, first release needed][loop-uplift][checkin-needed to fx-team] → [contacts, first release needed][loop-uplift]
https://hg.mozilla.org/mozilla-central/rev/fda842d4d372
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Comment 9•10 years ago
|
||
Verified fixed FF 35.0a1 (2014-10-08) Win 7, Ubuntu 13.04, OS X 10.9.5. Perhaps it would have been better not to close the Loop panel when showing the confirmation dialog.
Status: RESOLVED → VERIFIED
status-firefox35:
--- → verified
Comment 10•10 years ago
|
||
Comment on attachment 8501154 [details] [diff] [review] Updated patch Approval Request Comment Part of the staged Loop aurora second uplift set
Attachment #8501154 -
Flags: review+
Attachment #8501154 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
status-firefox34:
--- → fixed
Flags: needinfo?(paul.silaghi)
Comment 13•10 years ago
|
||
Comment on attachment 8501154 [details] [diff] [review] Updated patch Already landed in aurora, approving for posterity
Attachment #8501154 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•