Add a confirmation dialog when deleting contacts in the Desktop client

VERIFIED FIXED in Firefox 34

Status

Hello (Loop)
Client
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Paolo, Assigned: Paolo)

Tracking

unspecified
mozilla35
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify +

Firefox Tracking Flags

(firefox34 verified, firefox35 verified)

Details

(Whiteboard: [contacts, first release needed][loop-uplift])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Follow-up from bug 1038257 comment 22.
Flags: qe-verify+
Flags: firefox-backlog+
(Assignee)

Comment 1

3 years ago
Created attachment 8501048 [details] [diff] [review]
The patch
Attachment #8501048 - Flags: review?(mdeboer)
Paolo -- can we uplift this to Fx 34 or does it a string change?  I thought we couldn't uplift it because we didn't have the string landed prior to the Fx34 string freeze.
Flags: needinfo?(paolo.mozmail)
Comment on attachment 8501048 [details] [diff] [review]
The patch

Review of attachment 8501048 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed.

Thanks!

::: browser/components/loop/MozLoopAPI.jsm
@@ +298,5 @@
> +            null, null, {});
> +
> +          callback(null, chosenButton == 0);
> +        } catch (ex) {
> +          callback(ex);

this won't work, you need to do `cloneErrorObject(ex, targetWindow)`
Attachment #8501048 - Flags: review?(mdeboer) → review+
(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #2)
> Paolo -- can we uplift this to Fx 34 or does it a string change?  I thought
> we couldn't uplift it because we didn't have the string landed prior to the
> Fx34 string freeze.

The strings were already uplifted for this change. The patch doesn't contain new strings.
Flags: needinfo?(paolo.mozmail)
(Assignee)

Comment 5

3 years ago
Created attachment 8501154 [details] [diff] [review]
Updated patch
Attachment #8501048 - Attachment is obsolete: true
(Assignee)

Comment 6

3 years ago
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=adc3f0ad0cdb
Keywords: checkin-needed
(Assignee)

Updated

3 years ago
Whiteboard: [contacts, first release needed][loop-uplift] → [contacts, first release needed][loop-uplift][checkin-needed to fx-team]
(Assignee)

Updated

3 years ago
Blocks: 1075203
https://hg.mozilla.org/integration/fx-team/rev/fda842d4d372
Keywords: checkin-needed
Whiteboard: [contacts, first release needed][loop-uplift][checkin-needed to fx-team] → [contacts, first release needed][loop-uplift]
https://hg.mozilla.org/mozilla-central/rev/fda842d4d372
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Verified fixed FF 35.0a1 (2014-10-08) Win 7, Ubuntu 13.04, OS X 10.9.5.
Perhaps it would have been better not to close the Loop panel when showing the confirmation dialog.
Status: RESOLVED → VERIFIED
status-firefox35: --- → verified
Comment on attachment 8501154 [details] [diff] [review]
Updated patch

Approval Request Comment
Part of the staged Loop aurora second uplift set
Attachment #8501154 - Flags: review+
Attachment #8501154 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/releases/mozilla-aurora/rev/35681e1a2d65

Updated

3 years ago
status-firefox34: --- → fixed
Flags: needinfo?(paul.silaghi)
Verified fixed FF 34b1 Win 7
status-firefox34: fixed → verified
Flags: needinfo?(paul.silaghi)
Comment on attachment 8501154 [details] [diff] [review]
Updated patch

Already landed in aurora, approving for posterity
Attachment #8501154 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.