1077412 - Add a confirmation dialog when deleting contacts in the Desktop client

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[:Paolo Amadini]

Follow-up from bug 1038257 comment 22.

Comment 1

[:Paolo Amadini]

Attachment: The patch

Comment 2

[Maire Reavy [:mreavy]]

Paolo -- can we uplift this to Fx 34 or does it a string change?  I thought we couldn't uplift it because we didn't have the string landed prior to the Fx34 string freeze.

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8501048 [details] [diff] [review]
The patch

Review of attachment 8501048 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed.

Thanks!

::: browser/components/loop/MozLoopAPI.jsm
@@ +298,5 @@
> +            null, null, {});
> +
> +          callback(null, chosenButton == 0);
> +        } catch (ex) {
> +          callback(ex);

this won't work, you need to do `cloneErrorObject(ex, targetWindow)`

Comment 4

[Mike de Boer [:mikedeboer]]

(In reply to Maire Reavy [:mreavy] (Plz needinfo me) from comment #2)
> Paolo -- can we uplift this to Fx 34 or does it a string change?  I thought
> we couldn't uplift it because we didn't have the string landed prior to the
> Fx34 string freeze.

The strings were already uplifted for this change. The patch doesn't contain new strings.

Comment 5

[:Paolo Amadini]

Attachment: Updated patch

Comment 6

[:Paolo Amadini]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=adc3f0ad0cdb

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/fx-team/rev/fda842d4d372

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fda842d4d372

Comment 9

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 35.0a1 (2014-10-08) Win 7, Ubuntu 13.04, OS X 10.9.5.
Perhaps it would have been better not to close the Loop panel when showing the confirmation dialog.

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8501154 [details] [diff] [review]
Updated patch

Approval Request Comment
Part of the staged Loop aurora second uplift set

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/35681e1a2d65

Comment 12

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 34b1 Win 7

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8501154 [details] [diff] [review]
Updated patch

Already landed in aurora, approving for posterity