Closed Bug 1075203 Opened 10 years ago Closed 10 years ago

[UX] Review of Loops Contacts

Categories

(Firefox :: General, defect)

defect
Not set
normal
Points:
5

Tracking

()

RESOLVED FIXED
Iteration:
36.1

People

(Reporter: shell, Assigned: phlsa)

References

()

Details

(Whiteboard: [ux])

Attachments

(1 file, 2 obsolete files)

per Philipps comment https://bugzilla.mozilla.org/show_bug.cgi?id=1065441#c3 that a new bug should be created for the Contacts UX review.

Paolo:Hey Philipp, any chance you could look at the Contacts UI that just landed in fx-team? (It's not in mozilla-central yet.) There are probably adjustments to do there as well.

For now the video call button does nothing, and audio/video call context menu items are not active, but the rest should work as expected.
Points: --- → 5
Flags: firefox-backlog+
HOLD the review until https://bugzilla.mozilla.org/show_bug.cgi?id=1078309 has landed.  Shell will update the bug and ping UX to let know it's ready.
Depends on: 1078309
Flags: needinfo?(sescalante)
Flags: qe-verify-
Whiteboard: [ux]
Updating dependency as discussed, since the alert in bug 1077412 is the only missing UX design piece there, while partitioning the contacts is only relevant when using multiple accounts, which is a bug to be aware about, but with no visual impact.
Depends on: 1077412
No longer depends on: 1078309
Flags: needinfo?(sescalante)
Shell, this is now unblocked.
Flags: needinfo?(sescalante)
https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#contacts is an interactive site.  import, add, and to the right of the name all show actions.
Flags: needinfo?(sescalante)
Madhava has this on the UX backlog now.
Paolo, I'm ready to start reviewing now. Is the current Nightly a good basis for doing the review? If not, it would be great if you could point me to a build that is.

Thanks!
Flags: needinfo?(paolo.mozmail)
Status: NEW → ASSIGNED
Iteration: --- → 36.1
(In reply to Philipp Sackl [:phlsa] from comment #6)
> Paolo, I'm ready to start reviewing now. Is the current Nightly a good basis
> for doing the review? If not, it would be great if you could point me to a
> build that is.

I think the current Nightly is fine. Thanks!
Flags: needinfo?(paolo.mozmail)
Attached image loop review contacts.png (obsolete) —
Here's my initial review.
Darrin, it would be great if you could have a look at this. There are a few questions around design decisions in there as well.
Attachment #8506207 - Flags: review?(dhenein)
Comment on attachment 8506207 [details]
loop review contacts.png

These look like the major papercuts to me. Along with these changes, suggesting:

- change 'Import' to 'Google Import'
- add 'No contacts.' when list is empty

Philipp, how should we resource any design work needed as a result (mockup for the contacts empty state, darker icons, etc)?
Flags: needinfo?(philipp)
Attachment #8506207 - Flags: review?(dhenein) → review+
(In reply to Darrin Henein [:darrin] from comment #9)
> - change 'Import' to 'Google Import'

We should use "Import from Google" as 'Google Import' sounds like a product that Google offers

This as well may have some trademark questions since I know they prefer Chrome extensions to use "for Google", "for Chrome", "for YouTube", etc with allowed names for extensions in their store (for example, "YouTube Awesome Player" would get rejected but "Awesome Player for YouTube" wouldn't).
Attached image loop-contacts-review (obsolete) —
Updated the sheet with new information.

As for resourcing, I'll go ahead and file bugs for all the things we caught here (unless you tell me that those bugs already exist :)
For the trivial ones, I can just include a mockup (e.g. the contacts empty state). Let's see how much work is left after that and funnel it through the backlog process.
Attachment #8506207 - Attachment is obsolete: true
Flags: needinfo?(philipp)
Attachment #8509373 - Flags: review+
Attached image loop-contacts-review
Added numbers to the issues to make them easier to reference
Attachment #8509373 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Philipp, did you already file the bugs for the issues found? It would be nice if they are marked as blocking this bug.
Flags: needinfo?(philipp)
I did not, since I don't know what is already on file.
What I did do is collect and prioritize the changes in this spreadsheet: https://docs.google.com/a/mozilla.com/spreadsheets/d/1wPKyCxqleZZ6xHcgraH1QFECs5u13gWhE0vQoUh_HwM/edit#gid=0

By Darrins suggestion, I asked Shell to do the bug filing since she has a much better overview of Loop bugs.
Flags: needinfo?(philipp)
Awesome, thanks! Shell, can you make sure that the new bugs are filed and marked as blocking this bug?
Flags: needinfo?(sescalante)
Thanks Philipp!!  I'll file bugs today and put as blocking bug 1075203, per Jared's request.
Flags: needinfo?(sescalante)
Blocks: 1050307
Depends on: 1083282
Depends on: 1091173
Depends on: 1091178
Depends on: 1091184
Depends on: 1084255
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: