Closed
Bug 1075203
Opened 10 years ago
Closed 10 years ago
[UX] Review of Loops Contacts
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Iteration:
36.1
People
(Reporter: shell, Assigned: phlsa)
References
()
Details
(Whiteboard: [ux])
Attachments
(1 file, 2 obsolete files)
428.68 KB,
image/png
|
Details |
per Philipps comment https://bugzilla.mozilla.org/show_bug.cgi?id=1065441#c3 that a new bug should be created for the Contacts UX review.
Paolo:Hey Philipp, any chance you could look at the Contacts UI that just landed in fx-team? (It's not in mozilla-central yet.) There are probably adjustments to do there as well.
For now the video call button does nothing, and audio/video call context menu items are not active, but the rest should work as expected.
Assignee | ||
Updated•10 years ago
|
Points: --- → 5
Flags: firefox-backlog+
Reporter | ||
Comment 1•10 years ago
|
||
HOLD the review until https://bugzilla.mozilla.org/show_bug.cgi?id=1078309 has landed. Shell will update the bug and ping UX to let know it's ready.
Depends on: 1078309
Flags: needinfo?(sescalante)
Updated•10 years ago
|
Flags: qe-verify-
Whiteboard: [ux]
Comment 2•10 years ago
|
||
Updating dependency as discussed, since the alert in bug 1077412 is the only missing UX design piece there, while partitioning the contacts is only relevant when using multiple accounts, which is a bug to be aware about, but with no visual impact.
Updated•10 years ago
|
Flags: needinfo?(sescalante)
Reporter | ||
Comment 4•10 years ago
|
||
https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#contacts is an interactive site. import, add, and to the right of the name all show actions.
Flags: needinfo?(sescalante)
Reporter | ||
Comment 5•10 years ago
|
||
Madhava has this on the UX backlog now.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → philipp
Assignee | ||
Comment 6•10 years ago
|
||
Paolo, I'm ready to start reviewing now. Is the current Nightly a good basis for doing the review? If not, it would be great if you could point me to a build that is.
Thanks!
Flags: needinfo?(paolo.mozmail)
Updated•10 years ago
|
Status: NEW → ASSIGNED
Iteration: --- → 36.1
Comment 7•10 years ago
|
||
(In reply to Philipp Sackl [:phlsa] from comment #6)
> Paolo, I'm ready to start reviewing now. Is the current Nightly a good basis
> for doing the review? If not, it would be great if you could point me to a
> build that is.
I think the current Nightly is fine. Thanks!
Flags: needinfo?(paolo.mozmail)
Assignee | ||
Comment 8•10 years ago
|
||
Here's my initial review.
Darrin, it would be great if you could have a look at this. There are a few questions around design decisions in there as well.
Attachment #8506207 -
Flags: review?(dhenein)
Comment 9•10 years ago
|
||
Comment on attachment 8506207 [details]
loop review contacts.png
These look like the major papercuts to me. Along with these changes, suggesting:
- change 'Import' to 'Google Import'
- add 'No contacts.' when list is empty
Philipp, how should we resource any design work needed as a result (mockup for the contacts empty state, darker icons, etc)?
Flags: needinfo?(philipp)
Attachment #8506207 -
Flags: review?(dhenein) → review+
Comment 10•10 years ago
|
||
(In reply to Darrin Henein [:darrin] from comment #9)
> - change 'Import' to 'Google Import'
We should use "Import from Google" as 'Google Import' sounds like a product that Google offers
This as well may have some trademark questions since I know they prefer Chrome extensions to use "for Google", "for Chrome", "for YouTube", etc with allowed names for extensions in their store (for example, "YouTube Awesome Player" would get rejected but "Awesome Player for YouTube" wouldn't).
Assignee | ||
Comment 11•10 years ago
|
||
Updated the sheet with new information.
As for resourcing, I'll go ahead and file bugs for all the things we caught here (unless you tell me that those bugs already exist :)
For the trivial ones, I can just include a mockup (e.g. the contacts empty state). Let's see how much work is left after that and funnel it through the backlog process.
Attachment #8506207 -
Attachment is obsolete: true
Flags: needinfo?(philipp)
Attachment #8509373 -
Flags: review+
Assignee | ||
Comment 12•10 years ago
|
||
Added numbers to the issues to make them easier to reference
Attachment #8509373 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 13•10 years ago
|
||
Philipp, did you already file the bugs for the issues found? It would be nice if they are marked as blocking this bug.
Flags: needinfo?(philipp)
Assignee | ||
Comment 14•10 years ago
|
||
I did not, since I don't know what is already on file.
What I did do is collect and prioritize the changes in this spreadsheet: https://docs.google.com/a/mozilla.com/spreadsheets/d/1wPKyCxqleZZ6xHcgraH1QFECs5u13gWhE0vQoUh_HwM/edit#gid=0
By Darrins suggestion, I asked Shell to do the bug filing since she has a much better overview of Loop bugs.
Flags: needinfo?(philipp)
Comment 15•10 years ago
|
||
Awesome, thanks! Shell, can you make sure that the new bugs are filed and marked as blocking this bug?
Flags: needinfo?(sescalante)
Reporter | ||
Comment 16•10 years ago
|
||
Thanks Philipp!! I'll file bugs today and put as blocking bug 1075203, per Jared's request.
Flags: needinfo?(sescalante)
You need to log in
before you can comment on or make changes to this bug.
Description
•