Closed
Bug 1077454
Opened 11 years ago
Closed 10 years ago
Handle import/export in new performance tool
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 37
People
(Reporter: jsantell, Assigned: vporof)
References
Details
Attachments
(1 file)
43.43 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•11 years ago
|
Assignee | ||
Comment 1•11 years ago
|
||
Let's handle the multiple recordings bit in a new bug, to give us some time to figure out the UI.
Summary: Handle multiple recordings, import/export in new performance tool → Handle import/export in new performance tool
Assignee | ||
Comment 2•11 years ago
|
||
(In reply to Victor Porof [:vporof][:vp] from comment #1)
> Let's handle the multiple recordings bit in a new bug, to give us some time
> to figure out the UI.
Bug 1111004.
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #8538081 -
Flags: review?(jsantell)
Reporter | ||
Comment 4•11 years ago
|
||
Comment on attachment 8538081 [details] [diff] [review]
v1
Review of attachment 8538081 [details] [diff] [review]:
-----------------------------------------------------------------
Just gave this a go, works great!
::: browser/devtools/performance/performance-view.js
@@ +85,5 @@
> + /**
> + * Handler for clicking the import button.
> + */
> + _onImportButtonClick: function(e) {
> + let fp = Cc["@mozilla.org/filepicker;1"].createInstance(Ci.nsIFilePicker);
Maybe the import and export windows should also be in a module?
Reporter | ||
Updated•11 years ago
|
Attachment #8538081 -
Flags: review?(jsantell) → review+
Reporter | ||
Comment 5•11 years ago
|
||
Another nit, the tests should probably be called "perf" like the other tests, rather than "profiler"
Assignee | ||
Comment 6•10 years ago
|
||
Addressed nits and landed: https://hg.mozilla.org/integration/fx-team/rev/4f32657399b6
Whiteboard: [fixed-in-fx-team]
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•