Closed Bug 1077454 Opened 6 years ago Closed 6 years ago

Handle import/export in new performance tool

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 37

People

(Reporter: jsantell, Assigned: vporof)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → vporof
Blocks: perf-tool-v2
Depends on: 1077451
Let's handle the multiple recordings bit in a new bug, to give us some time to figure out the UI.
Summary: Handle multiple recordings, import/export in new performance tool → Handle import/export in new performance tool
(In reply to Victor Porof [:vporof][:vp] from comment #1)
> Let's handle the multiple recordings bit in a new bug, to give us some time
> to figure out the UI.

Bug 1111004.
Attached patch v1Splinter Review
Attachment #8538081 - Flags: review?(jsantell)
Comment on attachment 8538081 [details] [diff] [review]
v1

Review of attachment 8538081 [details] [diff] [review]:
-----------------------------------------------------------------

Just gave this a go, works great!

::: browser/devtools/performance/performance-view.js
@@ +85,5 @@
> +  /**
> +   * Handler for clicking the import button.
> +   */
> +  _onImportButtonClick: function(e) {
> +    let fp = Cc["@mozilla.org/filepicker;1"].createInstance(Ci.nsIFilePicker);

Maybe the import and export windows should also be in a module?
Attachment #8538081 - Flags: review?(jsantell) → review+
Another nit, the tests should probably be called "perf" like the other tests, rather than "profiler"
Addressed nits and landed: https://hg.mozilla.org/integration/fx-team/rev/4f32657399b6
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/4f32657399b6
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.