1077454 - Handle import/export in new performance tool

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Comment 1

[Victor Porof [:vporof][:vp]]

Let's handle the multiple recordings bit in a new bug, to give us some time to figure out the UI.

Comment 2

[Victor Porof [:vporof][:vp]]

(In reply to Victor Porof [:vporof][:vp] from comment #1)
> Let's handle the multiple recordings bit in a new bug, to give us some time
> to figure out the UI.

Bug 1111004.

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8538081 [details] [diff] [review]
v1

Review of attachment 8538081 [details] [diff] [review]:
-----------------------------------------------------------------

Just gave this a go, works great!

::: browser/devtools/performance/performance-view.js
@@ +85,5 @@
> +  /**
> +   * Handler for clicking the import button.
> +   */
> +  _onImportButtonClick: function(e) {
> +    let fp = Cc["@mozilla.org/filepicker;1"].createInstance(Ci.nsIFilePicker);

Maybe the import and export windows should also be in a module?

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Another nit, the tests should probably be called "perf" like the other tests, rather than "profiler"

Comment 6

[Victor Porof [:vporof][:vp]]

Addressed nits and landed: https://hg.mozilla.org/integration/fx-team/rev/4f32657399b6

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4f32657399b6