Closed Bug 1077459 Opened 5 years ago Closed 5 years ago

Add flamechart view to Details view in new performance tool

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 37

People

(Reporter: jsantell, Assigned: vporof)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Blocks: perf-tool-v2
Depends on: 1077451
Depends on: 1077444
Assignee: nobody → vporof
Should not be selectable when timeline actor (Gecko < 35) does not exist.
Depends on: 1077476
Attached patch v1 (obsolete) — Splinter Review
Needs a test.
Attached patch v2Splinter Review
Has test.
Attachment #8544751 - Attachment is obsolete: true
Attachment #8544836 - Flags: review?(jsantell)
Comment on attachment 8544836 [details] [diff] [review]
v2

Review of attachment 8544836 [details] [diff] [review]:
-----------------------------------------------------------------

so little code. love it.

::: browser/locales/en-US/chrome/browser/devtools/profiler.properties
@@ +107,5 @@
>  
>  # LOCALIZATION NOTE (recordingsList.saveDialogAllFilter):
>  # This string is displayed as a filter for saving a recording to disk.
>  recordingsList.saveDialogAllFilter=All Files
> +

nit space
Attachment #8544836 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/integration/fx-team/rev/5032626927f2
Status: NEW → ASSIGNED
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/5032626927f2
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Depends on: 1121180
Seems like this might be worth noting once it ships.
relnote-firefox: --- → ?
No longer depends on: 1121180
Note that visibility of this tool depends on bug 1123815. This can't be relnoted until then. It also may not make sense to relnote this separately from the new performance tool.
Release Note Request (optional, but appreciated)
[Why is this notable]:  Nifty new view for performance tool. I think it's worth a new note.
[Suggested wording]: Add flamechart view to Details view in new performance tool
[Links (documentation, blog post, etc)]: 

Jordan, is there anything up that we could link to that explains this tool or shows how it works?
Flags: needinfo?(jsantell)
Setting firefox-relnote flag to 40+ as Liz just added this to the release notes on nucleus.
Will is working on some docs for the new tool for the June 2nd release, but don't think the flame graph stuff is done yet: https://developer.mozilla.org/en-US/docs/Tools/Performance__

(And I think this will replace the current performance page for tools)

Pinging Will
Flags: needinfo?(jsantell) → needinfo?(wbamberg)
jsantell, yes, I am aiming for the June 2nd date, but should have some stuff for you to look at by the end of next week.
Flags: needinfo?(wbamberg)
I could swear this just said Firefox 40. But looks like it went out in 37. I'm removing the release note!
It technically landed in 37, but always behind a pref or build flag; 40.1 dev ed will be the first real "public" release
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.