1077459 - Add flamechart view to Details view in new performance tool

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Should not be selectable when timeline actor (Gecko < 35) does not exist.

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1

Needs a test.

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: v2

Has test.

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8544836 [details] [diff] [review]
v2

Review of attachment 8544836 [details] [diff] [review]:
-----------------------------------------------------------------

so little code. love it.

::: browser/locales/en-US/chrome/browser/devtools/profiler.properties
@@ +107,5 @@
>  
>  # LOCALIZATION NOTE (recordingsList.saveDialogAllFilter):
>  # This string is displayed as a filter for saving a recording to disk.
>  recordingsList.saveDialogAllFilter=All Files
> +

nit space

Comment 5

[Victor Porof [:vporof][:vp]]

SUCH GREEN https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=476eeb84011b

Comment 6

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/5032626927f2

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5032626927f2

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Seems like this might be worth noting once it ships.

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Note that visibility of this tool depends on bug 1123815. This can't be relnoted until then. It also may not make sense to relnote this separately from the new performance tool.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Release Note Request (optional, but appreciated)
[Why is this notable]:  Nifty new view for performance tool. I think it's worth a new note.
[Suggested wording]: Add flamechart view to Details view in new performance tool
[Links (documentation, blog post, etc)]: 

Jordan, is there anything up that we could link to that explains this tool or shows how it works?

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Setting firefox-relnote flag to 40+ as Liz just added this to the release notes on nucleus.

Comment 12

[Jordan Santell [:jsantell] [@jsantell]]

Will is working on some docs for the new tool for the June 2nd release, but don't think the flame graph stuff is done yet: https://developer.mozilla.org/en-US/docs/Tools/Performance__

(And I think this will replace the current performance page for tools)

Pinging Will

Comment 13

[Will Bamberg [:wbamberg]]

jsantell, yes, I am aiming for the June 2nd date, but should have some stuff for you to look at by the end of next week.

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

I could swear this just said Firefox 40. But looks like it went out in 37. I'm removing the release note!

Comment 15

[Jordan Santell [:jsantell] [@jsantell]]

It technically landed in 37, but always behind a pref or build flag; 40.1 dev ed will be the first real "public" release