Closed Bug 1077513 Opened 10 years ago Closed 9 years ago

The default avatar is reduced horizontally for contact with long name

Categories

(Hello (Loop) :: Client, defect, P4)

defect
Points:
2

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Iteration:
43.3 - Sep 21
Tracking Status
firefox43 --- fixed
backlog backlog+

People

(Reporter: pauly, Assigned: standard8)

References

Details

(Whiteboard: [UX bug])

Attachments

(2 files)

STR:
Add a contact with a really long name (e.g. "long nameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee")
Actual results:
The default avatar is reduced horizontally - see attached
Whiteboard: [loop-uplift]
Blocks: 1050307
backlog: --- → Fx36?
Whiteboard: [loop-uplift] → [loop-uplift][UX]
backlog: Fx36? → Fx38?
backlog: Fx38? → Fx37?
backlog: Fx37? → Fx38?
Priority: -- → P4
backlog: Fx38? → backlog+
Rank: 45
Flags: firefox-backlog+
Whiteboard: [loop-uplift][UX] → [UX bug]
I found it interesting that hovering over the contact made the avatar un-squash. It turns out that we're using flex to put the contact divs in horizontal mode, but we're then not specifying the flex attributes on all the elements.

Specifying none on the avatar and the icons, correctly fixes those, then we just have to specify auto on the main contact details to make sure the icon buttons are all the way to the right.

This doesn't make an attempt to fix the fact the name should have an ellipsis at the end if it overflows. I think we're going to need to do something thinking wrt spans etc, so I'm splitting that off to a seperate bug.
Attachment #8658705 - Flags: review?(edilee)
Assignee: nobody → standard8
Iteration: --- → 43.3 - Sep 21
Points: --- → 2
Attachment #8658705 - Flags: review?(edilee) → review+
https://hg.mozilla.org/mozilla-central/rev/9d30e8decf0e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: