Closed Bug 1077611 Opened 5 years ago Closed 5 years ago

Remove platform detection from loop panel & conversation window

Categories

(Hello (Loop) :: Client, defect)

defect
Not set
Points:
1

Tracking

(firefox35 fixed)

RESOLVED FIXED
mozilla35
Iteration:
36.1
Tracking Status
firefox35 --- fixed
Blocking Flags:
backlog Fx38?

People

(Reporter: ntim, Assigned: jaws)

References

Details

Attachments

(1 file, 2 obsolete files)

We really don't need platform detection for loop's CSS. Let's remove that.
This probably comes from the original UX specs which had platform dependent items:

http://people.mozilla.org/~mmaslaney/loop/Loop-platforms.png
http://people.mozilla.org/~mmaslaney/loop/Loop-spec.png

However, one bug recently changed the font to be universal, so we might need this now.
Summary: Remove platform detection from loop panel → Remove platform detection from loop panel & conversation window
(In reply to Mark Banner (:standard8) from comment #1)
> This probably comes from the original UX specs which had platform dependent
> items:
> 
> http://people.mozilla.org/~mmaslaney/loop/Loop-platforms.png
> http://people.mozilla.org/~mmaslaney/loop/Loop-spec.png
> 
> However, one bug recently changed the font to be universal, so we might need
> this now.

Bug 1065537 didn't make the fonts the same across all platforms, it just used a special keyword that would automatically use the system font.
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → ntim007
Status: NEW → ASSIGNED
Attachment #8499876 - Flags: review?(mdeboer)
Comment on attachment 8499876 [details] [diff] [review]
Patch

Review of attachment 8499876 [details] [diff] [review]:
-----------------------------------------------------------------

Please also remove the related CSS since it won't apply anymore.

See:
http://mxr.mozilla.org/mozilla-central/source/browser/components/loop/content/shared/css/common.css#364

I don't know if there are any other instances.
Attachment #8499876 - Flags: review?(mdeboer) → review-
Depends on: 1065537
Attached patch Patch v2 (obsolete) — Splinter Review
Attachment #8499876 - Attachment is obsolete: true
Attachment #8499963 - Flags: review?(mdeboer)
Comment on attachment 8499963 [details] [diff] [review]
Patch v2

Review of attachment 8499963 [details] [diff] [review]:
-----------------------------------------------------------------

You missed the ui-showcase.jsx.
Attachment #8499963 - Flags: review?(mdeboer) → review-
backlog: --- → Fx38?
Hey Tim, are you planning on finishing this bug?

The changes to ui-showcase.jsx will be the same changes that you made to ui-showcase.js (actually, you only need to manually change ui-showcase.jsx and then you can run `jsx -x jsx browser/components/loop/ui/ browser/components/loop/ui` and it will produce an updated ui-showcase.js).
Flags: needinfo?(ntim007)
I'm a bit busy with many things right now, so I probably won't touch this for a while. Feel free to take this though.
Flags: needinfo?(ntim007)
Attached patch Patch v2.1Splinter Review
Thanks for your help Tim. I've redid the patch based off of tip and finished it off.
Assignee: ntim007 → jaws
Attachment #8510481 - Flags: review?(mdeboer)
Attachment #8499963 - Attachment is obsolete: true
Comment on attachment 8510481 [details] [diff] [review]
Patch v2.1

Review of attachment 8510481 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good; r=dmose
Attachment #8510481 - Flags: review?(mdeboer) → review+
Thanks!

https://hg.mozilla.org/integration/fx-team/rev/286fddc30fda
Iteration: --- → 36.1
Points: --- → 1
Flags: qe-verify-
Flags: in-testsuite-
Flags: firefox-backlog+
Whiteboard: [fixed in fx-team]
https://hg.mozilla.org/mozilla-central/rev/286fddc30fda
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-team]
Target Milestone: --- → mozilla35
Comment on attachment 8510481 [details] [diff] [review]
Patch v2.1

Approval Request Comment
Landed on aurora per IRC with lsblakk with a=loop-only
Attachment #8510481 - Flags: approval-mozilla-aurora?
Attachment #8510481 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.