1077611 - Remove platform detection from loop panel & conversation window

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Tim Nguyen :ntim]

We really don't need platform detection for loop's CSS. Let's remove that.

Comment 1

[Mark Banner (:standard8)]

This probably comes from the original UX specs which had platform dependent items:

http://people.mozilla.org/~mmaslaney/loop/Loop-platforms.png
http://people.mozilla.org/~mmaslaney/loop/Loop-spec.png

However, one bug recently changed the font to be universal, so we might need this now.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Mark Banner (:standard8) from comment #1)
> This probably comes from the original UX specs which had platform dependent
> items:
> 
> http://people.mozilla.org/~mmaslaney/loop/Loop-platforms.png
> http://people.mozilla.org/~mmaslaney/loop/Loop-spec.png
> 
> However, one bug recently changed the font to be universal, so we might need
> this now.

Bug 1065537 didn't make the fonts the same across all platforms, it just used a special keyword that would automatically use the system font.

Comment 3

[Tim Nguyen :ntim]

Attachment: Patch

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8499876 [details] [diff] [review]
Patch

Review of attachment 8499876 [details] [diff] [review]:
-----------------------------------------------------------------

Please also remove the related CSS since it won't apply anymore.

See:
http://mxr.mozilla.org/mozilla-central/source/browser/components/loop/content/shared/css/common.css#364

I don't know if there are any other instances.

Comment 5

[Tim Nguyen :ntim]

Attachment: Patch v2

Comment 6

[Mike de Boer [:mikedeboer]]

Comment on attachment 8499963 [details] [diff] [review]
Patch v2

Review of attachment 8499963 [details] [diff] [review]:
-----------------------------------------------------------------

You missed the ui-showcase.jsx.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Hey Tim, are you planning on finishing this bug?

The changes to ui-showcase.jsx will be the same changes that you made to ui-showcase.js (actually, you only need to manually change ui-showcase.jsx and then you can run `jsx -x jsx browser/components/loop/ui/ browser/components/loop/ui` and it will produce an updated ui-showcase.js).

Comment 8

[Tim Nguyen :ntim]

I'm a bit busy with many things right now, so I probably won't touch this for a while. Feel free to take this though.

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v2.1

Thanks for your help Tim. I've redid the patch based off of tip and finished it off.

Comment 10

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8510481 [details] [diff] [review]
Patch v2.1

Review of attachment 8510481 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good; r=dmose

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Thanks!

https://hg.mozilla.org/integration/fx-team/rev/286fddc30fda

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/286fddc30fda

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ba47f2f2dcf7

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8510481 [details] [diff] [review]
Patch v2.1

Approval Request Comment
Landed on aurora per IRC with lsblakk with a=loop-only