Loop isn't using the system/platform font in various places

RESOLVED FIXED in Firefox 34

Status

Hello (Loop)
Client
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

unspecified
mozilla35
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +
in-testsuite -
qe-verify -

Firefox Tracking Flags

(firefox34 fixed, firefox35 fixed)

Details

(Whiteboard: [loop-uplift])

Attachments

(3 attachments)

Created attachment 8487360 [details]
Screenshot of bug

See attachment.
This is the cause of the bug, http://mxr.mozilla.org/mozilla-central/source/browser/components/loop/content/shared/css/common.css#354

There is no "Segoe" font. This can be changed to `font: message-box`.
Blocks: 1040901
OS: All → Windows XP
Summary: Loop panel should be using sans-serif fonts → Loop is trying to use 'Segoe' font on Windows which doesn't exist
Duplicate of this bug: 1060591
Whiteboard: [loop-uplift]
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> There is no "Segoe" font. This can be changed to `font: message-box`.

(In reply to Andrei Oprea [:andreio] from comment #4)
> As reference the fonts were taken from here
> http://people.mozilla.org/~mmaslaney/loop/Loop-spec.png

Darrin/Mike, would using "font: message-box" be fine for Windows? (I can't see which font that is atm).
Flags: needinfo?(mmaslaney)
Flags: needinfo?(dhenein)
See Also: → bug 1016087
Deferring to Mike.
Flags: needinfo?(dhenein)
Yeah, message-box is a special keyword that will use the default UI font for the system. It is the font used on about:home, http://mxr.mozilla.org/mozilla-central/source/browser/base/content/abouthome/aboutHome.css#8

We talked over Vidyo and mmaslaney said he is happy to use it.
Flags: needinfo?(mmaslaney)
Flags: firefox-backlog+

Updated

4 years ago
Flags: qe-verify?
Flags: qe-verify? → qe-verify+

Updated

4 years ago
Blocks: 1077063

Updated

4 years ago
Blocks: 1050307
No longer blocks: 1077063
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Iteration: --- → 35.3
Points: --- → 2
Expanding bug summary to include the wrong font being used on OSX (should be Helvetica Neue).
Summary: Loop is trying to use 'Segoe' font on Windows which doesn't exist → Loop isn't using the system/platform font in various places
Created attachment 8499153 [details] [diff] [review]
Patch

Tested on Windows 7, Ubuntu, and OSX 10.10.
Attachment #8499153 - Flags: review?(mdeboer)

Comment 10

4 years ago
Why are we doing platform detection in the loop panel ? Can we also remove that ? This is a bad development practice.

Updated

4 years ago
OS: Windows XP → All
(In reply to Tim Nguyen [:ntim] from comment #10)
> Why are we doing platform detection in the loop panel ? Can we also remove
> that ? This is a bad development practice.

The loop panel is not part of the browser theme, and thus doesn't benefit from our the browser theme platform-specialization ability. With that being said, there shouldn't be much differences between the panel on the various platforms, with the exception of platform fonts.

Tim, can you file a bug(s) to simplify the other CSS that is adding platform-specific rules? They shouldn't be taken care of in this bug as it will grow too large and get out of hand.
Flags: needinfo?(ntim007)

Comment 12

4 years ago
Filed bug 1077611
Flags: needinfo?(ntim007)

Updated

4 years ago
Blocks: 1077611
Comment on attachment 8499153 [details] [diff] [review]
Patch

Review of attachment 8499153 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for taking so long to get to this review - next time will be super awesome speed... promise!

<3 this generic solution. https://developer.mozilla.org/en-US/docs/Web/CSS/font#Values
Attachment #8499153 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/integration/fx-team/rev/4fa74ef900c5
Flags: in-testsuite-
Whiteboard: [loop-uplift] → [loop-uplift][fixed in fx-team]
https://hg.mozilla.org/mozilla-central/rev/4fa74ef900c5
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [loop-uplift][fixed in fx-team] → [loop-uplift]
Target Milestone: --- → mozilla35
I'm untracking this for QE verification. There are more important bugs that need are attention at this time. If someone else wants to check that this is working as expected, feel free to chime in on this bug.
Flags: qe-verify+ → qe-verify-
Comment on attachment 8499153 [details] [diff] [review]
Patch

Approval Request Comment
Part of the staged Loop aurora second uplift set
Attachment #8499153 - Flags: approval-mozilla-aurora?

Updated

4 years ago
status-firefox34: --- → fixed
status-firefox35: --- → fixed
Comment on attachment 8499153 [details] [diff] [review]
Patch

Already landed, tacking for posterity.
Attachment #8499153 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.