1065537 - Loop isn't using the system/platform font in various places

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Screenshot of bug

See attachment.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Spec

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

This is the cause of the bug, http://mxr.mozilla.org/mozilla-central/source/browser/components/loop/content/shared/css/common.css#354

There is no "Segoe" font. This can be changed to `font: message-box`.

Comment 4

[Andrei Oprea [mention me on [e-mail]]]

As reference the fonts were taken from here http://people.mozilla.org/~mmaslaney/loop/Loop-spec.png

Comment 5

[Mark Banner (:standard8)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> There is no "Segoe" font. This can be changed to `font: message-box`.

(In reply to Andrei Oprea [:andreio] from comment #4)
> As reference the fonts were taken from here
> http://people.mozilla.org/~mmaslaney/loop/Loop-spec.png

Darrin/Mike, would using "font: message-box" be fine for Windows? (I can't see which font that is atm).

Comment 6

[Darrin Henein [:darrin]]

Deferring to Mike.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Yeah, message-box is a special keyword that will use the default UI font for the system. It is the font used on about:home, http://mxr.mozilla.org/mozilla-central/source/browser/base/content/abouthome/aboutHome.css#8

We talked over Vidyo and mmaslaney said he is happy to use it.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Expanding bug summary to include the wrong font being used on OSX (should be Helvetica Neue).

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Tested on Windows 7, Ubuntu, and OSX 10.10.

Comment 10

[Tim Nguyen :ntim]

Why are we doing platform detection in the loop panel ? Can we also remove that ? This is a bad development practice.

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Tim Nguyen [:ntim] from comment #10)
> Why are we doing platform detection in the loop panel ? Can we also remove
> that ? This is a bad development practice.

The loop panel is not part of the browser theme, and thus doesn't benefit from our the browser theme platform-specialization ability. With that being said, there shouldn't be much differences between the panel on the various platforms, with the exception of platform fonts.

Tim, can you file a bug(s) to simplify the other CSS that is adding platform-specific rules? They shouldn't be taken care of in this bug as it will grow too large and get out of hand.

Comment 12

[Tim Nguyen :ntim]

Filed bug 1077611

Comment 13

[Mike de Boer [:mikedeboer]]

Comment on attachment 8499153 [details] [diff] [review]
Patch

Review of attachment 8499153 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for taking so long to get to this review - next time will be super awesome speed... promise!

<3 this generic solution. https://developer.mozilla.org/en-US/docs/Web/CSS/font#Values

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/fx-team/rev/4fa74ef900c5

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4fa74ef900c5

Comment 16

[u279076]

I'm untracking this for QE verification. There are more important bugs that need are attention at this time. If someone else wants to check that this is working as expected, feel free to chime in on this bug.

Comment 17

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8499153 [details] [diff] [review]
Patch

Approval Request Comment
Part of the staged Loop aurora second uplift set

Comment 18

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0ff0c12263af

Comment 19

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8499153 [details] [diff] [review]
Patch

Already landed, tacking for posterity.