1077635 - Align the Platform labels with the top of each job-block row, possible row colors

Status: RESOLVED FIXED

(Tree Management :: Treeherder, enhancement, P3)

Description

[Jonathan French (:jfrench)]

Discussed with RyanVM in channel, it might help readability of the job results to align the Platform name with the top of the job-block similar to TBPL.

Additionally, it might improve readability even further, to segregate each job-block by alternate background color. Much like we did for mozmill-dashboard a few months ago for its test results.

I'll have a look at both improvements, and share with Ryan and Ed to see if they think it improves readability.

Comment 1

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#216

Please see the above PR for review and status.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

I kind of like the subtle border.

Comment 3

[Ed Morley [:emorley]]

Me too, let's give it a go :-)

Comment 4

[Jonathan French (:jfrench)]

Ok, I'll make that change and update the PR. If it's too busy we can always switch to the cleaner one.

Comment 5

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/46ebf234016877383dec7b39fa4e65b75ff78f0d
Bug 1077635 - Improve readability of platform job rows

https://github.com/mozilla/treeherder-ui/commit/027a5744f5a3a119e0e637e38e5ce0d876d28058
Merge pull request #216 from tojonmz/platform-readability

Bug 1077635 - Improve readability of platform job rows

Comment 6

[Jonathan French (:jfrench)]

There's a minor tweak I just noticed, and would like to do. Some resultsets with small numbers of jobs don't paint the alternating rows the full width of the parent container. I will open a separate PR for that.

Comment 7

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#218-supplementary

This provides the desired UI appearance, for the scenario mentioned above.

Comment 8

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/6ffc69c41e2b3ee87cdb091c7139d21931775fb9
Bug 1077635 - Draw low-count job rows with consistent table appearance

https://github.com/mozilla/treeherder-ui/commit/90249ce5cc46ab56a076420f1c6ed6ebf68cd355
Merge pull request #218 from tojonmz/short-row-support

Bug 1077635 - Draw low-count job rows with consistent table appearance

Comment 9

[Jonathan French (:jfrench)]

Verified the primary and supplementary PR's are landed, and fixed and working correctly on dev/stage.

Comment 11

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/b85eff8bc84ec5c1c797477d7e87cada0c40af9f
Bug 1077635 - Improve readability of platform job rows

https://github.com/mozilla/treeherder/commit/4ead4e68d8b5ab305a41ac010946c821750d2f73
Merge pull request #216 from tojonmz/platform-readability

Bug 1077635 - Improve readability of platform job rows

https://github.com/mozilla/treeherder/commit/8e13e008ee90ce373df86b4b95c8699b88070d45
Bug 1077635 - Draw low-count job rows with consistent table appearance

https://github.com/mozilla/treeherder/commit/51c5b3245ffff61732d6a03f9091dd3b764755a9
Merge pull request #218 from tojonmz/short-row-support

Bug 1077635 - Draw low-count job rows with consistent table appearance