Gracefully handle invalid SWFs

RESOLVED FIXED

Status

Firefox Graveyard
Shumway
P3
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: till, Assigned: tobytailor)

Tracking

Dependency tree / graph

Details

(Reporter)

Description

3 years ago
Currently, if the SWF parser doesn't find any tags, an exception is thrown in BodyParser#push, because it excepts at least one tag to be parsed.

Example file: http://video.golem.de/staticrl/swf/flbd3.swf

Note that Trillix, the SWF archive's parser and velocity9 also all choke on this SWF, so it really does seem to be invalid. We should probably still find out what it does and why it's used in the golem.de video player.
We should fix this for M3 because we are likely to see bad SWFs in the wild.
Assignee: nobody → till
Blocks: 1037568
Priority: -- → P3
Blocks: 1137916
(Reporter)

Comment 2

3 years ago
Assigning to Tobias for evaluation once we have more tests. This is an ongoing task rather than something where we can at some point say that it's done, so we will eventually make the decision that it's good enough. Moving to m4 in any case, because landing on Nightly doesn't depend on it.
Assignee: till → schneider
Blocks: 1037580
No longer blocks: 1037568
(Assignee)

Comment 3

3 years ago
Addressed in https://github.com/mozilla/shumway/pull/2103.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.