Closed Bug 1077671 Opened 10 years ago Closed 10 years ago

Gracefully handle invalid SWFs

Categories

(Firefox Graveyard :: Shumway, defect, P3)

Product:
Firefox Graveyard
Component:
Shumway
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: till, Assigned: tschneider)

References

Details

Currently, if the SWF parser doesn't find any tags, an exception is thrown in BodyParser#push, because it excepts at least one tag to be parsed. Example file: http://video.golem.de/staticrl/swf/flbd3.swf Note that Trillix, the SWF archive's parser and velocity9 also all choke on this SWF, so it really does seem to be invalid. We should probably still find out what it does and why it's used in the golem.de video player.
We should fix this for M3 because we are likely to see bad SWFs in the wild.
Assignee: nobody → till
Blocks: shumway-m3
Priority: -- → P3
Assigning to Tobias for evaluation once we have more tests. This is an ongoing task rather than something where we can at some point say that it's done, so we will eventually make the decision that it's good enough. Moving to m4 in any case, because landing on Nightly doesn't depend on it.
Assignee: till → schneider
Blocks: shumway-m4
No longer blocks: shumway-m3
Addressed in https://github.com/mozilla/shumway/pull/2103.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.