Closed
Bug 1078114
Opened 9 years ago
Closed 9 years ago
[Stingray] Support tv_apps directory for CardUI related apps
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S7 (24Oct)
People
(Reporter: rexboy, Assigned: chens)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(2 files)
Per bug 1067781, we need to commit Card UI related apps inside tv_apps/ directory. So we need to modify build script to enable tv_apps/ directory for various situations, such as debugging under nightly, make install-gaia, etc.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8500258 -
Flags: feedback?(ricky060709)
Assignee | ||
Comment 2•9 years ago
|
||
Ricky, could you take a look and give some feedback? Once we have tv apps directory, this patch will enable debugging/testing tv apps from nightly.
Comment 3•9 years ago
|
||
I've no objections with create a tv_apps for TV device. It's fine to set r?=me. Thanks!
Updated•9 years ago
|
Attachment #8500258 -
Flags: feedback?(ricky060709) → feedback+
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8500258 [details] [review] Pull request Thanks Ricky :)
Attachment #8500258 -
Flags: review?(ricky060709)
Comment 5•9 years ago
|
||
Comment on attachment 8500258 [details] [review] Pull request LGTM. r=@RickyChien
Attachment #8500258 -
Flags: review?(ricky060709) → review+
Assignee | ||
Comment 6•9 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/39dc2d29aac89f36e8e26f9950cdb0b46f0f42b0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → shchen
Updated•9 years ago
|
Target Milestone: --- → 2.1 S7 (24Oct)
Updated•9 years ago
|
Whiteboard: [ft:conndevices]
Comment 7•9 years ago
|
||
When changing APP_TEST_LIST, you forgot to add $(APP) in the part for tv_apps, so as a result it tries to execute unit tests for tv_apps apps when we use APP=. For example: APP=sms make test-agent-test will launch tests for tv_apps. Can we please fix this?
Flags: needinfo?(shchen)
Assignee | ||
Comment 8•9 years ago
|
||
Sure, I can fix this. Thanks for reminding!
Flags: needinfo?(shchen)
Assignee | ||
Comment 9•9 years ago
|
||
Hi Ricky, Previous patch forgot to add $(APP) in tv_apps directory, and I've made this patch fixing this, would you review it? thanks!
Attachment #8517857 -
Flags: review?(ricky060709)
Comment 10•9 years ago
|
||
Comment on attachment 8517857 [details] [review] Pull request LGTM. r+
Attachment #8517857 -
Flags: review?(ricky060709) → review+
Assignee | ||
Comment 11•9 years ago
|
||
master: https://github.com/mozilla-b2g/gaia/commit/efe4232771ac74252eff91f66f28b53b91faebd6
Comment 12•9 years ago
|
||
Thanks for the quick fix :)
You need to log in
before you can comment on or make changes to this bug.
Description
•