Closed Bug 1078114 Opened 8 years ago Closed 8 years ago
[Stingray] Support tv
_apps directory for Card UI related apps
Per bug 1067781, we need to commit Card UI related apps inside tv_apps/ directory. So we need to modify build script to enable tv_apps/ directory for various situations, such as debugging under nightly, make install-gaia, etc.
Ricky, could you take a look and give some feedback? Once we have tv apps directory, this patch will enable debugging/testing tv apps from nightly.
I've no objections with create a tv_apps for TV device. It's fine to set r?=me. Thanks!
Attachment #8500258 - Flags: feedback?(ricky060709) → feedback+
Comment on attachment 8500258 [details] [review] Pull request Thanks Ricky :)
Attachment #8500258 - Flags: review?(ricky060709)
Comment on attachment 8500258 [details] [review] Pull request LGTM. r=@RickyChien
Attachment #8500258 - Flags: review?(ricky060709) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
When changing APP_TEST_LIST, you forgot to add $(APP) in the part for tv_apps, so as a result it tries to execute unit tests for tv_apps apps when we use APP=. For example: APP=sms make test-agent-test will launch tests for tv_apps. Can we please fix this?
Sure, I can fix this. Thanks for reminding!
Hi Ricky, Previous patch forgot to add $(APP) in tv_apps directory, and I've made this patch fixing this, would you review it? thanks!
Attachment #8517857 - Flags: review?(ricky060709)
Comment on attachment 8517857 [details] [review] Pull request LGTM. r+
Attachment #8517857 - Flags: review?(ricky060709) → review+
Thanks for the quick fix :)
You need to log in before you can comment on or make changes to this bug.