1078239 - The 'all_others' bug suggestion query misses recently modified fixed bugs

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Carsten Book [:Tomcat]]

Attachment: screenshot

See Screenshot, for the test failure 1346 INFO TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_ignoreuserfocus.html | Test timed out. - expected PASS should be suggested Bug 942411 but its not :( actually no bug is suggested :(

Comment 1

[Ed Morley [:emorley]]

The screenshot appears to be of bug 942411 comment 582, which is (please include log links in future bugs like this :-)):

https://treeherder.mozilla.org/ui/logviewer.html#?repo=mozilla-inbound&job_id=2784253
https://treeherder.mozilla.org/api/project/mozilla-inbound/artifact/?job_id=2784253&name=Bug+suggestions&type=json

...which does not have bug suggestions.

The search term is:
test_ignoreuserfocus.html

Which currently does return suggestions:
https://treeherder.mozilla.org/api/bugscache/?search=test_ignoreuserfocus.html

...however at the time of comment 0, the bug was marked as FIXED.

Looking at the SQL, we have a gap between the queries for open_recent and all_others - ie a "recently modified, but resolved fixed bug" will appear in neither.

https://github.com/mozilla/treeherder-service/blob/master/treeherder/model/sql/reference.json#L316

"get_open_recent_bugs": {
...
            WHERE 1
                AND resolution = ''
                AND MATCH (`summary`)
                    AGAINST (? IN BOOLEAN MODE)
                AND modified >= ?
...
},
"get_all_others_bugs": {
...
            WHERE 1
                AND MATCH (`summary`)
                    AGAINST (? IN BOOLEAN MODE)
                AND modified < ?
...
},

To fix this, all_others needs to instead use something like:

                AND (resolution != '' OR modified < ?)

Comment 2

[Ed Morley [:emorley]]

Attachment: Fix bug suggestions for recently modified, resolved bugs

Comment 3

[Mauro Doglio [:mdoglio]]

Comment on attachment 8515117 [details] [review]
Fix bug suggestions for recently modified, resolved bugs

Travis says that there's a failure but I cannot access it at the moment. :edmorley do you mind looking into this failure locally?

Comment 4

[Ed Morley [:emorley]]

PR updated, travis passing.

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/05cf876d4a6bd65879003244ffbfd720b4ed643c
Bug 1078239 - Fix bug suggestions for recently modified, resolved bugs

We divide bug suggestions for a search term into 'open_recent' and
'all_others'. The former is supposed to be group #1 below, and the
latter groups 2-4, with the summation of the two groups corresponding
to every bug whose summary matches the search term.

1) Open + recently modified
2) Open + not recently modified
3) Resolved + recently modified
4) Resolved + not recently modified

However prior to this patch group #3 was not being returned at all, when
it should have been included in all_others.