Closed Bug 942411 Opened 11 years ago Closed 10 years ago

Intermittent test_ignoreuserfocus.html | Test timed out.

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal
Points:
2

Tracking

()

Status:
RESOLVED FIXED
Milestone:
2.2 S8 (20mar)
Tracking Flags:
Tracking Status
firefox28 --- wontfix
firefox29 --- wontfix
firefox30 --- wontfix
firefox31 --- wontfix
firefox32 --- wontfix
firefox33 --- fixed
firefox34 --- fixed
firefox35 --- fixed
firefox36 --- disabled
firefox37 --- fixed
firefox38 --- fixed
firefox39 --- fixed
firefox-esr24 --- unaffected
firefox-esr31 --- wontfix
b2g-v1.3 --- wontfix
b2g-v1.3T --- wontfix
b2g-v1.4 --- wontfix
b2g-v2.0 --- fixed
b2g-v2.0M --- fixed
b2g-v2.1 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: philor, Assigned: enndeakin)

References

Details

(Keywords: intermittent-failure)

Attachments

(3 files)

Force reflow
2.37 KB, patch
smaug
: review+
Details | Diff | Splinter Review
Use specialpowers.pushPermissions
1.40 KB, patch
smaug
: review+
Details | Diff | Splinter Review
ignoreuserfocus
2.07 KB, patch
smaug
: review+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=30992663&tree=Mozilla-Central b2g_emulator_vm mozilla-central opt test mochitest-2 on 2013-11-22 19:05:21 PST for push 98aa428a392c slave: tst-linux64-ec2-136 19:43:09 INFO - 33839 INFO TEST-START | /tests/content/html/content/test/test_ignoreuserfocus.html 19:43:09 INFO - ###################################### forms.js loaded 19:43:09 INFO - ############################### browserElementPanning.js loaded 19:43:09 INFO - ######################## BrowserElementChildPreload.js loaded 19:43:09 INFO - 33840 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_ignoreuserfocus.html | Test timed out. 19:43:09 INFO - 33841 INFO TEST-INFO | MEMORY STAT vsize after test: 96653312 19:43:09 INFO - 33842 INFO TEST-INFO | MEMORY STAT residentFast after test: 45309952 19:43:09 INFO - 33843 INFO TEST-INFO | MEMORY STAT heapAllocated after test: 16736484 19:43:09 INFO - 33844 INFO TEST-END | /tests/content/html/content/test/test_ignoreuserfocus.html | finished in 323394ms
Of the tests that haven't been disabled yet, this is probably the most frequent mochitest-3 failure we're still hitting. Andrew, if you can help find an owner, that would be cool :)
Flags: needinfo?(overholt)
Assignee: nobody → kchen
Attached patch Force reflow — — Splinter Review
Try looks greenish.
Attachment #8380118 - Flags: review?(bugs)
Flags: needinfo?(overholt)
Comment on attachment 8380118 [details] [diff] [review] Force reflow Use iframe.offsetLeft for forcing reflow?
Attachment #8380118 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/58484bba3199
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
This is quite obviously not fixed and currently one of our top oranges.
status-b2g-v1.3: fixed → affected
status-b2g-v1.4: fixed → affected
status-firefox28: fixed → affected
status-firefox29: fixed → affected
status-firefox30: fixed → affected
Flags: needinfo?(kchen)
Nothing in this test ensures that the test window has the focus, let's try to see if this can be the cause: https://hg.mozilla.org/integration/mozilla-inbound/rev/0d77baea6b58
Keywords: leave-open
Hmm, both comment 249 and comment 252 are from after my fix. What happens is very interesting: 22:50:18 INFO - 691 INFO TEST-START | /tests/content/html/content/test/test_ignoreuserfocus.html 22:50:20 INFO - ############################### browserElementPanning.js loaded 22:50:20 INFO - ######################## BrowserElementChildPreload.js loaded 22:55:37 INFO - 692 INFO TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_ignoreuserfocus.html | Test timed out. 22:55:38 INFO - 693 INFO TEST-INFO | MEMORY STAT vsize after test: 95911936 22:55:39 INFO - 694 INFO TEST-INFO | MEMORY STAT residentFast after test: 44666880 22:55:39 INFO - 695 INFO TEST-INFO | MEMORY STAT heapAllocated after test: 18193988 22:55:39 INFO - 696 INFO TEST-END | /tests/content/html/content/test/test_ignoreuserfocus.html | finished in 320385ms 22:55:40 INFO - 697 INFO TEST-INFO | dumping last 14 message(s) 22:55:40 INFO - 698 INFO TEST-INFO | if you need more context, please use SimpleTest.requestCompleteLog() in your test 22:55:40 INFO - 699 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | witness should have the focus 22:55:41 INFO - 700 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [explicit iframe.focus()] iframe should not get the focus 22:55:41 INFO - 701 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | Shouldn't get a focus event in ignoreuserfocus iframe! 22:55:41 INFO - 702 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | Shouldn't get a focus event in ignoreuserfocus iframe! 22:55:41 INFO - 703 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [explicit iframe.focus()] iframe should get the focus 22:55:41 INFO - 704 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [explicit innerInput.focus()] iframe should not have the focus 22:55:41 INFO - 705 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [synthesize mouse click] witness should have the focus 22:55:41 INFO - 706 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [explicit innerIframe.focus()] iframe should not have the focus 22:55:41 INFO - 707 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [synthesize mouse click inner iframe] witness should have the focus 22:55:41 INFO - 708 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [explicit innerArea.focus()] iframe should not have the focus 22:55:41 INFO - 709 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [synthesize mouse click] witness should have the focus 22:55:41 INFO - 710 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | witness should have the focus 22:55:41 INFO - 711 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [synthesize tab key] iframe should not have the focus 22:55:41 INFO - 712 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | witness2 should have the focus 22:55:41 INFO - 713 INFO TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_ignoreuserfocus.html | [SimpleTest.finish()] this test already called finish! 22:55:41 INFO - 714 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_ignoreuserfocus.html | called finish() multiple times It seems that the test runs until finish() is called, and then just hangs around until it times out and finish is called again on it, or something. Adding SimpleTest.requestCompleteLog() to get in-order logging: https://hg.mozilla.org/integration/mozilla-inbound/rev/c313ebdadc15
(In reply to TBPL Robot from comment #273) 05:55:09 INFO - 686 INFO TEST-START | /tests/content/html/content/test/test_ignoreuserfocus.html 05:55:10 INFO - ############################### browserElementPanning.js loaded 05:55:11 INFO - ######################## BrowserElementChildPreload.js loaded 06:00:25 INFO - 687 INFO TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_ignoreuserfocus.html | Test timed out. 06:00:26 INFO - 688 INFO TEST-INFO | MEMORY STAT vsize after test: 95956992 06:00:26 INFO - 689 INFO TEST-INFO | MEMORY STAT residentFast after test: 44560384 06:00:26 INFO - 690 INFO TEST-INFO | MEMORY STAT heapAllocated after test: 18201340 06:00:26 INFO - 691 INFO TEST-END | /tests/content/html/content/test/test_ignoreuserfocus.html | finished in 317022ms 06:00:27 INFO - 692 INFO TEST-INFO | dumping last 14 message(s) 06:00:27 INFO - 693 INFO TEST-INFO | if you need more context, please use SimpleTest.requestCompleteLog() in your test 06:00:27 INFO - 694 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | witness should have the focus 06:00:27 INFO - 695 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [explicit iframe.focus()] iframe should not get the focus 06:00:27 INFO - 696 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | Shouldn't get a focus event in ignoreuserfocus iframe! 06:00:27 INFO - 697 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | Shouldn't get a focus event in ignoreuserfocus iframe! 06:00:27 INFO - 698 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [explicit iframe.focus()] iframe should get the focus 06:00:27 INFO - 699 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [explicit innerInput.focus()] iframe should not have the focus 06:00:27 INFO - 700 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [synthesize mouse click] witness should have the focus 06:00:27 INFO - 701 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [explicit innerIframe.focus()] iframe should not have the focus 06:00:27 INFO - 702 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [synthesize mouse click inner iframe] witness should have the focus 06:00:28 INFO - 703 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [explicit innerArea.focus()] iframe should not have the focus 06:00:28 INFO - 704 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [synthesize mouse click] witness should have the focus 06:00:28 INFO - 705 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | witness should have the focus 06:00:28 INFO - 706 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [synthesize tab key] iframe should not have the focus 06:00:28 INFO - 707 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | witness2 should have the focus 06:00:28 INFO - 708 INFO TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_ignoreuserfocus.html | [SimpleTest.finish()] this test already called finish! 06:00:28 INFO - 709 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_ignoreuserfocus.html | called finish() multiple times
WTF?! Nathan, is requestCompleteLog not working?! See comment 257 where I added that to this test, and see the previous comment where it doesn't work.
Flags: needinfo?(nfroyd)
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #275) > WTF?! Nathan, is requestCompleteLog not working?! See comment 257 where I > added that to this test, and see the previous comment where it doesn't work. Hm, doesn't seem to be working. I don't understand why. But it doesn't look like there are a lot of messages buffered anyway?
Flags: needinfo?(nfroyd)
(In reply to Nathan Froyd (:froydnj) from comment #276) > (In reply to :Ehsan Akhgari (needinfo? me!) from comment #275) > > WTF?! Nathan, is requestCompleteLog not working?! See comment 257 where I > > added that to this test, and see the previous comment where it doesn't work. > > Hm, doesn't seem to be working. I don't understand why. But it doesn't > look like there are a lot of messages buffered anyway? See comment 253 please, especially the last paragraph there. I basically want to understand why this test is timing out *after* it calls finish()! And the log capturing makes it very hard to reason about the order in which events are happening here. Any easy workarounds/fixes that we can make to requestCompleteLog? Pretty please? :-)
Flags: needinfo?(nfroyd)
I did some try runs with more explicit logging to try and figure out what was going on: https://tbpl.mozilla.org/?tree=Try&rev=d8d55bca7b53 https://tbpl.mozilla.org/php/getParsedLog.php?id=36394374&tree=Try 07:28:15 INFO - 3709 INFO TEST-START | /tests/content/html/content/test/test_ignoreuserfocus.html 07:28:16 INFO - 3710 INFO RCL: forcing log output 07:28:16 INFO - ############################### browserElementPanning.js loaded 07:28:16 INFO - ######################## BrowserElementChildPreload.js loaded 07:33:31 INFO - 3711 INFO logging error message 07:33:31 INFO - 3712 INFO TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_ignoreuserfocus.html | Test timed out. 07:33:32 INFO - 3713 INFO RCL: un-forcing log output 07:33:32 INFO - 3714 INFO TEST-INFO | MEMORY STAT vsize after test: 92512256 07:33:32 INFO - 3715 INFO TEST-INFO | MEMORY STAT residentFast after test: 41648128 07:33:32 INFO - 3716 INFO TEST-INFO | MEMORY STAT heapAllocated after test: 15068560 07:33:32 INFO - 3717 INFO TEST-END | /tests/content/html/content/test/test_ignoreuserfocus.html | finished in 317182ms 07:33:32 INFO - 3718 INFO buffering message for future output 07:33:32 INFO - 3719 INFO buffering message for future output 07:33:32 INFO - 3720 INFO buffering message for future output 07:33:32 INFO - 3721 INFO buffering message for future output 07:33:32 INFO - 3722 INFO buffering message for future output 07:33:32 INFO - 3723 INFO buffering message for future output 07:33:33 INFO - 3724 INFO buffering message for future output 07:33:33 INFO - 3725 INFO buffering message for future output 07:33:33 INFO - 3726 INFO buffering message for future output 07:33:33 INFO - 3727 INFO buffering message for future output 07:33:33 INFO - 3728 INFO buffering message for future output 07:33:33 INFO - 3729 INFO buffering message for future output 07:33:33 INFO - 3730 INFO buffering message for future output 07:33:33 INFO - 3731 INFO buffering message for future output 07:33:33 INFO - 3732 INFO logging error message 07:33:33 INFO - 3733 INFO TEST-INFO | dumping last 14 message(s) 07:33:33 INFO - 3734 INFO TEST-INFO | if you need more context, please use SimpleTest.requestCompleteLog() in your test 07:33:33 INFO - 3735 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | witness should have the focus 07:33:33 INFO - 3736 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [explicit iframe.focus()] iframe should not get the focus 07:33:33 INFO - 3737 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | Shouldn't get a focus event in ignoreuserfocus iframe! 07:33:33 INFO - 3738 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | Shouldn't get a focus event in ignoreuserfocus iframe! 07:33:33 INFO - 3739 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [explicit iframe.focus()] iframe should get the focus 07:33:33 INFO - 3740 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [explicit innerInput.focus()] iframe should not have the focus 07:33:34 INFO - 3741 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [synthesize mouse click] witness should have the focus 07:33:34 INFO - 3742 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [explicit innerIframe.focus()] iframe should not have the focus 07:33:34 INFO - 3743 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [synthesize mouse click inner iframe] witness should have the focus 07:33:34 INFO - 3744 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [explicit innerArea.focus()] iframe should not have the focus 07:33:34 INFO - 3745 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [synthesize mouse click] witness should have the focus 07:33:34 INFO - 3746 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | witness should have the focus 07:33:34 INFO - 3747 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | [synthesize tab key] iframe should not have the focus 07:33:34 INFO - 3748 INFO TEST-PASS | /tests/content/html/content/test/test_ignoreuserfocus.html | witness2 should have the focus 07:33:34 INFO - 3749 INFO TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_ignoreuserfocus.html | [SimpleTest.finish()] this test already called finish! 07:33:34 INFO - 3750 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_ignoreuserfocus.html | called finish() multiple times So the logging is working as intended, it's just that the load event from the mozbrowser iframe doesn't get triggered until after the test has already timed out. At that point, everything passes, but since the test has finished, the cleanup function that resets whether logging is forced has already run. I guess the next step is to figure out why the window isn't getting focus until after it has timed out?
Flags: needinfo?(nfroyd)
Inspired by: https://bugzilla.mozilla.org/show_bug.cgi?id=985549#c2 I moved the setting of the src attribute until after the iframe has been appended to the document: https://tbpl.mozilla.org/?tree=Try&rev=ce88c5b34267 And so far (10 retriggers, more pending), I haven't seen a single instance of test_ignoreuserfocus.html failing. I saw two failures in 12 retriggers yesterday, so cautiously optimistic about this. The test_no_load_event.html failures are because I am using an older base for try; the other oranges seem to be standard intermittents, though the test_replay_metadata.html failures seem to be new? Not sure about that.
Hm, looking at other mozbrowser-using tests in-tree, everything else seems fine with setting src prior to appending the frame to the document. So that try push is just cargo-culting things.
(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #301) > Comment 290 makes sense, landed that as > https://hg.mozilla.org/integration/mozilla-inbound/rev/73bed2a97a20. Wait, what about comment 291? Or do those tests have intermittents too and I was just too lazy to look for them?
Flags: needinfo?(ehsan)
(In reply to Nathan Froyd (:froydnj) from comment #303) > (In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment > #301) > > Comment 290 makes sense, landed that as > > https://hg.mozilla.org/integration/mozilla-inbound/rev/73bed2a97a20. > > Wait, what about comment 291? Or do those tests have intermittents too and > I was just too lazy to look for them? If this ends up fixing this one test, I'll spend some time to port this to all of those other tests too.
Flags: needinfo?(ehsan)
(Yes, we're just shooting in the dark here!)
Looks like we're done here. Thanks, Nathan!
Assignee: kchen → nfroyd
Flags: needinfo?(kchen)
Keywords: leave-open
Thanks!!
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
status-b2g-v2.0: --- → fixed
status-firefox28: affected → wontfix
status-firefox31: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S4 (28mar)
(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #304) > If this ends up fixing this one test, I'll spend some time to port this to > all of those other tests too. I'm holding you to that! https://hg.mozilla.org/releases/mozilla-aurora/rev/f80c8ff8e3fd https://hg.mozilla.org/releases/mozilla-beta/rev/c5fe27b22984 https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/dc252ee24027
status-b2g-v1.3: affected → fixed
status-b2g-v1.4: affected → fixed
status-firefox29: affected → fixed
status-firefox30: affected → fixed
(In reply to comment #311) > (In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment > #304) > > If this ends up fixing this one test, I'll spend some time to port this to > > all of those other tests too. > > I'm holding you to that! I did look at some of the other tests that use this pattern. Most of them don't have any intermittent failures. For some that do (for example datastore), I did a try push which tried out this fix, and it was not effective at all. So I guess given that we don't even know why this patch helped, we should hold off touching other tests and just keep this in mind for the future. :/
Comment 312 worries me. Hopefully not a sign of things to come :(
status-b2g-v1.3T: --- → fixed
(In reply to comment #314) > Comment 312 worries me. Hopefully not a sign of things to come :( :(
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I don't suppose anybody here has any fresh ideas about what might be going on?
status-b2g-v1.3: fixed → affected
status-b2g-v1.3T: fixed → affected
status-b2g-v1.4: fixed → affected
status-b2g-v2.0: fixed → affected
status-firefox29: fixed → wontfix
status-firefox30: fixed → affected
status-firefox31: fixed → affected
Target Milestone: 1.4 S4 (28mar) → ---
I'm planning to skip this test on Linux shortly. Speak now or forever hold your peace.
Flags: needinfo?(kchen)
Flags: needinfo?(ehsan.akhgari)
Flags: needinfo?(bugs)
Skipping linux only might be ok, if we still run this on b2g.
Flags: needinfo?(bugs)
Flags: needinfo?(ryanvm)
Neil is back from vacation, so needinfo'ing him instead of myself.
Flags: needinfo?(ehsan.akhgari) → needinfo?(enndeakin)
Wow, what a burst of fails.. agree we could skip linux. BTW, maybe it's easier to reproduce on linux now?
Flags: needinfo?(kchen)
(In reply to Kan-Ru Chen [:kanru] from comment #427) > Wow, what a burst of fails.. agree we could skip linux. BTW, maybe it's > easier to reproduce on linux now? The failures are almost all mochitest-e10s debug. If you want to try to reproduce locally, you can feed the --e10s flag to mach when invoking it.
Flags: needinfo?(ryanvm)
This is the #1 non-infra orange on trunk. I intend to disable this test within two days per the Job Visibility Policy due to the lack of progress in this bug.
Flags: needinfo?(kchen)
I tried this on desktop yesterday. ./mach mochitest-plain --e10s --run-until-failure --repeat 1000 --jsdebugger --debug-on-failure content/html/content/test/test_ignoreuserfocus.html but still can't reproduce Maybe we could use one of these VM's to debug?
(In reply to Kan-Ru Chen [:kanru] from comment #529) > Maybe we could use one of these VM's to debug? Absolutely. File a bug in Release Engineering::Loan Requests to get the ball rolling :)
Hmm, so I saw the fix for bug 994292 and bug 995438.. we might need the same fix here. I'll test it with my other changes that prevent test failure because of stolen window focus.
Flags: needinfo?(kchen)
Run a few hundreds times on a loaner machine and no test failure.
Attachment #8499459 - Flags: review?(bugs)
Attachment #8499459 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/90adfed296ed Thanks for fixing this, Kan-Ru!
Status: REOPENED → RESOLVED
Closed: 11 years ago → 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S6 (10oct)
Hi Kanru, from the number of hits from the robot it seems its not fixed, could you take a look again. thanks!
Status: RESOLVED → REOPENED
Flags: needinfo?(kchen)
Resolution: FIXED → ---
Disabled on Linux e10s debug. https://hg.mozilla.org/integration/mozilla-inbound/rev/94704fc64827
status-firefox36: --- → disabled
Whiteboard: [qa-] → [qa-][disabled on Linux debug e10s][leave open]
Attached patch ignoreuserfocus — — Splinter Review
When I re-enable this test on Linux e10s, I can often get the test timing out because the MozAfterPaint event fires before the load event. A patch to change the height of the iframe to force it to reflow fixes this and it didn't fail in the 200+ times I ran the test. Interestingly, this was pretty much what the original patch in comment 96 did, yet it was changed to just retrieve the offsetLeft instead. Of course, getting the offsetLeft doesn't force it to reflow at all if there isn't anything pending to reflow. I'd like to re-enable this again for a short period with the original intent to see if we can improve things here. If not, we can disable again and I can keep digging.
Attachment #8578021 - Flags: review?(bugs)
Attachment #8578021 - Flags: review?(bugs) → review+
Thanks!
Flags: needinfo?(kchen)
That last one looks more like the problems caused by 1042561 as test_ignoreuserfocus.html gets to the finish() call successfully.
The test is still disabled with: skip-if = (toolkit == 'gonk' && debug) but I think that is unrelated to the intermittent orange. Anyhow, comment 0 suggests this intermittent failure was for optimized builds. There's been no failures for a few days so I am going to mark this fixed.
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Whiteboard: [qa-][disabled on Linux debug e10s][leave open] → [qa-]
status-b2g-v2.2: fixed → affected
status-b2g-master: --- → fixed
status-firefox37: --- → affected
status-firefox38: --- → affected
status-firefox39: --- → fixed
Target Milestone: 2.1 S6 (10oct) → 2.2 S8 (20mar)
Flags: qe-verify-
Whiteboard: [qa-]
50/50 green runs on Try. Re-enabled across the board. https://hg.mozilla.org/integration/b2g-inbound/rev/d9014469296e
Assignee: nfroyd → enndeakin
Component: General → DOM
Product: Firefox OS → Core
Points: --- → 2
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: