1078262 - animation of CSS transform: rotateX() shakes as it crosses rotation of 0

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[maciek]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140923175406

Steps to reproduce:

Here is all described http://stackoverflow.com/questions/25995581/firefox-32-0-2-transform-issue Problem is transform -> rotateX between -0.5deg and 0.5deg, here is result http://jsfiddle.net/hdxoo9wy/1/
It is new bug, last version (i guess 31) was working correctly.


Actual results:

rotation between -0.5deg and 0.5deg gives random effect and when animation has this range - it shakes.


Expected results:

Best result would be working as in ff 31 version.

Comment 1

[Loic]

Attachment: 1078262.html

Comment 2

[Loic]

Reg range:
good=2014-05-13
bad=2014-05-14
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4b6d63b05a0a&tochange=2f8af55d6e9a

My guess goes to one of patches from bug 1008917.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to Loic from comment #2)
> http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4b6d63b05a0a&tochange=2f8af55d6e9a
> 
> My guess goes to one of patches from bug 1008917.

Seems unlikely.

I think the most likely is https://hg.mozilla.org/mozilla-central/rev/22b09f1086f9

Comment 4

[Alice0775 White]

Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/971b840c40ff
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140513042856
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35af5d1c97c3
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140513043857
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=971b840c40ff&tochange=35af5d1c97c3

Suspect: Bug 1009020

Comment 5

[Sylvestre Ledru [:Sylvestre]]

This is too late for 33 but we would take a patch for 34.

Comment 6

[Markus Stange [:mstange]]

I've confirmed that this was caused by bug 1009020.

Comment 7

[Markus Stange [:mstange]]

Attachment: Only use the fixed epsilon for the translation components

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8504661 [details] [diff] [review]
Only use the fixed epsilon for the translation components

Review of attachment 8504661 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/reftests/bugs/1078262-1.html
@@ +25,5 @@
> +}
> +@keyframes active-rotation {
> +  from { transform: rotateX(10.01deg);}
> +  to { transform: rotateX(10.00deg);}
> +}  

trailing whitespace

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/60ff91674d5d

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

34 and 35 are marked as affected. This fix has now been on m-c for 6 days. Do you think this can be uplifted to Beta and Aurora?

Comment 13

[Markus Stange [:mstange]]

Comment on attachment 8504661 [details] [diff] [review]
Only use the fixed epsilon for the translation components

Approval Request Comment
[Feature/regressing bug #]: bug 1009020
[User impact if declined]: shaky animations
[Describe test coverage new/current, TBPL]: reftest included
[Risks and why]: fairly low
[String/UUID change made/needed]: none

Comment 14

[Markus Stange [:mstange]]

Attachment: patch for Beta

Comment 15

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8504661 [details] [diff] [review]
Only use the fixed epsilon for the translation components

Aurora+

I'm going to go ahead and assume that the Beta approval should be on the patch for beta instead of this patch.

Comment 16

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8510981 [details] [diff] [review]
patch for Beta

Beta+

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4026969d82f4
https://hg.mozilla.org/releases/mozilla-beta/rev/2c49dc84f1a0

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/2c49dc84f1a0