1097776 - Animation of CSS transform: rotateX() shakes as it crosses rotation of 0, when hw acceleration off

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Vladan Djeric (:vladan)]

There's very visible shaking during the rotation animation that happens when hovering the mouse cursor over this page's sidebar:

http://christianheilmann.com/2014/11/05/taking-a-break/

This was already fixed in bug 1078262 for Firefox 34 and Firefox 35, but Nightly 36 has regressed

Comment 1

[Loic]

I tested with the latest Nightly, I have the same behaviour as FF34/35.

Comment 2

[Markus Stange [:mstange]]

Vladan reproduced this on Windows.
I cannot reproduce this with a recent Nightly on Mac.

Comment 3

[Vladan Djeric (:vladan)]

It doesn't reproduce on my Windows machiens if hardware acceleration is enabled. Try turning it off via layers.acceleration.disabled

Comment 4

[Markus Stange [:mstange]]

I can reproduce this on Mac with hardware acceleration disabled.

Comment 5

[Vladan Djeric (:vladan)]

This bug is also present in earlier versions of Firefox. Firefox 34 & 35 are affected too, I originally tested with hardware acceleration enabled

Comment 6

[Markus Stange [:mstange]]

This looks to be another effect of fixed pixman precision; the precision loss happens in Matrix3DToPixman (resp. BasicLayerManager_Matrix3DToPixman). I've tested what happens if I change CompositorOGL::DrawQuad to put its aTransform parameter through pixman_transform_from_pixman_f_transform + pixman_f_transform_from_pixman_transform before using it, and doing so causes the same bug when OpenGL acceleration is enabled.

Jeff, any ideas?

Comment 7

[Markus Stange [:mstange]]

Attachment: part 1

Comment 8

[Markus Stange [:mstange]]

Attachment: part 2

Comment 9

[Markus Stange [:mstange]]

Attachment: part 3

Comment 10

[Markus Stange [:mstange]]

Attachment: part 2

removed stray period from comment

Comment 11

[Markus Stange [:mstange]]

Attachment: use Skia instead

This is much simpler and may even be faster.

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8524103 [details] [diff] [review]
use Skia instead

Review of attachment 8524103 [details] [diff] [review]:
-----------------------------------------------------------------

I like it.

Comment 13

[Markus Stange [:mstange]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=adcbf0ec972e

Comment 14

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0092a5e1467d

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/60c65a7eb0e8 for leaks and reftest failures:

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=4001580&repo=mozilla-inbound
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3999270&repo=mozilla-inbound
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=3997222&repo=mozilla-inbound

Comment 16

[Markus Stange [:mstange]]

Relanded with zero-initialized DataSourceSurface and SkBitmapDevice leak fix:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3cc235e310a5
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e9ee3a05567

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3cc235e310a5
https://hg.mozilla.org/mozilla-central/rev/1e9ee3a05567