1078455 - UITour: Add ability to highlight Dev. Tools and WebIDE toolbar buttons

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Holly Habstritt Gaal [:Habber]]

Add ability to highlight Dev Tools in chrome.


Use case at hand:
In the /firstrun experience for the developer edition browser, we will:
- highlight icon in toolbar (appears as default in toolbar for this build) 
- extend a doorhanger from the feature icon with a brief message describing feature. Doorhanger will also include 'not now' link and green CTA button from our standard UITour doorhanger template.


We will not open the feature itself for this /firstrun tour.

Possible future use cases could be highlighting feature from a snippet, product page, or future first-run tour.

Comment 1

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: highlight-buttons.patch

Added the ID's to the UITour's target, and modified the unit tests too to work with both m-c and gum.
This patch fixes also bug 1078454.

Matt, I set you as reviewer because you reviewed a similar patch for the loop button; but feel free to assign to anyone else if you think he/her fits more. Thanks!

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8512086 [details] [diff] [review]
highlight-buttons.patch

Review of attachment 8512086 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

jwalker asked me to push this to try, land it in fx-team and request Aurora approval.

Try:
https://tbpl.mozilla.org/?tree=Try&rev=dbcd50b2e929
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=dbcd50b2e929

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://hg.mozilla.org/integration/fx-team/rev/ea1cb099c537

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8512086 [details] [diff] [review]
highlight-buttons.patch

Approval Request Comment
[Feature/regressing bug #]:UI Tour
[User impact if declined]:No ability to highlight DevTools buttons in the UI tour
[Describe test coverage new/current, TBPL]: green on try
[Risks and why]: Very low risk
[String/UUID change made/needed]:None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ea1cb099c537

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/caaf56e6e947

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #5)
> https://hg.mozilla.org/integration/fx-team/rev/ea1cb099c537

In the future, you should probably be more careful about double-checking the commit information before pushing on somebody else's behalf.

And Matteo, you should probably make sure you have Mercurial properly configured to generate patches with the correct metadata included from the start :)
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 9

[Jennifer Bertsch [:jbertsch]]

When will we be able to view this in Gum?

Comment 10

[Panos Astithas (he/him) [:past] (please ni?)]

It is present on Gum now.

Comment 11

[Alex Gibson [:agibson]]

(In reply to Panos Astithas [:past] (overloaded, please needinfo) from comment #10)
> It is present on Gum now.

I don't see either "devtools" or "webide" when querying getConfiguration('availableTargets') in 35.0a2 (2014-11-03). Can someone please provide a link to the latest build so I can check again?

Comment 12

[Panos Astithas (he/him) [:past] (please ni?)]

I can see this on gum:

gum$ hg log -r caaf56e6e947
changeset:   225809:caaf56e6e947
user:        Matteo Ferretti <[e-mail]>
date:        Thu Oct 30 13:35:25 2014 +0000
summary:     Bug 1078455 - UITour: Add ability to highlight Dev. Tools and WebIDE toolbar buttons. r=MattN+bmo, a=lsblakk

I don't know why it doesn't seem to work though. You can find the latest builds at:

https://treeherder.mozilla.org/ui/#/jobs?repo=gum

Comment 13

[Matteo Ferretti [:zer0] [:matteo]]

I downloaded gum from the link provided by Panos, and I checked that that build has the patch:

jar:file:///Users/ZER0/Desktop/FirefoxDeveloperEditionDebug.app/Contents/Resources/browser/omni.ja!/modules/UITour.jsm

The patch also modified the unit test, that use `getConfiguration('availableTargets')`, so I'm pretty sure the method returns both `devtools` and `webide` (the last one if the pref is set):

http://mxr.mozilla.org/mozilla-central/source/browser/modules/test/browser_UITour_availableTargets.js#28

So I guess it should works with this build, Alex. But let me know if there are any issue.

Comment 14

[Alex Gibson [:agibson]]

Thanks Matteo,

When I download the latest build from http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/gum-macosx64/latest/ I see the targets as expected! Looks like this patch just landed :)

Oddly, the latest build comes up as Aurora for me (with the light UI and no dev branding). Not sure why, but that's unrelated to this bug.

Comment 15

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Alex Gibson [:agibson] from comment #14)
> When I download the latest build from
> http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/gum-macosx64/
> latest/ I see the targets as expected! Looks like this patch just landed :)

Unfortunately that URL does not contain the actual latest build (perhaps because there are some jobs still pending). You should download the one here:

http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/gum-macosx64/1415065657/

> Oddly, the latest build comes up as Aurora for me (with the light UI and no
> dev branding). Not sure why, but that's unrelated to this bug.

This is because that build didn't have all the necessary changes.