1078640 - "Couldn't load XPCOM" error when launching Firefox via ./firefox from Contents/MacOS in Terminal

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Stephen A Pohl [:spohl] (OOO until 6/12)]

BinaryPath.h fails to sanitize the path when a user launches Firefox as follows:
1. In Terminal, cd to Contents/MacOS
2. Run ./firefox

This is due to the fact that BinaryPath::Get does not sanitize the path on OSX. The returned path in this scenario would be:
Contents/MacOS/./firefox

XPCOMGlueLoad would then manipulate this path to find the dependentlibs.list file as follows:
1. Remove executable from path:    Contents/MacOS/.
2. Remove last path component:     Contents/MacOS
3. Add 'Resources' path component: Contents/MacOS/Resources

The resulting path should have been Contents/Resources. The above path will fail and result in a "Couldn't load XPCOM" error.

Comment 1

[Stephen A Pohl [:spohl] (OOO until 6/12)]

Note that this used to work before the v2 signature changes because all files were in the same directory (Contents/MacOS), so a path of Contents/MacOS/./dependentlibs.list used to work.

Comment 2

[Stephen A Pohl [:spohl] (OOO until 6/12)]

Attachment: Patch

Comment 3

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 8500601 [details] [diff] [review]
Patch

Looks fine to me.

Comment 4

[Stephen A Pohl [:spohl] (OOO until 6/12)]

https://hg.mozilla.org/projects/oak/rev/f4c31beca62b

Inbound and fx-team is currently closed. Setting checkin-needed just in case.

Comment 5

[Stephen A Pohl [:spohl] (OOO until 6/12)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5884c9f92f3d

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5884c9f92f3d

Comment 7

[Jean-Yves Avenard [:jya]]

This change introduced a serious regression for me, as now I can't start firefox at all. see bug 1079655

Comment 8

[Robert Strong (they/them - no direct email)]

Landed on aurora in the Mac V2 signing combined patch in bug 1047584