1079455 - keyboard doesn't go away after entering search on google maps

Status: VERIFIED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Not sure where this bug should go, but:

Sometime recently things regressed such that after typing a search in Google Maps, the keyboard won't go away.

Steps to reproduce:
 1. go to https://maps.google.com/ in the gaia browser
 2. click in the search field in the maps UI
 3. search for something and hit enter
 4. tap elsewhere in the map, pan, zoom, etc.

Actual results: keyboard never goes away

Expected results: keyboard should perhaps go awayafter hitting enter, and definitely after tapping elsewhere in the map

I'm using a master userdebug build from yesterday with gaia 83de447d9ae9a59459d7a445f9348a254c661850 and gecko eaa80e4597a2 (hg) plus my local patches.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Actually, I think step (3) has to be to type something and tap on one of the autocomplete entries; it works if I hit enter.

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Looks like a regression in input management.
I could see this with master but I cannot reproduce this in v2.1, so set the QAwanted to check each branch first.

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

Confirmed that this issue still occurs on latest Flame 2.2. Searching on Google Maps by tapping on a suggested term generated by Google Maps causes the keyboard to stay on screen after the search.

The keyboard can only be hidden by going to another screen such as return to Homescreen then back, or tapping on URL bar to initiate a search and cancel. Note that using edge gesture or card view/task manager to go to another app does NOT hide the keyboard.

Repro rate: 7/7

Device: Flame 2.2 Master (shallow flash, 319MB mem)
BuildID: 20141017073248
Gaia: 1daf2dadcd0d554c733661a4c0be1b82001e9da0
Gecko: 51892b39597a
Version: 36.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

----------------

This issue does NOT occur on Flame 2.1 and Flame 2.0.

Tapping on suggested term on Google Maps does NOT cause the keyboard to stay on screen. Repro rate: 0/5 on v2.1, 0/4 on v2.0.

Device: Flame 2.1 (shallow flash, 319MB mem)
BuildID: 20141017113650
Gaia: b9c540142d60eda49541164f17d27e16a6af2c87
Gecko: 3fec5b285061
Version: 34.0 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.0 (shallow flash, 319MB mem)
BuildID: 20141016184643
Gaia: 9c7dec14e058efef81f2267b724dad0850fc07e4
Gecko: c17df9fe087d
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Can we try to get a regression window on v2.2?
Thanks.

Comment 5

[Chris Kreinbring [:CKreinbring]]

Regression window
Last working
BuildID: 20140905085538
Gaia: 5765c62163bcb7fde5ebfd211881117de31a7c46
Gecko: 6bfdd45d8318
Platform Version: 35.0a1
Firmware Version: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

First broken
BuildID: 20140905090738
Gaia: 0de5fcdc11a15abdf8d64f28bed2abb30041ea4d
Gecko: 0d962e459db5
Platform Version: 35.0a1
Firmware Version: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Working Gaia / Broken Gecko = Repro
Gaia: 5765c62163bcb7fde5ebfd211881117de31a7c46
Gecko: 0d962e459db5
Broken Gaia / Working Gecko = No repro
Gaia: 0de5fcdc11a15abdf8d64f28bed2abb30041ea4d
Gecko: 6bfdd45d8318
Gecko pushlog: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6bfdd45d8318&tochange=0d962e459db5


B2G Inbound
Last working
BuildID: 20140905062812
Gaia: 04bfb7cab6a5485b650dac75cf99b8509ae148fc
Gecko: 6aa95efb9322
Platform Version: 35.0a1
Firmware Version: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

First broken
BuildID: 20140905063113
Gaia: 04bfb7cab6a5485b650dac75cf99b8509ae148fc
Gecko: 0bb6b880744e
Platform Version: 35.0a1
Firmware Version: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Working Gaia / Broken Gecko = Repro
Gaia: 04bfb7cab6a5485b650dac75cf99b8509ae148fc
Gecko: 0bb6b880744e
Broken Gaia / Working Gecko = No repro
Gaia: 04bfb7cab6a5485b650dac75cf99b8509ae148fc
Gecko: 6aa95efb9322
Gecko pushlog: http://hg.mozilla.org/integration/b2g-inbound/pushloghtml?fromchange=6aa95efb9322&tochange=0bb6b880744e

Comment 6

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Issue seems to have been caused by bug 1029943.  NI? Morris and Ting to get their opinion since they were the ones who worked on that issue.

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Patches for bug 1029943 were backout on master. It shouldn't cause this bug.
https://bugzilla.mozilla.org/show_bug.cgi?id=1029943#c34

BTW, when the keyboard persists, tapping the space key does not hide the keyboard either.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Probably bug 1057898. I will try to reproduce or revert to confirm this.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This does not happen on my Flame. Must be fixed by other patches.

Flame v188 2.2 OTA build id 20141022160207

qawanted to confirm, please close as WORKSFORME if this no longer reproduces.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Alternative STR that could reproduce:

Steps to reproduce:
 1. go to https://maps.google.com/ in the gaia browser
 2. click in the search field in the maps UI
 3. search for something and __tap one of the suggestions in the map app__

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #10)
> Alternative STR that could reproduce:
> 
> Steps to reproduce:
>  1. go to https://maps.google.com/ in the gaia browser
>  2. click in the search field in the maps UI
>  3. search for something and __tap one of the suggestions in the map app__

I found the root cause and it's almost an edge case. So when the user touch the suggestion, Google Maps will 1) first take the focus back, 2) edit the value, and 3) blur the input, all in a sync function. In bug 1057898 we move (1) and (3) to the next tick, and they cancel out so no message will be sent out of forms.js. However (2) does not aware of that and thus send a message on the change in value of the input.

I have a one liner ready and I will provide a mochitest with it.

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Patch v1.0

One-liner, simply check isHandlingFocus.

Test is verified by running w/ the change and w/o the change.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=f7eebba08901

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Patch for commit

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3f7572fe0a6

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b3f7572fe0a6

Comment 16

[sarsenyev]

Verified the issue is fixed on Master 2.2 Flame.

Keyboard disappears after search result in Google maps.

"Flame 2.2

Device: Flame 2.2 (319mb)(Kitkat Base)(Shallow Flash)
BuildID: 20141120040205
Gaia: 1abe09b4925547699dfdb2d358aed019137c3aa6
Gecko: 6ce1b906c690
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0"

Comment 17

[bhavana bajaj [:bajaj]]

Clearing the blocking nom for 2.2? as this is already fixed/verified on that branch per the status flag