1079532 - [traceback] TypeError: list indices must be integers, not unicode on www-dev.allizom.org

Status: VERIFIED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Product Delivery, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://www-dev.allizom.org/en-US/ throws:

Traceback (most recent call last):
File "/usr/lib64/python2.6/site-packages/newrelic-2.16.0.12/newrelic/hooks/framework_django.py", line 492, in wrapper return wrapped(*args, **kwargs)
File "/data/www/www-dev.allizom.org-django/bedrock/vendor/lib/python/django/views/generic/base.py", line 68, in view return self.dispatch(request, *args, **kwargs)
File "/usr/lib64/python2.6/site-packages/newrelic-2.16.0.12/newrelic/hooks/framework_django.py", line 829, in wrapper return wrapped(*args, **kwargs)
File "/data/www/www-dev.allizom.org-django/bedrock/vendor/lib/python/django/views/generic/base.py", line 86, in dispatch return handler(request, *args, **kwargs)
File "/data/www/www-dev.allizom.org-django/bedrock/vendor/lib/python/django/views/generic/base.py", line 154, in get return self.render_to_response(context)
File "/data/www/www-dev.allizom.org-django/bedrock/bedrock/mozorg/views.py", line 269, in render_to_response **response_kwargs)
File "/data/www/www-dev.allizom.org-django/bedrock/lib/l10n_utils/__init__.py", line 75, in render return django_render(request, template, context, **kwargs)
File "/data/www/www-dev.allizom.org-django/bedrock/vendor/lib/python/django/shortcuts/__init__.py", line 53, in render return HttpResponse(loader.render_to_string(*args, **kwargs),
File "/data/www/www-dev.allizom.org-django/bedrock/vendor/lib/python/django/template/loader.py", line 177, in render_to_string return t.render(context_instance)
File "/data/www/www-dev.allizom.org-django/bedrock/vendor/src/jingo/jingo/__init__.py", line 195, in render return super(Template, self).render(context_dict)
File "/usr/lib64/python2.6/site-packages/newrelic-2.16.0.12/newrelic/api/function_trace.py", line 89, in dynamic_wrapper return wrapped(*args, **kwargs)
File "/usr/lib64/python2.6/site-packages/jinja2/environment.py", line 891, in render return self.environment.handle_exception(exc_info, True)
File "/data/www/www-dev.allizom.org-django/bedrock/bedrock/mozorg/templates/mozorg/home.html", line 9, in top-level template code {% from 'macros.html' import facebook_share_url, twitter_share_url %}
File "/data/www/www-dev.allizom.org-django/bedrock/bedrock/mozorg/templates/mozorg/base-resp.html", line 5, in top-level template code {% extends "base-resp.html" %}
File "/data/www/www-dev.allizom.org-django/bedrock/bedrock/base/templates/base-resp.html", line 134, in top-level template code {% block content %}{% endblock %}
File "/data/www/www-dev.allizom.org-django/bedrock/bedrock/mozorg/templates/mozorg/home.html", line 236, in block "content" {{ download_firefox(small=True, icon=False) }}
File "/data/www/www-dev.allizom.org-django/bedrock/bedrock/mozorg/helpers/download_buttons.py", line 192, in download_firefox l_version = latest_version(locale, build)
File "/data/www/www-dev.allizom.org-django/bedrock/bedrock/mozorg/helpers/download_buttons.py", line 54, in latest_version _builds = builds[locale][version]
TypeError: list indices must be integers, not unicode

Here's New Relic: https://rpm.newrelic.com/accounts/263620/applications/2634040/traced_errors/2334630200

Comment 1

[Josh Mize [:jgmize]]

This error is the result of the changes in bug 1079304, but those changes were reverted, and once reverted we were able to resolve the issue in the staging environment by doing a chief push, but the dev environment is not on chief so I believe will need to be fixed manually by someone in webops.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to Josh Mize [:jgmize] from comment #1)
> This error is the result of the changes in bug 1079304, but those changes
> were reverted, and once reverted we were able to resolve the issue in the
> staging environment by doing a chief push, but the dev environment is not on
> chief so I believe will need to be fixed manually by someone in webops.

Is there a long-term bug for Chief-on-dev?  This being a limitation for the foreseeable future is undesired, to say the least :-(

Comment 3

[Josh Mize [:jgmize]]

(In reply to Stephen Donner [:stephend] from comment #2)
> (In reply to Josh Mize [:jgmize] from comment #1)
> > This error is the result of the changes in bug 1079304, but those changes
> > were reverted, and once reverted we were able to resolve the issue in the
> > staging environment by doing a chief push, but the dev environment is not on
> > chief so I believe will need to be fixed manually by someone in webops.
> 
> Is there a long-term bug for Chief-on-dev?  This being a limitation for the
> foreseeable future is undesired, to say the least :-(

Yes: bug 917600

Comment 4

[Jake Maul [:jakem]]

New Relic looks clean now, as of around 23:00 PT yesterday.


As for dev updating, I'm confused... it auto updates. Was the code not actually changed, just deployed an older commit hash to stage?

If so, then there's really no way we can fix dev (in the future, since it seems okay now based on NR)... we can theoretically deploy an older version, but it would just auto-update to the latest revision again.

Comment 5

[Josh Mize [:jgmize]]

(In reply to Jake Maul [:jakem] from comment #4)
> New Relic looks clean now, as of around 23:00 PT yesterday.
> 
> 
> As for dev updating, I'm confused... it auto updates. Was the code not
> actually changed, just deployed an older commit hash to stage?
> 
> If so, then there's really no way we can fix dev (in the future, since it
> seems okay now based on NR)... we can theoretically deploy an older version,
> but it would just auto-update to the latest revision again.

:jakem www-dev had that error for several hours after https://bugzilla.mozilla.org/show_bug.cgi?id=1079304#c6, but I was under the impression the dev auto-update happened every 15 minutes, which is why I suggested manual intervention was necessary. Is the product-details update on a different schedule?

Comment 6

[Jake Maul [:jakem]]

-dev PHP and django are both updated every 10min... the django update includes product-details. Additionally, django locales are updated every 15min.

In any case, recent work around crons and dev auto-updating probably moots any concern here. dev now has chief (thanks to cturra) and crons are shortly moving into the bedrock repo for more direct control.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://www-dev.allizom.org/en-US/