Closed Bug 1079680 Opened 6 years ago Closed 3 years ago

Add volume icons for Settings app

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: arnau, Unassigned)

References

Details

Attachments

(2 files)

No description provided.
Assignee: nobody → rnowmrch
Comment on attachment 8501546 [details] [review]
patch for gaia-icons

SUGGESTED CHANGES

- Rename 'volume-alarm' -> 'alarm-clock'
- Rename 'volume-ringer' -> 'call-ringing'
- Increase white-space around 'alarm-clock' icon to at least 10%. Currently too tight against canvas edge.
Attachment #8501546 - Flags: review?(wilsonpage)
Comment on attachment 8501546 [details] [review]
patch for gaia-icons

Changed names as suggested.
About the size of the icons, they are ok as UX provides them :)
If you check other icons like 'wallpaper' or 'unlock', they are as large as 'alarm-clock'.
Attachment #8501546 - Flags: review?(wilsonpage)
(In reply to Arnau March  [:arnau] from comment #3)
> Comment on attachment 8501546 [details] [review]
> patch for gaia-icons
> 
> Changed names as suggested.
> About the size of the icons, they are ok as UX provides them :)
> If you check other icons like 'wallpaper' or 'unlock', they are as large as
> 'alarm-clock'.

I would like the white-space to be consistent throughout the icon-set. This means that we are able to switch icons around easily. Icons shouldn't be sized for one specific case. I know that some icons in the set are not following this rule, but they should.

Am I missing something, is this a bad idea?
Flags: needinfo?(rnowmrch)
30x30px is the limit the icon should not exceed.
Have in mind that box will have paddings i.e when applied in button.
I don't see an issue here.
Flags: needinfo?(rnowmrch)
Comment on attachment 8501546 [details] [review]
patch for gaia-icons

LANDED (gaia-icons:master) https://github.com/gaia-components/gaia-icons/commit/850a7656e544ad9496fc809c2f73704b5b5000e5
Attachment #8501546 - Flags: review?(wilsonpage) → review+
Attached file pull-request (master)
Attachment #8503064 - Flags: review?(rnowmrch)
Comment on attachment 8503064 [details] [review]
pull-request (master)

Looks great!
Thanks for this PR ;)
Attachment #8503064 - Flags: review?(rnowmrch) → review+
Assignee: rnowmrch → nobody
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.