1079680 - Add volume icons for Settings app

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, defect)

Comment 1

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch for gaia-icons

Comment 2

[Wilson Page [:wilsonpage]]

Comment on attachment 8501546 [details] [review]
patch for gaia-icons

SUGGESTED CHANGES

- Rename 'volume-alarm' -> 'alarm-clock'
- Rename 'volume-ringer' -> 'call-ringing'
- Increase white-space around 'alarm-clock' icon to at least 10%. Currently too tight against canvas edge.

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8501546 [details] [review]
patch for gaia-icons

Changed names as suggested.
About the size of the icons, they are ok as UX provides them :)
If you check other icons like 'wallpaper' or 'unlock', they are as large as 'alarm-clock'.

Comment 4

[Wilson Page [:wilsonpage]]

(In reply to Arnau March  [:arnau] from comment #3)
> Comment on attachment 8501546 [details] [review]
> patch for gaia-icons
> 
> Changed names as suggested.
> About the size of the icons, they are ok as UX provides them :)
> If you check other icons like 'wallpaper' or 'unlock', they are as large as
> 'alarm-clock'.

I would like the white-space to be consistent throughout the icon-set. This means that we are able to switch icons around easily. Icons shouldn't be sized for one specific case. I know that some icons in the set are not following this rule, but they should.

Am I missing something, is this a bad idea?

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

30x30px is the limit the icon should not exceed.
Have in mind that box will have paddings i.e when applied in button.
I don't see an issue here.

Comment 6

[Wilson Page [:wilsonpage]]

Comment on attachment 8501546 [details] [review]
patch for gaia-icons

LANDED (gaia-icons:master) https://github.com/gaia-components/gaia-icons/commit/850a7656e544ad9496fc809c2f73704b5b5000e5

Comment 7

[Wilson Page [:wilsonpage]]

Released gaia-icons#0.7.2 https://github.com/gaia-components/gaia-icons/releases/tag/v0.7.2

Comment 8

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 9

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8503064 [details] [review]
pull-request (master)

Looks great!
Thanks for this PR ;)

Comment 10

[BMO Automation]

Firefox OS is not being worked on