[Settings] Unify HTML mark style in Display and Sound panels

RESOLVED FIXED

Status

Firefox OS
Gaia::Settings
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mancas, Assigned: mancas)

Tracking

(Depends on: 1 bug, {regression})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments)

(Assignee)

Description

3 years ago
We should include the sound icons to the gaia-icons repo and use them instead of background images as we currently do in Display panel.

Expected HTML:

<label class="range-icons">
    <span data-icon="volume-media-sound"></span>
    <input type="range" step="1" min="0" value="8" max="15">
</label>
(Assignee)

Updated

3 years ago
Assignee: nobody → b.mcb

Comment 1

3 years ago
Hi Manuel,
I'm not handling Setting right now. 
I can help you pin to the person who's taking care of Settingm but I need more clue about it.
Do you have screenshots or anything to explain what this is about?
Thanks!
Flags: needinfo?(b.mcb)
(Assignee)

Comment 2

3 years ago
Created attachment 8499387 [details]
icons-sound-panel.png

Hi Carol,

The aim here is to have the same HTML structure as we use in Display Panel (see icons in attachment: icons-display-panel.png). The icons you see in the display panel are added in the gaia-icons font. However, the other ones you see in sound panel (see attachment:icons-sound-panel.png) are not included.

So I need the svg files of these icons to be included in the gaia-icons font repository and then I will take care of changing the HTML structure.

I hope it will be helpful
Flags: needinfo?(b.mcb) → needinfo?(chuang)
(Assignee)

Comment 3

3 years ago
Created attachment 8499389 [details]
icons-display-panel.png

Comment 4

3 years ago
Hi Helen,
Please provide the files that Manuel needs, thank you!
Flags: needinfo?(chuang) → needinfo?(hhuang)
Created attachment 8500268 [details]
SVGs.zip

Update 'ringer-volume' and 'alarm-volume' icons in SVG format, besides, I found we already have 'sound-max' icon in Gaia-icon that can be used for media volume.
Flags: needinfo?(hhuang)
(Assignee)

Updated

3 years ago
Depends on: 1079680
(Assignee)

Comment 6

3 years ago
Created attachment 8511872 [details] [review]
Patch
Attachment #8511872 - Flags: review?(arthur.chen)
(Assignee)

Comment 7

3 years ago
Created attachment 8511887 [details]
sound-panel.png
Attachment #8511887 - Flags: ui-review?(echang)
Attachment #8511887 - Flags: ui-review?(echang) → ui-review+
Comment on attachment 8511872 [details] [review]
Patch

Looks good to me! Could you also remove the image files as they are no longer used? Thanks.
Attachment #8511872 - Flags: review?(arthur.chen)
(Assignee)

Comment 9

3 years ago
Comment on attachment 8511872 [details] [review]
Patch

I've deleted the images. Please, could you check that everything it's ok?
Thanks!
Attachment #8511872 - Flags: review?(arthur.chen)
Comment on attachment 8511872 [details] [review]
Patch

r=me, thank you!
Attachment #8511872 - Flags: review?(arthur.chen) → review+
master: 1f1745c6309c199c9f0ff4b17eb1a55a1f40ee96
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

3 years ago
Depends on: 1100689
You need to log in before you can comment on or make changes to this bug.