bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

~10M AWSY regression on Sept 30

RESOLVED FIXED

Status

()

Core
Networking
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Swatinem, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox34 unaffected, firefox35+ fixed, firefox36+ fixed)

Details

(Whiteboard: [MemShrink:P1][awsy+][awsy-])

(Reporter)

Description

4 years ago
AWSY shows a ~10M regression in the upper "explicit" measurements and in the "heap-unclassified" category.
The "resident" measurement is also up some, but they are very noisy.
Whiteboard: [MemShrink]
Whiteboard: [MemShrink] → [MemShrink:P1]
[Tracking Requested - why for this release]: This is a large regression in memory usage.
status-firefox34: --- → unaffected
status-firefox35: --- → affected
status-firefox36: --- → affected
tracking-firefox35: --- → ?
Drilling down into the heap-unclassified line in the "Miscellaneous Measurements" graph, it's pretty clear that these are the relevant changes:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=946948bfc6a3&tochange=6122db43cad3

So it is bug 1002855. mccr8 backed out a related patch, involving resource timings, in bug 1064706, that was showing up as leaking on e10s builds. He also said that he didn't understand why it was only manifesting on e10s runs; perhaps this is how it was manifesting.
Blocks: 1002855
Component: Untriaged → Networking
tracking-firefox35: ? → +
tracking-firefox36: --- → +
I landed bug 1064706, and now we no longer hold refs to the channel in nsPerformanceTiming.
It will be interesting to see how it affects this regression.
> I landed bug 1064706, and now we no longer hold refs to the channel in
> nsPerformanceTiming.
> It will be interesting to see how it affects this regression.

I see a clear decrease in the "explicit" and "heap-unclassified" measurements. The size of the decrease is sufficiently close to the original increase that I'm happy to declare victory :)

Thank you for the fix.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
status-firefox35: affected → fixed
status-firefox36: affected → fixed
Blocks: 1120576
I added annotations to AWSY for this.
Whiteboard: [MemShrink:P1] → [MemShrink:P1][awsy+][awsy-]
You need to log in before you can comment on or make changes to this bug.