1079791 - [STK] After clicking the home button, the STK menu doesn't get closed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alberto Pastor [:albertopq]]

STR:

1.- Go to Settings
2.- Go to the STK menu (you'll need a SIM with STK)
3.- This step depends on the menus, but access any menu which displays a STK dialog (with ok and cancel buttons, for example)
4.- Press Home button

Expected:

The STK dialog gets closed with settings

Actual

The STK dialog is still visible, but the background goes to the homescreen

Comment 1

[Alberto Pastor [:albertopq]]

[Blocking Requested - why for this release]: Not sure if STK is a priority for this release, but the UX looks pretty odd.

Comment 2

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25030

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8503165 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25030

Sorry, I'm not completely comfortable reviewing thing, but the changes look reasonable to me. Let's have :kgrandon also take a look.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8503165 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25030

This looks good to me. Thanks!

Comment 5

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/c26f89f8edcfbad4eab351ee6ec8adcc9eed4e21

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8503165 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25030

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Probably always broken.

[User impact] if declined:
Users will not be able to close STK dialog easily (i.e. using the home button).

[Testing completed]:
Test manually by dev, unit tests added.

[Risk to taking this patch] (and alternatives if risky):
Low risk, the code is pretty compartmentalized to the STK.

[String changes made]: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/47737ca5639fd42db639a3bf3e5ef5f953449e6f

Comment 8

[Alberto Pastor [:albertopq]]

Not sure how easily can we test STK on marionette... Kevin?

Comment 9

[Kevin Grandon :kgrandon]

(In reply to Alberto Pastor [:albertopq] from comment #8)
> Not sure how easily can we test STK on marionette... Kevin?

I think right now our best bet is to mock the lower-level APIs needed for this. TBH I'm not 100% familiar with STK, so I don't know exactly what APIs we would need to mock. Would mocking mozMobileConnections help here? Settings does a good job of this, see: https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/test/marionette/mocks/mock_navigator_moz_mobile_connections_multi.js

Comment 10

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame v2.1.MP4

This issue has been verified successfully on Flame 2.1.
See attachment: Verify_Video_Flame v2.1.MP4
Reproducing rate: 0/10

Flame v2.1 version:
Gaia-Rev        afdfa629be209dd53a1b7b6d6c95eab7077ffcd9
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/dc3018cbdbe6
Build-ID        20141123001201
Version         34.0

Comment 11

[Shine(Leave from Mozilla)]

Attachment: 2.2_video.3gp

Hi Ryan,
I have verified this problem on Flame 2.2 and N5 2.2 with CU/CMCC SIM card inserted. Now the behaviour is that when i press Home button to go back to Homescreen, the STK dialog will be closed successfully, but after a while, it will pop up again. I'm not sure whether this behavior is correct or not. Could you please have a look?
Many thanks!
Please see attachment: 2.2_video.3gp

Device information:
Flame v2.2 Build ID: 20150624162504
N5 v2.2 Build ID: 20150624162504

Comment 12

[Ryan VanderMeulen [:RyanVM]]

That's a question for the bug assignee, not myself.

Comment 13

[Alberto Pastor [:albertopq]]

I would say that is a different bug (different priority, at least). Could you please create a new bug for tracking this? Thanks!

Comment 14

[Shine(Leave from Mozilla)]

Thanks Ryan & Alberto.
I have submitted a new bug, please see bug 1177674.