1080088 - Fix browser_mozpay.js regression

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect, P2)

Description

[Marco Castelluccio [:marco]]

I can't reproduce this failure reliably, so it's difficult to tell when it regressed.
The error I see is: uncaught exception - TypeError: win.document.getElementById(...) is null at chrome://mochitests/content/webapprtChrome/webapprt/test/chrome/browser_mozpay.js:46

Comment 1

[Marco Castelluccio [:marco]]

I also see:
JavaScript error: https://example.com/webapprtChrome/webapprt/test/chrome/mozpay-success.html?req=eyJhbGciOiAiSFMyNTYiLCAidHlwIjogIkpXVCJ9.eyJhdWQiOiAibW9ja3BheXByb3ZpZGVyLnBocGZvZ2FwcC5jb20iLCAiaXNzIjogIkVudGVyIHlvdSBhcHAga2V5IGhlcmUhIiwgInJlcXVlc3QiOiB7Im5hbWUiOiAiUGllY2Ugb2YgQ2FrZSIsICJwcmljZSI6ICIxMC41MCIsICJwcmljZVRpZXIiOiAxLCAicHJvZHVjdGRhdGEiOiAidHJhbnNhY3Rpb25faWQ9ODYiLCAiY3VycmVuY3lDb2RlIjogIlVTRCIsICJkZXNjcmlwdGlvbiI6ICJWaXJ0dWFsIGNob2NvbGF0ZSBjYWtlIHRvIGZpbGwgeW91ciB2aXJ0dWFsIHR1bW15In0sICJleHAiOiAxMzUyMjMyNzkyLCAiaWF0IjogMTM1MjIyOTE5MiwgInR5cCI6ICJtb2NrL3BheW1lbnRzL2luYXBwL3YxIn0.QZxc62USCy4UIyKIC1TKelVhNklvk-Ou1l_daKntaFI, line 8: Error: Exposing privileged or cross-origin callable is prohibited

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: disable broken mozPay implementation in desktop runtime

While we figure out if we want to fix the API or remove it (bug 1134007), at the very least we shouldn't leave the old, broken implementation enabled, so here's a change that disables it and updates its test to check that it's disabled.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

This shouldn't affect any tests that run in continuous integration, but here's a try run for mochitest-other on the off chance that there's a toolkit/webapps/ test affected by this change:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=124f3ddbffc7

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb0f0100d587

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bb0f0100d587