Closed Bug 1080094 Opened 5 years ago Closed 5 years ago

Google import fails if a contact contains an org but no title

Categories

(Hello (Loop) :: Client, defect)

defect
Not set

Tracking

(firefox34 verified, firefox35 verified)

VERIFIED FIXED
mozilla35
Iteration:
35.3
Tracking Status
firefox34 --- verified
firefox35 --- verified

People

(Reporter: abr, Assigned: abr)

Details

(Whiteboard: [loop-uplift])

Attachments

(1 file)

An attempt to import a contact with an organization (company) name but no
title (or vice-versa) causes the import to fail:

*************************
A coding exception was thrown and uncaught in a Task.

Full message: TypeError: orgNode.getElementsByTagNameNS(...)[0] is undefined
Full stack: this.GoogleImporter.prototype._processContactFields@resource:///modules/loop/GoogleImporter.jsm:465:31
this.GoogleImporter.prototype._processContacts<@resource:///modules/loop/GoogleImporter.jsm:362:21
TaskImpl_run@resource://gre/modules/Task.jsm:314:40
TaskImpl@resource://gre/modules/Task.jsm:275:3
createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
this.GoogleImporter.prototype.startImport/<@resource:///modules/loop/GoogleImporter.jsm:172:41
TaskImpl_run@resource://gre/modules/Task.jsm:314:40
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:865:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:7

*************************
Check for presence of org and title nodes before attempting to operate on them
Attachment #8501992 - Flags: review?(mdeboer)
Whiteboard: [loop-uplift]
Comment on attachment 8501992 [details] [diff] [review]
Check for presence of org and title nodes before attempting to operate on them

Review of attachment 8501992 [details] [diff] [review]:
-----------------------------------------------------------------

r+ conditional on filing another bug so that we remember to massage this data back if/when we some day decide to implement export or sync (eg with fxa).
Attachment #8501992 - Flags: review?(mdeboer) → review+
(In reply to Dan Mosedale (:dmose) - not reading bugmail; needinfo? for response from comment #2)
> r+ conditional on filing another bug so that we remember to massage this
> data back if/when we some day decide to implement export or sync (eg with
> fxa).

Filed bug 1080129.

Will land this patch when the tree reopens.
Flagged for verification since this should be easy enough.
Flags: qe-verify+
https://hg.mozilla.org/mozilla-central/rev/55f51041dd81
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Paul, assuming you get a new Nightly build in time, can you please verify this?
Flags: needinfo?(paul.silaghi)
Comment on attachment 8501992 [details] [diff] [review]
Check for presence of org and title nodes before attempting to operate on them

Approval Request Comment
Part of the staged Loop aurora second uplift set
Attachment #8501992 - Flags: approval-mozilla-aurora?
Depends on: 1081130
Verified fixed 35.0a1 (2014-10-10) Win 7, Ubuntu 13.04, OS X 10.9.5
Status: RESOLVED → VERIFIED
No longer depends on: 1081130
Flags: needinfo?(paul.silaghi)
Flags: needinfo?(paul.silaghi)
Verified fixed FF 34b1 Win 7
Flags: needinfo?(paul.silaghi)
Comment on attachment 8501992 [details] [diff] [review]
Check for presence of org and title nodes before attempting to operate on them

Post landed approval (already landed)
Attachment #8501992 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Iteration: --- → 35.3
You need to log in before you can comment on or make changes to this bug.