1080094 - Google import fails if a contact contains an org but no title

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[Adam Roach [:abr]]

An attempt to import a contact with an organization (company) name but no
title (or vice-versa) causes the import to fail:

*************************
A coding exception was thrown and uncaught in a Task.

Full message: TypeError: orgNode.getElementsByTagNameNS(...)[0] is undefined
Full stack: this.GoogleImporter.prototype._processContactFields@resource:///modules/loop/GoogleImporter.jsm:465:31
this.GoogleImporter.prototype._processContacts<@resource:///modules/loop/GoogleImporter.jsm:362:21
TaskImpl_run@resource://gre/modules/Task.jsm:314:40
TaskImpl@resource://gre/modules/Task.jsm:275:3
createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14
this.GoogleImporter.prototype.startImport/<@resource:///modules/loop/GoogleImporter.jsm:172:41
TaskImpl_run@resource://gre/modules/Task.jsm:314:40
Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:865:23
this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:7

*************************

Comment 1

[Adam Roach [:abr]]

Attachment: Check for presence of org and title nodes before attempting to operate on them

Check for presence of org and title nodes before attempting to operate on them

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8501992 [details] [diff] [review]
Check for presence of org and title nodes before attempting to operate on them

Review of attachment 8501992 [details] [diff] [review]:
-----------------------------------------------------------------

r+ conditional on filing another bug so that we remember to massage this data back if/when we some day decide to implement export or sync (eg with fxa).

Comment 3

[Adam Roach [:abr]]

(In reply to Dan Mosedale (:dmose) - not reading bugmail; needinfo? for response from comment #2)
> r+ conditional on filing another bug so that we remember to massage this
> data back if/when we some day decide to implement export or sync (eg with
> fxa).

Filed bug 1080129.

Will land this patch when the tree reopens.

Comment 4

[u279076]

Flagged for verification since this should be easy enough.

Comment 5

[Adam Roach [:abr]]

https://hg.mozilla.org/integration/fx-team/rev/55f51041dd81

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/55f51041dd81

Comment 7

[u279076]

Paul, assuming you get a new Nightly build in time, can you please verify this?

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8501992 [details] [diff] [review]
Check for presence of org and title nodes before attempting to operate on them

Approval Request Comment
Part of the staged Loop aurora second uplift set

Comment 9

[Paul Silaghi, QA [:pauly]]

Verified fixed 35.0a1 (2014-10-10) Win 7, Ubuntu 13.04, OS X 10.9.5

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1e6b41a8f355

Comment 11

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 34b1 Win 7

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8501992 [details] [diff] [review]
Check for presence of org and title nodes before attempting to operate on them

Post landed approval (already landed)