1081130 - Google contacts with phone number but no email are not imported

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect)

Description

[Paul Silaghi, QA [:pauly]]

35.0a1 (2014-10-10)
The following contacts are not imported:
- with only name
- with name, organization but no title job
- with only organization

There may be other cases.

Comment 1

[Paul Silaghi, QA [:pauly]]

- with only phone number

Comment 2

[Adam Roach [:abr]]

To be clear, the intended design here is that contacts are imported only if they contain at least one email address and/or at least one phone number. So the situation described in comment 0 is simply the importer working as designed. The issue in comment 1 is a defect that should be fixed.

This is called out in the review in Bug 1069816 comment 8.

Comment 3

[Mike de Boer [:mikedeboer]]

Taking this to investigate further.

Comment 4

[Paul Silaghi, QA [:pauly]]

(In reply to Paul Silaghi, QA [:pauly] from comment #1)
> - with only phone number
Note that the problem is with a contact having just the phone number without any other details (name etc).
The import button in the Loop panel remains stuck on 'Importing' until the browser is restarted.

Comment 5

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: fix importing contacts with only a phone number and fetch the correct format

Comment 6

[Adam Roach [:abr]]

Comment on attachment 8503219 [details] [diff] [review]
Patch v1: fix importing contacts with only a phone number and fetch the correct format

Review of attachment 8503219 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 7

[Mike de Boer [:mikedeboer]]

Pushed to fx-team as https://hg.mozilla.org/integration/fx-team/rev/87136846a6c8

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/87136846a6c8

Comment 9

[Maire Reavy [:mreavy]]

Pauly, can you verify this when you get a chance?  Thanks!

Comment 10

[Mike de Boer [:mikedeboer]]

Comment on attachment 8503219 [details] [diff] [review]
Patch v1: fix importing contacts with only a phone number and fetch the correct format

Approval Request Comment
[Feature/regressing bug #]: bug 1069816
[User impact if declined]: User will not see their Google contacts imported that have only a phone number listed and no email address. On top of that, the wrong phone number format will be imported, which is not future-compatible for Loop/ Hello mobile interop.
[Describe test coverage new/current, TBPL]: landed on m-c, tests pass and covered.
[Risks and why]: minor.
[String/UUID change made/needed]: n/a.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/73ad3cc88861
https://hg.mozilla.org/releases/mozilla-beta/rev/1f7f807b6362

Comment 12

[Maire Reavy [:mreavy]]

Pauly -- can you verify this as soon as possible?  This got uplifted before verification -- though I do want this fix in Beta.

Comment 13

[Paul Silaghi, QA [:pauly]]

Something is still wrong - after import, the button remains stuck on 'importing...'
Browser console log:
"1413548703318	Loop.Importer.Google	ERROR	resource://app/modules/loop/MozLoopAPI.jsm:80: Encountered unsupported value type writing stack-scoped structured clone Log.jsm:749"

Comment 14

[Paul Silaghi, QA [:pauly]]

I'm marking this bug verified on 36.0a1 (2014-10-17) since the import of a standard phone format works fine.
The work continues in the follow-up bug 1084384.

Comment 15

[u279076]

Paul, can you please verify this is fixed in the latest Aurora and Beta builds?

Comment 16

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 34b2, 35.0a2 (2014-10-23) OS X 10.9.5