Closed
Bug 1080134
Opened 10 years ago
Closed 10 years ago
Disable win8-32 testing and enable win8-64 testing
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: catlee, Unassigned)
References
Details
Attachments
(7 files)
7.37 KB,
patch
|
rail
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
989 bytes,
patch
|
rail
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
989 bytes,
patch
|
rail
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
1.10 KB,
patch
|
rail
:
review+
catlee
:
checked-in+
|
Details | Diff | Splinter Review |
1021 bytes,
patch
|
catlee
:
review+
RyanVM
:
feedback+
armenzg
:
checked-in+
|
Details | Diff | Splinter Review |
22.67 KB,
patch
|
bhearsum
:
review+
jmaher
:
review+
|
Details | Diff | Splinter Review |
2.17 KB,
patch
|
bhearsum
:
review+
|
Details | Diff | Splinter Review |
In order to have enough testing capacity for 64-bit windows, we need to disable some existing tests. The best option we have right now is to disable 32-bit win8 tests. We can then use the win8 machines for testing 64-bit windows builds on trunk branches. We'll need to keep release branches with 32-bit win8 tests enabled for the meanwhile.
Reporter | ||
Comment 1•10 years ago
|
||
step 1 - let's get date close to what we want the rest of the branches to look like. Builders added: + win8_64 date talos chromez + win8_64 date talos dromaeojs + win8_64 date talos g1 + win8_64 date talos other_nol64 + win8_64 date talos svgr + win8_64 date talos tp5o Builders removed - win64_vm date debug test cppunit - win64_vm date debug test crashtest - win64_vm date debug test jetpack - win64_vm date debug test jittest - win64_vm date debug test jsreftest - win64_vm date debug test mochitest-1 - win64_vm date debug test mochitest-2 - win64_vm date debug test mochitest-3 - win64_vm date debug test mochitest-4 - win64_vm date debug test mochitest-5 - win64_vm date debug test mochitest-browser-chrome-1 - win64_vm date debug test mochitest-browser-chrome-2 - win64_vm date debug test mochitest-browser-chrome-3 - win64_vm date debug test mochitest-devtools-chrome-1 - win64_vm date debug test mochitest-devtools-chrome-2 - win64_vm date debug test mochitest-devtools-chrome-3 - win64_vm date debug test mochitest-other - win64_vm date debug test reftest - win64_vm date debug test xpcshell - win64_vm date opt test cppunit - win64_vm date opt test crashtest - win64_vm date opt test jetpack - win64_vm date opt test jittest - win64_vm date opt test jsreftest - win64_vm date opt test mochitest-1 - win64_vm date opt test mochitest-2 - win64_vm date opt test mochitest-3 - win64_vm date opt test mochitest-4 - win64_vm date opt test mochitest-5 - win64_vm date opt test mochitest-browser-chrome-1 - win64_vm date opt test mochitest-browser-chrome-2 - win64_vm date opt test mochitest-browser-chrome-3 - win64_vm date opt test mochitest-devtools-chrome - win64_vm date opt test mochitest-other - win64_vm date opt test reftest - win64_vm date opt test reftest-no-accel - win64_vm date opt test xpcshell
Attachment #8503330 -
Flags: review?(rail)
Comment 2•10 years ago
|
||
Comment on attachment 8503330 [details] [diff] [review] disables vm tests; enables talos lgtm
Attachment #8503330 -
Flags: review?(rail) → review+
Reporter | ||
Updated•10 years ago
|
Attachment #8503330 -
Flags: checked-in+
Comment 3•10 years ago
|
||
Checked in code landed in production
Comment 4•10 years ago
|
||
There are some DB entries for the win8 64 vms: https://secure.pub.build.mozilla.org/buildapi/revision/date/ed32730dc8e1
Reporter | ||
Comment 5•10 years ago
|
||
The default {talos_,}slave_platforms for win32 are ['xp-ix', 'win7-ix', 'win8']. We need to remove win8 from the list of slave platforms for win32 and add 'win8_64' to the list of slave platforms for win64. I think this patch gets us to the desired goal on the date branch. If it looks good on date, then we can change these settings for the other branches. The 'enable_talos' flag here is useless, so I removed it.
Attachment #8505518 -
Flags: review?(rail)
Updated•10 years ago
|
Attachment #8505518 -
Flags: review?(rail) → review+
Reporter | ||
Updated•10 years ago
|
Attachment #8505518 -
Flags: checked-in+
Comment 6•10 years ago
|
||
Merged to production, and deployed.
Reporter | ||
Comment 7•10 years ago
|
||
this code doesn't do anything now that we switched to mozharness
Attachment #8506041 -
Flags: review?(rail)
Reporter | ||
Comment 8•10 years ago
|
||
this will stop triggering tests of the 32-bit builds on the 64-bit win8 machines.
Attachment #8506043 -
Flags: review?(rail)
Updated•10 years ago
|
Attachment #8506041 -
Flags: review?(rail) → review+
Updated•10 years ago
|
Attachment #8506043 -
Flags: review?(rail) → review+
Reporter | ||
Updated•10 years ago
|
Attachment #8506043 -
Flags: checked-in+
Reporter | ||
Updated•10 years ago
|
Attachment #8506041 -
Flags: checked-in+
Comment 9•10 years ago
|
||
In production: https://hg.mozilla.org/build/buildbot-configs/rev/ae0f93785b10
Comment 10•10 years ago
|
||
In production: https://hg.mozilla.org/build/mozharness/rev/1b96260e00c5
Comment 11•10 years ago
|
||
Is win8_64 going to be the final platform name for the buildername? (instead of "Windows 8 64-bit") I have to adjust titanic to accept this different platform name.
Comment 12•10 years ago
|
||
Sure hope so since we already landed TPBL/TH patches under that assumption.
Reporter | ||
Comment 13•10 years ago
|
||
I'm not sure. The other options I can think of are: "WINNT 6.2 64-bit" "WINNT 6.2 x64" some previous examples: "WINNT 6.2" - our current 32-bit win8 tests, which are going away "Windows 7 32-bit" - for our current 32-bit win7 tests, which aren't changing "Ubuntu VM 12.04 x64" - for 64-bit linux tests "Ubuntu VM 12.04" - for 32-bit linux tests Yay consistency.
Comment 14•10 years ago
|
||
*If* we end up changing them, I think "Windows 8 64-bit" makes the most sense. But given that our names are already an inconsistent mess and our tools are already looking for the current names, I'm not sure if it's really worth the effort either.
Comment 15•10 years ago
|
||
I would be happier if at least within the three Windows platforms we had consistency. A while back when I added the iX batch of machines we started using "Windows {7|xp} {$arch}-bit". I think Win8 arrived first to the iX machines and we kept the original WINNT X.Y format. Could we please move to Windows 8 64-bit to make the Windows flavors consistent?
Comment 16•10 years ago
|
||
Attachment #8507199 -
Flags: review?(catlee)
Attachment #8507199 -
Flags: feedback?(ryanvm)
Comment 17•10 years ago
|
||
Comment on attachment 8507199 [details] [diff] [review] rename_win8_64.diff Review of attachment 8507199 [details] [diff] [review]: ----------------------------------------------------------------- Please file TBPL and TH bugs for supporting this change. Definitely better to make it now while they're still running on Date, though.
Attachment #8507199 -
Flags: feedback?(ryanvm) → feedback+
Comment 18•10 years ago
|
||
Great! I will wait for catlee reviewing the patch before filing those bugs.
Reporter | ||
Comment 19•10 years ago
|
||
Comment on attachment 8507199 [details] [diff] [review] rename_win8_64.diff Review of attachment 8507199 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #8507199 -
Flags: review?(catlee) → review+
Comment 20•10 years ago
|
||
Comment on attachment 8507199 [details] [diff] [review] rename_win8_64.diff https://hg.mozilla.org/build/buildbot-configs/rev/4aecd2e78d93 I will file the mentioned bugs.
Attachment #8507199 -
Flags: checked-in+
Comment 21•10 years ago
|
||
Filed bug 1084520, bug 1085549 and bug 1084520.
Comment 22•10 years ago
|
||
In production: https://hg.mozilla.org/build/buildbot-configs/rev/4aecd2e78d93
Reporter | ||
Comment 24•10 years ago
|
||
I love our configs. So, we can't just remove 'win8' from the lists of slave_platforms for 'win32', since the global PLATFORMS is used in various places. The approach I took was to add 'win8_64' as a slave platform of 'win64', and then to use LOOOOOOOPS to add/remove the correct win8 platforms from various branches according to their version. I also cleaned up some talos suites that are no longer used. The result should be that for all trunk-based branches, the old 'WINNT 6.2' builders are replaced with 'Windows 8 64-bit' builders, except for PGO, which we're not running yet. Bug 1086703 for that. The rest of the patch is fixing up various project branches that were hardcoding platforms, and I assume should be using win64 now as well if they were using win32 previously.
Attachment #8508901 -
Flags: review?(jmaher)
Attachment #8508901 -
Flags: review?(bhearsum)
Comment 25•10 years ago
|
||
Comment on attachment 8508901 [details] [diff] [review] switch win8 from 32-bit to 64-bit testing Review of attachment 8508901 [details] [diff] [review]: ----------------------------------------------------------------- the talos bits looks pretty good. Glancing over the rest, I don't see anything that jumps out at me as scary. ::: mozilla-tests/config.py @@ +220,4 @@ > LINUX64_ONLY = get_talos_slave_platforms(PLATFORMS, platforms=('linux64',)) > NO_LINUX64 = get_talos_slave_platforms(PLATFORMS, platforms=('linux', 'win32', 'macosx64', 'win64')) > > +def win864_to_win8(platforms): I don't understand this.
Attachment #8508901 -
Flags: review?(jmaher) → review+
Reporter | ||
Comment 26•10 years ago
|
||
Comment on attachment 8508901 [details] [diff] [review] switch win8 from 32-bit to 64-bit testing Review of attachment 8508901 [details] [diff] [review]: ----------------------------------------------------------------- ::: mozilla-tests/config.py @@ +220,4 @@ > LINUX64_ONLY = get_talos_slave_platforms(PLATFORMS, platforms=('linux64',)) > NO_LINUX64 = get_talos_slave_platforms(PLATFORMS, platforms=('linux', 'win32', 'macosx64', 'win64')) > > +def win864_to_win8(platforms): hmm, looks like this isn't required any more. I'll remove it, and how it's called below.
Comment 27•10 years ago
|
||
Comment on attachment 8508901 [details] [diff] [review] switch win8 from 32-bit to 64-bit testing Review of attachment 8508901 [details] [diff] [review]: ----------------------------------------------------------------- Looks fine to me. Thank you for doing cleanup, you're a saint! Give this man more config bugs!!!
Attachment #8508901 -
Flags: review?(bhearsum) → review+
Reporter | ||
Comment 28•10 years ago
|
||
Attachment #8508952 -
Flags: review?(bhearsum)
Updated•10 years ago
|
Attachment #8508952 -
Flags: review?(bhearsum) → review+
Comment 29•10 years ago
|
||
In production: https://hg.mozilla.org/build/buildbot-configs/rev/e26e8936c6db
Comment 30•10 years ago
|
||
In production: https://hg.mozilla.org/build/buildbot-configs/rev/598fc4933add
Comment 31•10 years ago
|
||
Did we enable pgo for win64?
Comment 32•10 years ago
|
||
Is the "win64 (not run by default)" string on TryChooser no longer accurate?
Comment 33•10 years ago
|
||
> Is the "win64 (not run by default)" string on TryChooser no longer accurate? I filed bug 1088371 about updating TryChooser.
Comment 34•10 years ago
|
||
is there anything left here? We have effectively completed this.
Reporter | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•