1088371 - TryChooser needs updating now that 64-bit builds are done on Windows 8

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Nicholas Nethercote [inactive]]

Now that 64-bit builds are happening for Windows 8, TryChooser needs several things updated.

- The string "win64 (not run by default)" is no longer accurate.

- If you choose "win32" but not "win64", do you just get WinXP and Win7 builds? It's unclear. If so, the labels should probably be changed to something like "win32 (XP, 7)" and "win64 (8)".

- If you choose "all" platforms, "win64" doesn't get selected. It should.

And there are probably other subtleties I'm not aware of.

Comment 2

[Chris AtLee [:catlee]]

Attachment: enable win64 by default on try

I'm a little worried about doing this due to load...but not sure we have much of a choice either.

Comment 3

[Nicholas Nethercote [inactive]]

Are you planning to do the TryChooser UI updates as well in this bug?

Comment 4

[Chris AtLee [:catlee]]

I was hoping somebody else would volunteer :) It's been ages since I've touched TryChooser...

Comment 5

[Release Engineering SlaveAPI Service]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/c126fa2c8a9f

Comment 6

[Steve Fink [:sfink] [:s:]]

(In reply to Nicholas Nethercote [:njn] from comment #0)
> Now that 64-bit builds are happening for Windows 8, TryChooser needs several
> things updated.

Changing this is trivial, though I'm not entirely clear on what the actual configuration is now. But here's the entirety of the patch:

-                <label><input type="checkbox" name="platform" value="win64" class="nondefault">win64</label>
+                <label><input type="checkbox" name="platform" value="win64">win64</label>

> - The string "win64 (not run by default)" is no longer accurate.

That's inserted automatically for the "nondefault" class.

> - If you choose "win32" but not "win64", do you just get WinXP and Win7
> builds? It's unclear. If so, the labels should probably be changed to
> something like "win32 (XP, 7)" and "win64 (8)".

I can never remember how these are arranged, but I don't think this change makes it any more or less complicated. The critical part is that the build platform and the test platform are not the same, and are often different. From looking at the builder names on TH, it looks like 32 bit builds are happening on XP and 64 bit builds are happening on Win7, then the 32 bit builds are run on XP and Win7 and the 64 bit builds are run on Win8. I don't know if the 32 bit builds use a 32-bit or 64-bit compiler, nor whether they are done on a 32- or 64-bit OS.

So I don't think this change actually touches the confusing part of this. Few developers have been aware of the difference between build and test platforms, and this doesn't make it any weirder.

I think the fix you may want is to better label the "Restrict test(s) to platforms" section, eg make it say

   XP (32-bit)
   Win7 (32-bit)
   Win8 (64-bit)

assuming, that is, that the above reflects reality. I have no idea whether it does.

> - If you choose "all" platforms, "win64" doesn't get selected. It should.

That's automatic if you remove the "nondefault" class. (I knew all this crazy logic would come in handy someday.)

> And there are probably other subtleties I'm not aware of.

Yeah, same here. :(

Comment 7

[Steve Fink [:sfink] [:s:]]

Attachment: win64 gets built by default

Comment 9

[Phil Ringnalda (:philor)]

Comment on attachment 8513124 [details] [diff] [review]
win64 gets built by default

http://hg.mozilla.org/build/tools/rev/84950c285ad6